From: Dan Carpenter <dan.carpenter@oracle.com> To: Liam Girdwood <lgirdwood@gmail.com>, G Kranthi <gudishax.kranthikumar@intel.com> Cc: alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>, Jayachandran B <jayachandran.b@intel.com>, kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>, Ramesh Babu <ramesh.babu@intel.com>, Mark Brown <broonie@kernel.org>, Senthilnathan Veppur <senthilnathanx.veppur@intel.com>, Jeeja KP <jeeja.kp@intel.com>, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com> Subject: [PATCH] ASoC: Intel: Skylake: uninitialized variable in error message Date: Thu, 27 Apr 2017 18:50:02 +0000 [thread overview] Message-ID: <20170427185002.r4yv2uuex6t7jz2m@mwanda> (raw) In-Reply-To: <20170420101702.nlq3537xumrseu26@mwanda> "skl" hasn't been initialized yet, so we can't dereference it. Fixes: 9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c index fde4bc0f35b0..f5e7dbb1ba39 100644 --- a/sound/soc/intel/skylake/bxt-sst.c +++ b/sound/soc/intel/skylake/bxt-sst.c @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq, ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev); if (ret < 0) { - dev_err(skl->dev, "%s: no device\n", __func__); + dev_err(dev, "%s: no device\n", __func__); return ret; }
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Liam Girdwood <lgirdwood@gmail.com>, G Kranthi <gudishax.kranthikumar@intel.com> Cc: alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>, Jayachandran B <jayachandran.b@intel.com>, kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>, Ramesh Babu <ramesh.babu@intel.com>, Mark Brown <broonie@kernel.org>, Senthilnathan Veppur <senthilnathanx.veppur@intel.com>, Jeeja KP <jeeja.kp@intel.com>, "Subhransu S. Prusty" <subhransu.s.prusty@intel.com> Subject: [PATCH] ASoC: Intel: Skylake: uninitialized variable in error message Date: Thu, 27 Apr 2017 21:50:02 +0300 [thread overview] Message-ID: <20170427185002.r4yv2uuex6t7jz2m@mwanda> (raw) "skl" hasn't been initialized yet, so we can't dereference it. Fixes: 9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c index fde4bc0f35b0..f5e7dbb1ba39 100644 --- a/sound/soc/intel/skylake/bxt-sst.c +++ b/sound/soc/intel/skylake/bxt-sst.c @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq, ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev); if (ret < 0) { - dev_err(skl->dev, "%s: no device\n", __func__); + dev_err(dev, "%s: no device\n", __func__); return ret; }
next prev parent reply other threads:[~2017-04-27 18:50 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-20 10:17 [PATCH] ASoC: Intel: Skylake: Uninitialized variable in probe_codec() Dan Carpenter 2017-04-20 10:17 ` Dan Carpenter 2017-04-21 17:28 ` Applied "ASoC: Intel: Skylake: Uninitialized variable in probe_codec()" to the asoc tree Mark Brown 2017-04-21 17:28 ` Mark Brown 2017-04-27 18:50 ` Dan Carpenter [this message] 2017-04-27 18:50 ` [PATCH] ASoC: Intel: Skylake: uninitialized variable in error message Dan Carpenter 2017-04-27 22:36 ` Takashi Sakamoto 2017-04-27 22:36 ` Takashi Sakamoto
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170427185002.r4yv2uuex6t7jz2m@mwanda \ --to=dan.carpenter@oracle.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=gudishax.kranthikumar@intel.com \ --cc=jayachandran.b@intel.com \ --cc=jeeja.kp@intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=ramesh.babu@intel.com \ --cc=senthilnathanx.veppur@intel.com \ --cc=subhransu.s.prusty@intel.com \ --cc=tiwai@suse.com \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.