All of lore.kernel.org
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: dri-devel@lists.freedesktop.org, dm-devel@redhat.com,
	target-devel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	devel@driverdev.osuosl.org,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	linux-scsi@vger.kernel.org, linux-nvdimm@lists.01.org,
	linux-rdma@vger.kernel.org,
	Sumit Semwal <sumit.semwal@linaro.org>,
	open-iscsi@googlegroups.com, linux-media@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, sparmaintainer@unisys.com,
	linux-raid@vger.kernel.org, megaraidlinux.pdl@broadcom.com,
	Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	netdev@vger.kernel.org, Matthew Wilcox <mawilcox@microsoft.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-crypto@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Date: Fri, 28 Apr 2017 14:30:39 +0800	[thread overview]
Message-ID: <20170428063039.GB6817@gondor.apana.org.au> (raw)
In-Reply-To: <94123cbf-3287-f05e-7267-0bcf08ab0a8b@deltatee.com>

On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote:
> 
> 
> On 26/04/17 09:56 PM, Herbert Xu wrote:
> > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote:
> >> Very straightforward conversion to the new function in the caam driver
> >> and shash library.
> >>
> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> >> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> ---
> >>  crypto/shash.c                | 9 ++++++---
> >>  drivers/crypto/caam/caamalg.c | 8 +++-----
> >>  2 files changed, 9 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/crypto/shash.c b/crypto/shash.c
> >> index 5e31c8d..5914881 100644
> >> --- a/crypto/shash.c
> >> +++ b/crypto/shash.c
> >> @@ -283,10 +283,13 @@ int shash_ahash_digest(struct ahash_request *req, struct shash_desc *desc)
> >>  	if (nbytes < min(sg->length, ((unsigned int)(PAGE_SIZE)) - offset)) {
> >>  		void *data;
> >>  
> >> -		data = kmap_atomic(sg_page(sg));
> >> -		err = crypto_shash_digest(desc, data + offset, nbytes,
> >> +		data = sg_map(sg, 0, SG_KMAP_ATOMIC);
> >> +		if (IS_ERR(data))
> >> +			return PTR_ERR(data);
> >> +
> >> +		err = crypto_shash_digest(desc, data, nbytes,
> >>  					  req->result);
> >> -		kunmap_atomic(data);
> >> +		sg_unmap(sg, data, 0, SG_KMAP_ATOMIC);
> >>  		crypto_yield(desc->flags);
> >>  	} else
> >>  		err = crypto_shash_init(desc) ?:
> > 
> > Nack.  This is an optimisation for the special case of a single
> > SG list entry.  In fact in the common case the kmap_atomic should
> > disappear altogether in the no-highmem case.  So replacing it
> > with sg_map is not acceptable.
> 
> What you seem to have missed is that sg_map is just a thin wrapper
> around kmap_atomic. Perhaps with a future check for a mappable page.
> This change should have zero impact on performance.

You are right.  Indeed the existing code looks buggy as they
don't take sg->offset into account when doing the kmap.  Could
you send me some patches that fix these problems first so that
they can be easily backported?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
To: Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	target-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	devel-gWbeCf7V1WCQmaza687I9mD2FQJk+8+b@public.gmane.org,
	"James E.J. Bottomley"
	<jejb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Sumit Semwal
	<sumit.semwal-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	sparmaintainer-GLv8BlqOqDDQT0dZR+AlfA@public.gmane.org,
	linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	megaraidlinux.pdl-dY08KVG/lbpWk0Htik3J/w@public.gmane.org,
	Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>,
	"Martin K. Petersen"
	<martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Matthew Wilcox <mawilcox-0li6OtcxBFHby3iVrkZq2A@public.gmane.org>,
	linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
	"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Date: Fri, 28 Apr 2017 14:30:39 +0800	[thread overview]
Message-ID: <20170428063039.GB6817@gondor.apana.org.au> (raw)
In-Reply-To: <94123cbf-3287-f05e-7267-0bcf08ab0a8b-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>

On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote:
> 
> 
> On 26/04/17 09:56 PM, Herbert Xu wrote:
> > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote:
> >> Very straightforward conversion to the new function in the caam driver
> >> and shash library.
> >>
> >> Signed-off-by: Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
> >> Cc: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
> >> Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
> >> ---
> >>  crypto/shash.c                | 9 ++++++---
> >>  drivers/crypto/caam/caamalg.c | 8 +++-----
> >>  2 files changed, 9 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/crypto/shash.c b/crypto/shash.c
> >> index 5e31c8d..5914881 100644
> >> --- a/crypto/shash.c
> >> +++ b/crypto/shash.c
> >> @@ -283,10 +283,13 @@ int shash_ahash_digest(struct ahash_request *req, struct shash_desc *desc)
> >>  	if (nbytes < min(sg->length, ((unsigned int)(PAGE_SIZE)) - offset)) {
> >>  		void *data;
> >>  
> >> -		data = kmap_atomic(sg_page(sg));
> >> -		err = crypto_shash_digest(desc, data + offset, nbytes,
> >> +		data = sg_map(sg, 0, SG_KMAP_ATOMIC);
> >> +		if (IS_ERR(data))
> >> +			return PTR_ERR(data);
> >> +
> >> +		err = crypto_shash_digest(desc, data, nbytes,
> >>  					  req->result);
> >> -		kunmap_atomic(data);
> >> +		sg_unmap(sg, data, 0, SG_KMAP_ATOMIC);
> >>  		crypto_yield(desc->flags);
> >>  	} else
> >>  		err = crypto_shash_init(desc) ?:
> > 
> > Nack.  This is an optimisation for the special case of a single
> > SG list entry.  In fact in the common case the kmap_atomic should
> > disappear altogether in the no-highmem case.  So replacing it
> > with sg_map is not acceptable.
> 
> What you seem to have missed is that sg_map is just a thin wrapper
> around kmap_atomic. Perhaps with a future check for a mappable page.
> This change should have zero impact on performance.

You are right.  Indeed the existing code looks buggy as they
don't take sg->offset into account when doing the kmap.  Could
you send me some patches that fix these problems first so that
they can be easily backported?

Thanks,
-- 
Email: Herbert Xu <herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-nvdimm@ml01.01.org,
	linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
	megaraidlinux.pdl@broadcom.com, sparmaintainer@unisys.com,
	devel@driverdev.osuosl.org, target-devel@vger.kernel.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	Jens Axboe <axboe@kernel.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Matthew Wilcox <mawilcox@microsoft.com>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Stephen Bates <sbates@raithlin.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Date: Fri, 28 Apr 2017 14:30:39 +0800	[thread overview]
Message-ID: <20170428063039.GB6817@gondor.apana.org.au> (raw)
In-Reply-To: <94123cbf-3287-f05e-7267-0bcf08ab0a8b@deltatee.com>

On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote:
> 
> 
> On 26/04/17 09:56 PM, Herbert Xu wrote:
> > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote:
> >> Very straightforward conversion to the new function in the caam driver
> >> and shash library.
> >>
> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> >> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> ---
> >>  crypto/shash.c                | 9 ++++++---
> >>  drivers/crypto/caam/caamalg.c | 8 +++-----
> >>  2 files changed, 9 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/crypto/shash.c b/crypto/shash.c
> >> index 5e31c8d..5914881 100644
> >> --- a/crypto/shash.c
> >> +++ b/crypto/shash.c
> >> @@ -283,10 +283,13 @@ int shash_ahash_digest(struct ahash_request *req, struct shash_desc *desc)
> >>  	if (nbytes < min(sg->length, ((unsigned int)(PAGE_SIZE)) - offset)) {
> >>  		void *data;
> >>  
> >> -		data = kmap_atomic(sg_page(sg));
> >> -		err = crypto_shash_digest(desc, data + offset, nbytes,
> >> +		data = sg_map(sg, 0, SG_KMAP_ATOMIC);
> >> +		if (IS_ERR(data))
> >> +			return PTR_ERR(data);
> >> +
> >> +		err = crypto_shash_digest(desc, data, nbytes,
> >>  					  req->result);
> >> -		kunmap_atomic(data);
> >> +		sg_unmap(sg, data, 0, SG_KMAP_ATOMIC);
> >>  		crypto_yield(desc->flags);
> >>  	} else
> >>  		err = crypto_shash_init(desc) ?:
> > 
> > Nack.  This is an optimisation for the special case of a single
> > SG list entry.  In fact in the common case the kmap_atomic should
> > disappear altogether in the no-highmem case.  So replacing it
> > with sg_map is not acceptable.
> 
> What you seem to have missed is that sg_map is just a thin wrapper
> around kmap_atomic. Perhaps with a future check for a mappable page.
> This change should have zero impact on performance.

You are right.  Indeed the existing code looks buggy as they
don't take sg->offset into account when doing the kmap.  Could
you send me some patches that fix these problems first so that
they can be easily backported?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	intel-gfx@lists.freedesktop.org, linux-raid@vger.kernel.org,
	linux-mmc@vger.kernel.org, linux-nvdimm@lists.01.org,
	linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com,
	megaraidlinux.pdl@broadcom.com, sparmaintainer@unisys.com,
	devel@driverdev.osuosl.org, target-devel@vger.kernel.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
	Jens Axboe <axboe@kernel.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Matthew Wilcox <mawilcox@microsoft.com>,
	Sumit Semwal <sumit.semwal@linaro.org>,
	Stephen Bates <sbates@raithlin.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function
Date: Fri, 28 Apr 2017 14:30:39 +0800	[thread overview]
Message-ID: <20170428063039.GB6817@gondor.apana.org.au> (raw)
In-Reply-To: <94123cbf-3287-f05e-7267-0bcf08ab0a8b@deltatee.com>

On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote:
> 
> 
> On 26/04/17 09:56 PM, Herbert Xu wrote:
> > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote:
> >> Very straightforward conversion to the new function in the caam driver
> >> and shash library.
> >>
> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> >> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> ---
> >>  crypto/shash.c                | 9 ++++++---
> >>  drivers/crypto/caam/caamalg.c | 8 +++-----
> >>  2 files changed, 9 insertions(+), 8 deletions(-)
> >>
> >> diff --git a/crypto/shash.c b/crypto/shash.c
> >> index 5e31c8d..5914881 100644
> >> --- a/crypto/shash.c
> >> +++ b/crypto/shash.c
> >> @@ -283,10 +283,13 @@ int shash_ahash_digest(struct ahash_request *req, struct shash_desc *desc)
> >>  	if (nbytes < min(sg->length, ((unsigned int)(PAGE_SIZE)) - offset)) {
> >>  		void *data;
> >>  
> >> -		data = kmap_atomic(sg_page(sg));
> >> -		err = crypto_shash_digest(desc, data + offset, nbytes,
> >> +		data = sg_map(sg, 0, SG_KMAP_ATOMIC);
> >> +		if (IS_ERR(data))
> >> +			return PTR_ERR(data);
> >> +
> >> +		err = crypto_shash_digest(desc, data, nbytes,
> >>  					  req->result);
> >> -		kunmap_atomic(data);
> >> +		sg_unmap(sg, data, 0, SG_KMAP_ATOMIC);
> >>  		crypto_yield(desc->flags);
> >>  	} else
> >>  		err = crypto_shash_init(desc) ?:
> > 
> > Nack.  This is an optimisation for the special case of a single
> > SG list entry.  In fact in the common case the kmap_atomic should
> > disappear altogether in the no-highmem case.  So replacing it
> > with sg_map is not acceptable.
> 
> What you seem to have missed is that sg_map is just a thin wrapper
> around kmap_atomic. Perhaps with a future check for a mappable page.
> This change should have zero impact on performance.

You are right.  Indeed the existing code looks buggy as they
don't take sg->offset into account when doing the kmap.  Could
you send me some patches that fix these problems first so that
they can be easily backported?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

  reply	other threads:[~2017-04-28  6:32 UTC|newest]

Thread overview: 183+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 18:20 [PATCH v2 00/21] Introduce common scatterlist map function Logan Gunthorpe
2017-04-25 18:20 ` Logan Gunthorpe
2017-04-25 18:20 ` Logan Gunthorpe
2017-04-25 18:20 ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-26  7:44   ` Christoph Hellwig
2017-04-26  7:44     ` Christoph Hellwig
2017-04-26  7:44     ` Christoph Hellwig
2017-04-26  7:44     ` Christoph Hellwig
2017-04-26  7:44     ` Christoph Hellwig
2017-04-26 18:11     ` Logan Gunthorpe
2017-04-26 18:11       ` Logan Gunthorpe
2017-04-26 18:11       ` Logan Gunthorpe
2017-04-26 18:11       ` Logan Gunthorpe
2017-04-27  6:53       ` Christoph Hellwig
2017-04-27  6:53         ` Christoph Hellwig
2017-04-27  6:53         ` Christoph Hellwig
2017-04-27  6:53         ` Christoph Hellwig
2017-04-27  6:53         ` Christoph Hellwig
     [not found]         ` <20170427065338.GA20677-jcswGhMUV9g@public.gmane.org>
2017-04-27 15:27           ` Jason Gunthorpe
2017-04-27 15:27             ` Jason Gunthorpe
     [not found]             ` <20170427152720.GA7662-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-27 15:57               ` Logan Gunthorpe
2017-04-27 15:57                 ` Logan Gunthorpe
2017-04-27 15:44         ` Logan Gunthorpe
2017-04-27 15:44           ` Logan Gunthorpe
2017-04-27 15:44           ` Logan Gunthorpe
2017-04-27 15:44           ` Logan Gunthorpe
2017-04-27 20:13     ` Logan Gunthorpe
2017-04-27 20:13       ` Logan Gunthorpe
2017-04-27 20:13       ` Logan Gunthorpe
2017-04-27 20:13       ` Logan Gunthorpe
2017-04-26  8:59   ` Christian König
2017-04-26  8:59     ` Christian König
2017-04-26  8:59     ` Christian König
2017-04-26  8:59     ` Christian König
2017-04-26  8:59     ` Christian König
2017-04-26 23:30     ` Logan Gunthorpe
2017-04-26 23:30       ` Logan Gunthorpe
2017-04-26 23:30       ` Logan Gunthorpe
2017-04-26 23:30       ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 02/21] libiscsi: Add an internal error code Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-26  7:48   ` Christoph Hellwig
2017-04-26  7:48     ` Christoph Hellwig
2017-04-26  7:48     ` Christoph Hellwig
2017-04-26  7:48     ` Christoph Hellwig
2017-04-26  7:48     ` Christoph Hellwig
2017-04-25 18:20 ` [PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 04/21] target: Make use of the new sg_map function at 16 call sites Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 06/21] crypto: hifn_795x: " Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 07/21] crypto: shash, caam: " Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-27  3:56   ` Herbert Xu
2017-04-27  3:56     ` Herbert Xu
2017-04-27  3:56     ` Herbert Xu
2017-04-27  3:56     ` Herbert Xu
2017-04-27  3:56     ` Herbert Xu
2017-04-27 15:45     ` Logan Gunthorpe
2017-04-27 15:45       ` Logan Gunthorpe
2017-04-27 15:45       ` Logan Gunthorpe
2017-04-27 15:45       ` Logan Gunthorpe
2017-04-28  6:30       ` Herbert Xu [this message]
2017-04-28  6:30         ` Herbert Xu
2017-04-28  6:30         ` Herbert Xu
2017-04-28  6:30         ` Herbert Xu
2017-04-28 16:53         ` Logan Gunthorpe
2017-04-28 16:53           ` Logan Gunthorpe
2017-04-28 16:53           ` Logan Gunthorpe
2017-04-28 16:53           ` Logan Gunthorpe
2017-04-28 17:51           ` Herbert Xu
2017-04-28 17:51             ` Herbert Xu
2017-04-28 17:51             ` Herbert Xu
2017-04-28 17:51             ` Herbert Xu
2017-04-28 19:01             ` Logan Gunthorpe
2017-04-28 19:01               ` Logan Gunthorpe
2017-04-28 19:01               ` Logan Gunthorpe
2017-04-28 19:01               ` Logan Gunthorpe
2017-04-28 19:01               ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 10/21] RDS: " Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20 ` [PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:20   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 13/21] scsi: arcmsr, ips, megaraid: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-26  7:37   ` Roger Pau Monné
2017-04-26  7:37     ` Roger Pau Monné
2017-04-26  7:37     ` Roger Pau Monné
2017-04-26  7:37     ` Roger Pau Monné
2017-04-26  7:37     ` Roger Pau Monné
2017-04-27 20:19     ` Logan Gunthorpe
2017-04-27 20:19       ` Logan Gunthorpe
2017-04-27 20:19       ` Logan Gunthorpe
2017-04-27 20:19       ` Logan Gunthorpe
2017-04-27 20:19       ` Logan Gunthorpe
     [not found]       ` <df6586e2-7d45-6b0b-facb-4dea882df06e-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2017-04-27 20:53         ` Jason Gunthorpe
2017-04-27 20:53           ` Jason Gunthorpe
2017-04-27 20:53           ` Jason Gunthorpe
     [not found]           ` <20170427205339.GB26330-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-27 21:53             ` Logan Gunthorpe
2017-04-27 21:53               ` Logan Gunthorpe
2017-04-27 21:53               ` Logan Gunthorpe
     [not found]               ` <02ba3c7b-5fab-a06c-fbbf-c3be1c0fae1b-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2017-04-27 22:11                 ` Jason Gunthorpe
2017-04-27 22:11                   ` Jason Gunthorpe
2017-04-27 22:11                   ` Jason Gunthorpe
     [not found]                   ` <20170427221132.GA30036-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-04-27 23:03                     ` Logan Gunthorpe
2017-04-27 23:03                       ` Logan Gunthorpe
2017-04-27 23:03                       ` Logan Gunthorpe
     [not found]                       ` <3a7c0d27-0744-4e91-b37f-3885c50455e8-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
2017-04-27 23:20                         ` Jason Gunthorpe
2017-04-27 23:20                           ` Jason Gunthorpe
2017-04-27 23:20                           ` Jason Gunthorpe
2017-04-27 23:29                           ` Logan Gunthorpe
2017-04-27 23:29                             ` Logan Gunthorpe
2017-04-27 23:29                             ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 16/21] mmc: sdhci: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 17/21] mmc: spi: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 18/21] mmc: tmio: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 19/21] mmc: sdricoh_cs: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 20/21] mmc: tifm_sd: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21 ` [PATCH v2 21/21] memstick: " Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:21   ` Logan Gunthorpe
2017-04-25 18:40 ` ✓ Fi.CI.BAT: success for Introduce common scatterlist map function (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170428063039.GB6817@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=axboe@kernel.dk \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=dm-devel@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=logang@deltatee.com \
    --cc=martin.petersen@oracle.com \
    --cc=mawilcox@microsoft.com \
    --cc=megaraidlinux.pdl@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=open-iscsi@googlegroups.com \
    --cc=sparmaintainer@unisys.com \
    --cc=sumit.semwal@linaro.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.