From: Takashi Iwai <tiwai@suse.de> To: alsa-devel@alsa-project.org Cc: Stefan Wahren <stefan.wahren@i2se.com>, Lee Jones <lee@kernel.org>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Jaikrishna Nemallapudi <jaikrishnax.nemallapudi@intel.com>, Eric Anholt <eric@anholt.net>, linux-rpi-kernel@lists.infradead.org, "Subhransu S . Prusty" <subhransu.s.prusty@intel.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/7] ALSA: emu10k1: Deliver indirect-PCM transfer error Date: Sun, 21 May 2017 21:02:55 +0200 [thread overview] Message-ID: <20170521190258.1178-5-tiwai@suse.de> (raw) In-Reply-To: <20170521190258.1178-1-tiwai@suse.de> Now that the indirect-PCM transfer helper gives back an error, we should return the error from ack callbacks. Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/pci/emu10k1/emupcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c index ef1cf530c929..bdda29f335f6 100644 --- a/sound/pci/emu10k1/emupcm.c +++ b/sound/pci/emu10k1/emupcm.c @@ -1632,8 +1632,8 @@ static int snd_emu10k1_fx8010_playback_transfer(struct snd_pcm_substream *substr struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream); struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number]; - snd_pcm_indirect_playback_transfer(substream, &pcm->pcm_rec, fx8010_pb_trans_copy); - return 0; + return snd_pcm_indirect_playback_transfer(substream, &pcm->pcm_rec, + fx8010_pb_trans_copy); } static int snd_emu10k1_fx8010_playback_hw_params(struct snd_pcm_substream *substream, -- 2.13.0
WARNING: multiple messages have this Message-ID (diff)
From: tiwai@suse.de (Takashi Iwai) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/7] ALSA: emu10k1: Deliver indirect-PCM transfer error Date: Sun, 21 May 2017 21:02:55 +0200 [thread overview] Message-ID: <20170521190258.1178-5-tiwai@suse.de> (raw) In-Reply-To: <20170521190258.1178-1-tiwai@suse.de> Now that the indirect-PCM transfer helper gives back an error, we should return the error from ack callbacks. Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/pci/emu10k1/emupcm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/emu10k1/emupcm.c b/sound/pci/emu10k1/emupcm.c index ef1cf530c929..bdda29f335f6 100644 --- a/sound/pci/emu10k1/emupcm.c +++ b/sound/pci/emu10k1/emupcm.c @@ -1632,8 +1632,8 @@ static int snd_emu10k1_fx8010_playback_transfer(struct snd_pcm_substream *substr struct snd_emu10k1 *emu = snd_pcm_substream_chip(substream); struct snd_emu10k1_fx8010_pcm *pcm = &emu->fx8010.pcm[substream->number]; - snd_pcm_indirect_playback_transfer(substream, &pcm->pcm_rec, fx8010_pb_trans_copy); - return 0; + return snd_pcm_indirect_playback_transfer(substream, &pcm->pcm_rec, + fx8010_pb_trans_copy); } static int snd_emu10k1_fx8010_playback_hw_params(struct snd_pcm_substream *substream, -- 2.13.0
next prev parent reply other threads:[~2017-05-21 19:02 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-21 19:02 [PATCH 0/7] ALSA: Fix/improve PCM ack callback Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai 2017-05-21 19:02 ` [PATCH 1/7] ALSA: pcm: Fix negative appl_ptr handling in pcm-indirect helpers Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai [not found] ` <20170521190258.1178-1-tiwai-l3A5Bk7waGM@public.gmane.org> 2017-05-21 19:02 ` [PATCH 2/7] ALSA: mips: Deliver indirect-PCM transfer error Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai 2017-05-21 19:02 ` [PATCH 3/7] ALSA: cs46xx: " Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai [this message] 2017-05-21 19:02 ` [PATCH 4/7] ALSA: emu10k1: " Takashi Iwai 2017-05-21 19:02 ` [PATCH 5/7] ALSA: rme32: " Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai 2017-05-21 19:02 ` [PATCH 6/7] staging: bcm2835-audio: " Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai 2017-05-22 16:33 ` Eric Anholt 2017-05-22 16:33 ` Eric Anholt 2017-05-21 19:02 ` [PATCH 7/7] ALSA: pcm: Call ack() whenever appl_ptr is updated Takashi Iwai 2017-05-21 19:02 ` Takashi Iwai 2017-05-22 3:49 ` [PATCH 0/7] ALSA: Fix/improve PCM ack callback Takashi Sakamoto 2017-05-22 3:49 ` Takashi Sakamoto 2017-05-22 5:27 ` Takashi Iwai 2017-05-22 5:27 ` Takashi Iwai 2017-05-22 6:31 ` Takashi Sakamoto 2017-05-22 6:31 ` Takashi Sakamoto 2017-05-22 6:46 ` Takashi Iwai 2017-05-22 6:46 ` Takashi Iwai 2017-05-22 7:07 ` Takashi Iwai 2017-05-22 7:07 ` Takashi Iwai 2017-05-25 21:39 ` Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170521190258.1178-5-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ --cc=eric@anholt.net \ --cc=jaikrishnax.nemallapudi@intel.com \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=stefan.wahren@i2se.com \ --cc=subhransu.s.prusty@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.