From: kbuild test robot <lkp@intel.com> To: Chris Packham <chris.packham@alliedtelesis.co.nz> Cc: kbuild-all@01.org, broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Packham <chris.packham@alliedtelesis.co.nz> Subject: Re: [PATCH 2/2] spi: use gpio_desc instead of numeric gpio Date: Wed, 24 May 2017 10:23:54 +0800 [thread overview] Message-ID: <201705241058.MgeUe0J5%fengguang.wu@intel.com> (raw) In-Reply-To: <20170523040322.10433-2-chris.packham@alliedtelesis.co.nz> [-- Attachment #1: Type: text/plain, Size: 2074 bytes --] Hi Chris, [auto build test ERROR on spi/for-next] [also build test ERROR on v4.12-rc2 next-20170523] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Packham/spi-orion-Handle-GPIO-chip-selects/20170524-074032 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next config: sparc-defconfig (attached as .config) compiler: sparc-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc All error/warnings (new ones prefixed by >>): drivers/spi/spi.c: In function 'spi_set_cs': >> drivers/spi/spi.c:728:28: error: implicit declaration of function 'gpio_to_desc' [-Werror=implicit-function-declaration] struct gpio_desc *gpio = gpio_to_desc(spi->cs_gpio); ^~~~~~~~~~~~ >> drivers/spi/spi.c:728:28: warning: initialization makes pointer from integer without a cast [-Wint-conversion] >> drivers/spi/spi.c:731:4: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] gpiod_set_value(gpio, !enable); ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/gpio_to_desc +728 drivers/spi/spi.c 722 static void spi_set_cs(struct spi_device *spi, bool enable) 723 { 724 if (spi->mode & SPI_CS_HIGH) 725 enable = !enable; 726 727 if (gpio_is_valid(spi->cs_gpio)) { > 728 struct gpio_desc *gpio = gpio_to_desc(spi->cs_gpio); 729 730 if (gpio) > 731 gpiod_set_value(gpio, !enable); 732 /* Some SPI masters need both GPIO CS & slave_select */ 733 if ((spi->master->flags & SPI_MASTER_GPIO_SS) && 734 spi->master->set_cs) --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 12031 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> To: Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> Cc: kbuild-all-JC7UmRfGjtg@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Chris Packham <chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> Subject: Re: [PATCH 2/2] spi: use gpio_desc instead of numeric gpio Date: Wed, 24 May 2017 10:23:54 +0800 [thread overview] Message-ID: <201705241058.MgeUe0J5%fengguang.wu@intel.com> (raw) In-Reply-To: <20170523040322.10433-2-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2074 bytes --] Hi Chris, [auto build test ERROR on spi/for-next] [also build test ERROR on v4.12-rc2 next-20170523] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Packham/spi-orion-Handle-GPIO-chip-selects/20170524-074032 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next config: sparc-defconfig (attached as .config) compiler: sparc-linux-gcc (GCC) 6.2.0 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc All error/warnings (new ones prefixed by >>): drivers/spi/spi.c: In function 'spi_set_cs': >> drivers/spi/spi.c:728:28: error: implicit declaration of function 'gpio_to_desc' [-Werror=implicit-function-declaration] struct gpio_desc *gpio = gpio_to_desc(spi->cs_gpio); ^~~~~~~~~~~~ >> drivers/spi/spi.c:728:28: warning: initialization makes pointer from integer without a cast [-Wint-conversion] >> drivers/spi/spi.c:731:4: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration] gpiod_set_value(gpio, !enable); ^~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/gpio_to_desc +728 drivers/spi/spi.c 722 static void spi_set_cs(struct spi_device *spi, bool enable) 723 { 724 if (spi->mode & SPI_CS_HIGH) 725 enable = !enable; 726 727 if (gpio_is_valid(spi->cs_gpio)) { > 728 struct gpio_desc *gpio = gpio_to_desc(spi->cs_gpio); 729 730 if (gpio) > 731 gpiod_set_value(gpio, !enable); 732 /* Some SPI masters need both GPIO CS & slave_select */ 733 if ((spi->master->flags & SPI_MASTER_GPIO_SS) && 734 spi->master->set_cs) --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 12031 bytes --]
next prev parent reply other threads:[~2017-05-24 2:24 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-23 4:03 [PATCH 1/2] spi: orion: Handle GPIO chip-selects Chris Packham 2017-05-23 4:03 ` Chris Packham 2017-05-23 4:03 ` [PATCH 2/2] spi: use gpio_desc instead of numeric gpio Chris Packham 2017-05-23 18:28 ` Andy Shevchenko 2017-05-23 20:43 ` Chris Packham 2017-05-24 5:42 ` Chris Packham 2017-05-24 5:42 ` Chris Packham 2017-05-24 17:02 ` Mark Brown 2017-05-24 17:02 ` Mark Brown 2017-05-24 17:00 ` Mark Brown 2017-05-24 17:00 ` Mark Brown 2017-05-24 2:23 ` kbuild test robot [this message] 2017-05-24 2:23 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201705241058.MgeUe0J5%fengguang.wu@intel.com \ --to=lkp@intel.com \ --cc=broonie@kernel.org \ --cc=chris.packham@alliedtelesis.co.nz \ --cc=kbuild-all@01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.