All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	linux-spi <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 0/5] *** SPI Slave mode support ***
Date: Wed, 24 May 2017 18:29:40 +0100	[thread overview]
Message-ID: <20170524172940.6vypisacs3rmmjws@sirena.org.uk> (raw)
In-Reply-To: <59019306.2050309@mentor.com>

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Wed, Apr 26, 2017 at 11:43:18PM -0700, Jiada Wang wrote:

> The reason I gave the example use case is want to point out that
> with Geert's patch set, a SPI device (with only one controller) can no
> longer
> act as master and slave at the same time. because IMO as a SPI core
> function,
> it needs to cover all the use cases, and to be as generic as possible.

> BUT if you think the use case don't need to be supported from SPI core,
> then I don't have objection either, I will only submit imx SPI slave support
> patch,
> after your SPI slave support patch set been applied

I think there's a bunch of other problems with how that works reliably
that'd need to be addressed before someone could actually do that, and
it seems like such hardware will be very unusual.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jiada Wang <jiada_wang-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
Cc: Geert Uytterhoeven
	<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Fabio Estevam <fabio.estevam-3arQi8VN3Tc@public.gmane.org>,
	linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH RFC 0/5] *** SPI Slave mode support ***
Date: Wed, 24 May 2017 18:29:40 +0100	[thread overview]
Message-ID: <20170524172940.6vypisacs3rmmjws@sirena.org.uk> (raw)
In-Reply-To: <59019306.2050309-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 775 bytes --]

On Wed, Apr 26, 2017 at 11:43:18PM -0700, Jiada Wang wrote:

> The reason I gave the example use case is want to point out that
> with Geert's patch set, a SPI device (with only one controller) can no
> longer
> act as master and slave at the same time. because IMO as a SPI core
> function,
> it needs to cover all the use cases, and to be as generic as possible.

> BUT if you think the use case don't need to be supported from SPI core,
> then I don't have objection either, I will only submit imx SPI slave support
> patch,
> after your SPI slave support patch set been applied

I think there's a bunch of other problems with how that works reliably
that'd need to be addressed before someone could actually do that, and
it seems like such hardware will be very unusual.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 0/5] *** SPI Slave mode support ***
Date: Wed, 24 May 2017 18:29:40 +0100	[thread overview]
Message-ID: <20170524172940.6vypisacs3rmmjws@sirena.org.uk> (raw)
In-Reply-To: <59019306.2050309@mentor.com>

On Wed, Apr 26, 2017 at 11:43:18PM -0700, Jiada Wang wrote:

> The reason I gave the example use case is want to point out that
> with Geert's patch set, a SPI device (with only one controller) can no
> longer
> act as master and slave at the same time. because IMO as a SPI core
> function,
> it needs to cover all the use cases, and to be as generic as possible.

> BUT if you think the use case don't need to be supported from SPI core,
> then I don't have objection either, I will only submit imx SPI slave support
> patch,
> after your SPI slave support patch set been applied

I think there's a bunch of other problems with how that works reliably
that'd need to be addressed before someone could actually do that, and
it seems like such hardware will be very unusual.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170524/3669a671/attachment.sig>

  reply	other threads:[~2017-05-24 17:30 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 12:13 [PATCH RFC 0/5] *** SPI Slave mode support *** jiada_wang
2017-04-13 12:13 ` jiada_wang at mentor.com
2017-04-13 12:13 ` jiada_wang
2017-04-13 12:13 ` jiada_wang
2017-04-13 12:14 ` [PATCH RFC 1/5] spi: core: add support to work in Slave mode jiada_wang
2017-04-13 12:14   ` jiada_wang at mentor.com
2017-04-13 12:14   ` jiada_wang-nmGgyN9QBj3QT0dZR+AlfA
2017-04-13 12:14   ` jiada_wang-nmGgyN9QBj3QT0dZR+AlfA
2017-04-13 12:14 ` [PATCH RFC 2/5] spi: spidev: use different name for SPI controller slave mode device jiada_wang
2017-04-13 12:14   ` jiada_wang at mentor.com
2017-04-13 12:14   ` jiada_wang
2017-04-13 12:14   ` jiada_wang
2017-04-13 12:14 ` [PATCH RFC 3/5] spi: imx: add selection for iMX53 and iMX6 controller jiada_wang
2017-04-13 12:14   ` jiada_wang at mentor.com
2017-04-13 12:14   ` jiada_wang
2017-04-13 12:14 ` [PATCH RFC 4/5] ARM: dts: imx: change compatiblity for SPI controllers on imx53 later soc jiada_wang
2017-04-13 12:14   ` jiada_wang at mentor.com
2017-04-13 12:14   ` jiada_wang
2017-04-13 12:14 ` [PATCH RFC 5/5] spi: imx: Add support for SPI Slave mode for imx53 and imx6 chips jiada_wang
2017-04-13 12:14   ` jiada_wang at mentor.com
2017-04-13 12:14   ` jiada_wang
2017-04-13 12:59 ` [PATCH RFC 0/5] *** SPI Slave mode support *** Mark Brown
2017-04-13 12:59   ` Mark Brown
2017-04-13 12:59   ` Mark Brown
2017-04-13 19:47   ` Geert Uytterhoeven
2017-04-13 19:47     ` Geert Uytterhoeven
2017-04-13 19:47     ` Geert Uytterhoeven
2017-04-14  5:39     ` Jiada Wang
2017-04-14  5:39       ` Jiada Wang
2017-04-14  5:39       ` Jiada Wang
2017-04-24 10:55       ` Geert Uytterhoeven
2017-04-24 10:55         ` Geert Uytterhoeven
2017-04-24 10:55         ` Geert Uytterhoeven
2017-04-24 12:48         ` Jiada Wang
2017-04-24 12:48           ` Jiada Wang
2017-04-24 12:48           ` Jiada Wang
2017-04-24 13:10           ` Geert Uytterhoeven
2017-04-24 13:10             ` Geert Uytterhoeven
2017-04-24 13:10             ` Geert Uytterhoeven
2017-04-25  7:56             ` Jiada Wang
2017-04-25  7:56               ` Jiada Wang
2017-04-25  7:56               ` Jiada Wang
2017-04-25  8:07               ` Uwe Kleine-König
2017-04-25  8:07                 ` Uwe Kleine-König
2017-04-25  8:07                 ` Uwe Kleine-König
2017-04-25  8:09               ` Geert Uytterhoeven
2017-04-25  8:09                 ` Geert Uytterhoeven
2017-04-25  8:09                 ` Geert Uytterhoeven
2017-04-25 10:31         ` Mark Brown
2017-04-25 10:31           ` Mark Brown
2017-04-25 10:31           ` Mark Brown
2017-04-27  6:43           ` Jiada Wang
2017-04-27  6:43             ` Jiada Wang
2017-04-27  6:43             ` Jiada Wang
2017-05-24 17:29             ` Mark Brown [this message]
2017-05-24 17:29               ` Mark Brown
2017-05-24 17:29               ` Mark Brown
2017-05-29 12:01             ` Fabio Estevam
2017-05-29 12:01               ` Fabio Estevam
2017-05-29 12:01               ` Fabio Estevam
2017-05-30  2:53               ` Jiada Wang
2017-05-30  2:53                 ` Jiada Wang
2017-05-30  2:53                 ` Jiada Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170524172940.6vypisacs3rmmjws@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=geert@linux-m68k.org \
    --cc=jiada_wang@mentor.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.