From: "hch@lst.de" <hch@lst.de> To: Bart Van Assche <Bart.VanAssche@sandisk.com> Cc: "hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>, "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org> Subject: Re: [PATCH 02/15] scsi/osd: don't save block errors into req_results Date: Fri, 26 May 2017 07:15:40 +0200 [thread overview] Message-ID: <20170526051540.GA17709@lst.de> (raw) In-Reply-To: <1495641879.2823.7.camel@sandisk.com> On Wed, May 24, 2017 at 04:04:40PM +0000, Bart Van Assche wrote: > Are you sure that that code is not necessary? From osd_initiator.c: > > static void _put_request(struct request *rq) > { > /* > * If osd_finalize_request() was called but the request was not > * executed through the block layer, then we must release BIOs. > * TODO: Keep error code in or->async_error. Need to audit all > *�������code paths. > */ > if (unlikely(rq->bio)) > blk_end_request(rq, -ENOMEM, blk_rq_bytes(rq)); > else > blk_put_request(rq); > } Which isn't using it at all. It has a ten year old comment to pass on some error, but even then ORing two different error types together would no be very helpful. > > Bart.---end quoted text---
WARNING: multiple messages have this Message-ID (diff)
From: "hch@lst.de" <hch@lst.de> To: Bart Van Assche <Bart.VanAssche@sandisk.com> Cc: "hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>, "dm-devel@redhat.com" <dm-devel@redhat.com>, "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org> Subject: Re: [PATCH 02/15] scsi/osd: don't save block errors into req_results Date: Fri, 26 May 2017 07:15:40 +0200 [thread overview] Message-ID: <20170526051540.GA17709@lst.de> (raw) In-Reply-To: <1495641879.2823.7.camel@sandisk.com> On Wed, May 24, 2017 at 04:04:40PM +0000, Bart Van Assche wrote: > Are you sure that that code is not necessary? From osd_initiator.c: > > static void _put_request(struct request *rq) > { > /* > * If osd_finalize_request() was called but the request was not > * executed through the block layer, then we must release BIOs. > * TODO: Keep error code in or->async_error. Need to audit all > * code paths. > */ > if (unlikely(rq->bio)) > blk_end_request(rq, -ENOMEM, blk_rq_bytes(rq)); > else > blk_put_request(rq); > } Which isn't using it at all. It has a ten year old comment to pass on some error, but even then ORing two different error types together would no be very helpful. > > Bart.---end quoted text---
next prev parent reply other threads:[~2017-05-26 5:15 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-05-18 13:17 dedicated error codes for the block layer Christoph Hellwig 2017-05-18 13:17 ` [PATCH 01/15] nvme-lightnvm: use blk_execute_rq in nvme_nvm_submit_user_cmd Christoph Hellwig 2017-05-24 15:50 ` Bart Van Assche 2017-05-24 15:50 ` Bart Van Assche 2017-05-18 13:17 ` [PATCH 02/15] scsi/osd: don't save block errors into req_results Christoph Hellwig 2017-05-24 16:04 ` Bart Van Assche 2017-05-24 16:04 ` Bart Van Assche 2017-05-26 5:15 ` hch [this message] 2017-05-26 5:15 ` hch 2017-05-18 13:18 ` [PATCH 03/15] gfs2: remove the unused sd_log_error field Christoph Hellwig 2017-05-24 16:05 ` Bart Van Assche 2017-05-24 16:05 ` Bart Van Assche 2017-05-18 13:18 ` [PATCH 04/15] dm: fix REQ_RAHEAD handling Christoph Hellwig 2017-05-24 16:07 ` Bart Van Assche 2017-05-24 16:07 ` Bart Van Assche 2017-05-18 13:18 ` [PATCH 05/15] fs: remove the unused error argument to dio_end_io() Christoph Hellwig 2017-05-24 16:08 ` Bart Van Assche 2017-05-24 16:08 ` Bart Van Assche 2017-05-18 13:18 ` [PATCH 06/15] fs: simplify dio_bio_complete Christoph Hellwig 2017-05-24 16:08 ` Bart Van Assche 2017-05-24 16:08 ` Bart Van Assche 2017-05-18 13:18 ` [PATCH 07/15] block_dev: propagate bio_iov_iter_get_pages error in __blkdev_direct_IO Christoph Hellwig 2017-05-18 13:18 ` [PATCH 08/15] dm mpath: merge do_end_io_bio into multipath_end_io_bio Christoph Hellwig 2017-05-22 18:51 ` [dm-devel] " Martin Wilck 2017-05-26 5:18 ` Christoph Hellwig 2017-05-26 5:18 ` Christoph Hellwig 2017-05-18 13:18 ` [PATCH 09/15] dm: don't return errnos from ->map Christoph Hellwig 2017-05-18 13:18 ` [PATCH 10/15] dm: change ->end_io calling convention Christoph Hellwig 2017-05-18 13:18 ` [PATCH 11/15] fs-writeback: move wbc_to_write_flags out of line Christoph Hellwig 2017-05-18 13:18 ` [PATCH 12/15] block: merge blk_types.h into bio.h Christoph Hellwig 2017-05-18 14:25 ` Bart Van Assche 2017-05-18 14:25 ` Bart Van Assche 2017-05-18 14:25 ` Bart Van Assche 2017-05-19 8:22 ` hch 2017-05-18 13:18 ` [PATCH 13/15] block: introduce new block status code type Christoph Hellwig 2017-05-18 13:18 ` [PATCH 14/15] blk-mq: switch ->queue_rq return value to blk_status_t Christoph Hellwig 2017-05-18 13:18 ` [PATCH 15/15] block: switch bios " Christoph Hellwig 2017-05-18 14:55 ` dedicated error codes for the block layer David Sterba 2017-05-19 8:21 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170526051540.GA17709@lst.de \ --to=hch@lst.de \ --cc=Bart.VanAssche@sandisk.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-btrfs@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.