From: Eric Biggers <ebiggers3@gmail.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH 1/5] KEYS: sanitize add_key() and keyctl() key payloads
Date: Fri, 02 Jun 2017 17:24:17 +0000 [thread overview]
Message-ID: <20170602172417.GA2938@zzz> (raw)
In-Reply-To: <5744.1496417684@warthog.procyon.org.uk>
On Fri, Jun 02, 2017 at 04:34:44PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > error2:
> > + memzero_explicit(payload, plen);
>
> Isn't that wrong? payload can be NULL.
>
> David
If you're talking about memset(NULL, ..., 0) being undefined behavior, it's
completely insane but sure, I guess we should add the NULL check to be safe. It
would also mean there would be no requirement that "KEYS: fix dereferencing NULL
payload with nonzero length" be applied first so the second paragraph of the
commit message would be removed. I'll send a v2 of just this patch.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH 1/5] KEYS: sanitize add_key() and keyctl() key payloads
Date: Fri, 2 Jun 2017 10:24:17 -0700 [thread overview]
Message-ID: <20170602172417.GA2938@zzz> (raw)
In-Reply-To: <5744.1496417684@warthog.procyon.org.uk>
On Fri, Jun 02, 2017 at 04:34:44PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > error2:
> > + memzero_explicit(payload, plen);
>
> Isn't that wrong? payload can be NULL.
>
> David
If you're talking about memset(NULL, ..., 0) being undefined behavior, it's
completely insane but sure, I guess we should add the NULL check to be safe. It
would also mean there would be no requirement that "KEYS: fix dereferencing NULL
payload with nonzero length" be applied first so the second paragraph of the
commit message would be removed. I'll send a v2 of just this patch.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiggers3@gmail.com (Eric Biggers)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 1/5] KEYS: sanitize add_key() and keyctl() key payloads
Date: Fri, 2 Jun 2017 10:24:17 -0700 [thread overview]
Message-ID: <20170602172417.GA2938@zzz> (raw)
In-Reply-To: <5744.1496417684@warthog.procyon.org.uk>
On Fri, Jun 02, 2017 at 04:34:44PM +0100, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > error2:
> > + memzero_explicit(payload, plen);
>
> Isn't that wrong? payload can be NULL.
>
> David
If you're talking about memset(NULL, ..., 0) being undefined behavior, it's
completely insane but sure, I guess we should add the NULL check to be safe. It
would also mean there would be no requirement that "KEYS: fix dereferencing NULL
payload with nonzero length" be applied first so the second paragraph of the
commit message would be removed. I'll send a v2 of just this patch.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-02 17:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 8:30 [PATCH 0/5] KEYS: sanitize key payloads Eric Biggers
2017-04-21 8:30 ` Eric Biggers
2017-04-21 8:30 ` [PATCH 1/5] KEYS: sanitize add_key() and keyctl() " Eric Biggers
2017-04-21 8:30 ` Eric Biggers
2017-04-28 17:57 ` Eric Biggers
2017-04-28 17:57 ` Eric Biggers
2017-04-21 8:30 ` [PATCH 2/5] KEYS: user_defined: sanitize " Eric Biggers
2017-04-21 8:30 ` Eric Biggers
2017-04-21 8:30 ` [PATCH 3/5] KEYS: encrypted: sanitize all key material Eric Biggers
2017-04-21 8:30 ` Eric Biggers
2017-04-21 8:30 ` [PATCH 4/5] KEYS: trusted: " Eric Biggers
2017-04-21 8:30 ` Eric Biggers
2017-04-21 8:30 ` [PATCH 5/5] KEYS: sanitize key structs before freeing Eric Biggers
2017-04-21 8:30 ` Eric Biggers
2017-04-21 13:57 ` [PATCH 2/5] KEYS: user_defined: sanitize key payloads David Howells
2017-04-21 13:57 ` David Howells
2017-04-21 18:34 ` Eric Biggers
2017-04-21 18:34 ` Eric Biggers
2017-04-24 14:14 ` David Howells
2017-04-24 14:14 ` David Howells
2017-04-21 14:31 ` [PATCH 3/5] KEYS: encrypted: sanitize all key material David Howells
2017-04-21 14:31 ` David Howells
2017-04-21 18:24 ` Eric Biggers
2017-04-21 18:24 ` Eric Biggers
2017-04-24 14:14 ` David Howells
2017-04-24 14:14 ` David Howells
2017-04-27 15:09 ` [PATCH 0/5] KEYS: sanitize key payloads David Howells
2017-04-27 15:09 ` David Howells
2017-04-27 17:43 ` Eric Biggers
2017-04-27 17:43 ` Eric Biggers
2017-06-02 15:34 ` [PATCH 1/5] KEYS: sanitize add_key() and keyctl() " David Howells
2017-06-02 15:34 ` David Howells
2017-06-02 15:34 ` David Howells
2017-06-02 17:24 ` Eric Biggers [this message]
2017-06-02 17:24 ` Eric Biggers
2017-06-02 17:24 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602172417.GA2938@zzz \
--to=ebiggers3@gmail.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.