From: Brian Norris <briannorris@chromium.org> To: Jeffy Chen <jeffy.chen@rock-chips.com> Cc: linux-kernel@vger.kernel.org, broonie@kernel.org, dianders@chromium.org, heiko@sntech.de, linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property Date: Tue, 13 Jun 2017 10:33:46 -0700 [thread overview] Message-ID: <20170613173346.GB9026@google.com> (raw) In-Reply-To: <1497331543-8565-2-git-send-email-jeffy.chen@rock-chips.com> Hi Jeffy, On Tue, Jun 13, 2017 at 01:25:41PM +0800, Jeffy Chen wrote: > Support using "cs-gpios" property to specify cs gpios. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > 1/ request cs gpios in probe for better error handling > 2/ use gpiod* function > (suggested by Heiko Stuebner) > > 3/ split dt-binding changes to new patch > (suggested by Shawn Lin & Heiko Stuebner) > > --- > > Changes in v2: None > > drivers/spi/spi-rockchip.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > index bab9b13..ad8997b 100644 > --- a/drivers/spi/spi-rockchip.c > +++ b/drivers/spi/spi-rockchip.c > @@ -16,7 +16,7 @@ > #include <linux/clk.h> > #include <linux/dmaengine.h> > #include <linux/module.h> > -#include <linux/of.h> > +#include <linux/of_gpio.h> > #include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > #include <linux/spi/spi.h> > @@ -663,6 +663,27 @@ static bool rockchip_spi_can_dma(struct spi_master *master, > return (xfer->len > rs->fifo_len); > } > > +static int rockchip_spi_setup_cs_gpios(struct device *dev) > +{ > + struct device_node *np = dev->of_node; > + struct gpio_desc *cs_gpio; > + int i, nb; > + > + if (!np) > + return 0; > + > + nb = of_gpio_named_count(np, "cs-gpios"); > + for (i = 0; i < nb; i++) { > + /* We support both GPIO CS and HW CS */ > + cs_gpio = devm_gpiod_get_index_optional(dev, "cs", > + i, GPIOD_ASIS); > + if (IS_ERR(cs_gpio)) > + return PTR_ERR(cs_gpio); I'm a bit confused why you need this function at all. You aren't using the references that you're grabbing here, so essentially this is just error-checking. Are you doing anything here that isn't covered in of_spi_register_master()? > + } > + > + return 0; > +} > + > static int rockchip_spi_probe(struct platform_device *pdev) > { > int ret = 0; > @@ -749,6 +770,7 @@ static int rockchip_spi_probe(struct platform_device *pdev) > master->transfer_one = rockchip_spi_transfer_one; > master->max_transfer_size = rockchip_spi_max_transfer_size; > master->handle_err = rockchip_spi_handle_err; > + master->flags = SPI_MASTER_GPIO_SS; I'm curious, do you actually need to assert both the HW and GPIO CS? Brian > > rs->dma_tx.ch = dma_request_chan(rs->dev, "tx"); > if (IS_ERR(rs->dma_tx.ch)) { > @@ -783,6 +805,12 @@ static int rockchip_spi_probe(struct platform_device *pdev) > master->dma_rx = rs->dma_rx.ch; > } > > + ret = rockchip_spi_setup_cs_gpios(&pdev->dev); > + if (ret) { > + dev_err(&pdev->dev, "Failed to setup cs gpios\n"); > + goto err_free_dma_rx; > + } > + > ret = devm_spi_register_master(&pdev->dev, master); > if (ret) { > dev_err(&pdev->dev, "Failed to register master\n"); > -- > 2.1.4 > >
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property Date: Tue, 13 Jun 2017 10:33:46 -0700 [thread overview] Message-ID: <20170613173346.GB9026@google.com> (raw) In-Reply-To: <1497331543-8565-2-git-send-email-jeffy.chen@rock-chips.com> Hi Jeffy, On Tue, Jun 13, 2017 at 01:25:41PM +0800, Jeffy Chen wrote: > Support using "cs-gpios" property to specify cs gpios. > > Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com> > 1/ request cs gpios in probe for better error handling > 2/ use gpiod* function > (suggested by Heiko Stuebner) > > 3/ split dt-binding changes to new patch > (suggested by Shawn Lin & Heiko Stuebner) > > --- > > Changes in v2: None > > drivers/spi/spi-rockchip.c | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c > index bab9b13..ad8997b 100644 > --- a/drivers/spi/spi-rockchip.c > +++ b/drivers/spi/spi-rockchip.c > @@ -16,7 +16,7 @@ > #include <linux/clk.h> > #include <linux/dmaengine.h> > #include <linux/module.h> > -#include <linux/of.h> > +#include <linux/of_gpio.h> > #include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > #include <linux/spi/spi.h> > @@ -663,6 +663,27 @@ static bool rockchip_spi_can_dma(struct spi_master *master, > return (xfer->len > rs->fifo_len); > } > > +static int rockchip_spi_setup_cs_gpios(struct device *dev) > +{ > + struct device_node *np = dev->of_node; > + struct gpio_desc *cs_gpio; > + int i, nb; > + > + if (!np) > + return 0; > + > + nb = of_gpio_named_count(np, "cs-gpios"); > + for (i = 0; i < nb; i++) { > + /* We support both GPIO CS and HW CS */ > + cs_gpio = devm_gpiod_get_index_optional(dev, "cs", > + i, GPIOD_ASIS); > + if (IS_ERR(cs_gpio)) > + return PTR_ERR(cs_gpio); I'm a bit confused why you need this function at all. You aren't using the references that you're grabbing here, so essentially this is just error-checking. Are you doing anything here that isn't covered in of_spi_register_master()? > + } > + > + return 0; > +} > + > static int rockchip_spi_probe(struct platform_device *pdev) > { > int ret = 0; > @@ -749,6 +770,7 @@ static int rockchip_spi_probe(struct platform_device *pdev) > master->transfer_one = rockchip_spi_transfer_one; > master->max_transfer_size = rockchip_spi_max_transfer_size; > master->handle_err = rockchip_spi_handle_err; > + master->flags = SPI_MASTER_GPIO_SS; I'm curious, do you actually need to assert both the HW and GPIO CS? Brian > > rs->dma_tx.ch = dma_request_chan(rs->dev, "tx"); > if (IS_ERR(rs->dma_tx.ch)) { > @@ -783,6 +805,12 @@ static int rockchip_spi_probe(struct platform_device *pdev) > master->dma_rx = rs->dma_rx.ch; > } > > + ret = rockchip_spi_setup_cs_gpios(&pdev->dev); > + if (ret) { > + dev_err(&pdev->dev, "Failed to setup cs gpios\n"); > + goto err_free_dma_rx; > + } > + > ret = devm_spi_register_master(&pdev->dev, master); > if (ret) { > dev_err(&pdev->dev, "Failed to register master\n"); > -- > 2.1.4 > >
next prev parent reply other threads:[~2017-06-13 17:33 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-13 5:25 [PATCH v2 1/4] spi: rockchip: fix error handling when probe Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 5:25 ` [PATCH v2 2/4] spi: rockchip: add support for "cs-gpios" dts property Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 17:24 ` kbuild test robot 2017-06-13 17:24 ` kbuild test robot 2017-06-13 17:24 ` kbuild test robot 2017-06-13 17:33 ` Brian Norris [this message] 2017-06-13 17:33 ` Brian Norris 2017-06-14 1:27 ` jeffy 2017-06-14 1:27 ` jeffy 2017-06-14 1:27 ` jeffy 2017-06-13 5:25 ` [PATCH v2 3/4] dt-bindings: spi/rockchip: add "cs-gpios" optional property Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 5:25 ` [PATCH v2 4/4] arm64: dts: rockchip: use cs-gpios for cros_ec_spi Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 5:25 ` Jeffy Chen 2017-06-13 17:50 ` Brian Norris 2017-06-13 17:50 ` Brian Norris 2017-06-13 17:50 ` Brian Norris 2017-06-13 18:22 ` Mark Brown 2017-06-13 18:22 ` Mark Brown 2017-06-13 18:22 ` Mark Brown 2017-06-20 0:47 ` Brian Norris 2017-06-20 0:47 ` Brian Norris 2017-06-20 0:47 ` Brian Norris 2017-06-22 22:47 ` Doug Anderson 2017-06-22 22:47 ` Doug Anderson 2017-06-22 22:47 ` Doug Anderson 2017-06-23 3:51 ` jeffy 2017-06-23 3:51 ` jeffy 2017-06-23 4:26 ` Doug Anderson 2017-06-23 4:26 ` Doug Anderson [not found] ` <594D0723.7010108@rock-chips.com> [not found] ` <CAD=FV=XjW4a9mqH0UtUAmHkj-aAO75bpSXuyy__jBB7YC8PBVg@mail.gmail.com> 2017-06-26 3:26 ` jeffy 2017-06-26 3:26 ` jeffy 2017-06-26 3:26 ` jeffy 2017-06-26 3:27 ` jeffy 2017-06-26 3:27 ` jeffy 2017-06-26 3:27 ` jeffy 2017-06-13 17:29 ` [PATCH v2 1/4] spi: rockchip: fix error handling when probe Brian Norris 2017-06-13 17:29 ` Brian Norris
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170613173346.GB9026@google.com \ --to=briannorris@chromium.org \ --cc=broonie@kernel.org \ --cc=dianders@chromium.org \ --cc=heiko@sntech.de \ --cc=jeffy.chen@rock-chips.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.