From: Darren Hart <dvhart@infradead.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-mips@linux-mips.org, Rich Felker <dalias@libc.org>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Will Deacon <will.deacon@arm.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, tglx@linutronix.de,
Jonas Bonn <jonas@southpole.se>,
linux-s390@vger.kernel.org, linux-arch@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
mingo@redhat.com, Catalin Marinas <catalin.marinas@arm.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
linux-xtensa@linux-xtensa.org, Stefan Kristiansson <ste>
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Thu, 22 Jun 2017 03:53:37 +0000 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017 at 01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-mips@linux-mips.org, Rich Felker <dalias@libc.org>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Will Deacon <will.deacon@arm.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, tglx@linutronix.de,
Jonas Bonn <jonas@southpole.se>,
linux-s390@vger.kernel.org, linux-arch@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
mingo@redhat.com, Catalin Marinas <catalin.marinas@arm.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
linux-xtensa@linux-xtensa.org, Stefan Kristiansson <ste
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Wed, 21 Jun 2017 20:53:37 -0700 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017 at 01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, Richard Henderson <rth@twiddle.net>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Matt Turner <mattst88@gmail.com>,
Vineet Gupta <vgupta@synopsys.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Richard Kuo <rkuo@codeaurora.org>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Michal Simek <monstr@monstr.eu>,
Ralf Baechle <ralf@linux-mips.org>,
Jonas Bonn <jonas@southpole.se>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Stafford Horne <shorne@gmail.com>,
"James E.J. Bottomley" <jejb@parisc-linux.org>,
Helge Deller <deller@gmx.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
"H. Peter Anvin" <hpa@zytor.com>, Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
x86@kernel.org, linux-alpha@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@linux-mips.org, openrisc@lists.librecores.org,
linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Wed, 21 Jun 2017 20:53:37 -0700 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017 at 01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Darren Hart <dvhart@infradead.org>
To: Jiri Slaby <jslaby@suse.cz>
Cc: linux-mips@linux-mips.org, Rich Felker <dalias@libc.org>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
peterz@infradead.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Will Deacon <will.deacon@arm.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Paul Mackerras <paulus@samba.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, tglx@linutronix.de,
Jonas Bonn <jonas@southpole.se>,
linux-s390@vger.kernel.org, linux-arch@vger.kernel.org,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-hexagon@vger.kernel.org, Helge Deller <deller@gmx.de>,
x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
mingo@redhat.com, Catalin Marinas <catalin.marinas@arm.com>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
Fenghua Yu <fenghua.yu@intel.com>, Arnd Bergmann <arnd@arndb.de>,
linux-xtensa@linux-xtensa.org, Stefan Kristiansson <ste>
Subject: Re: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Wed, 21 Jun 2017 20:53:37 -0700 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017 at 01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: dvhart@infradead.org (Darren Hart)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Wed, 21 Jun 2017 20:53:37 -0700 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017@01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart at infradead.org>
--
Darren Hart
VMware Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: dvhart@infradead.org (Darren Hart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] futex: remove duplicated code and fix UB
Date: Wed, 21 Jun 2017 20:53:37 -0700 [thread overview]
Message-ID: <20170622035337.GF25900@fury> (raw)
In-Reply-To: <20170621115318.2781-1-jslaby@suse.cz>
On Wed, Jun 21, 2017 at 01:53:18PM +0200, Jiri Slaby wrote:
> There is code duplicated over all architecture's headers for
> futex_atomic_op_inuser. Namely op decoding, access_ok check for uaddr,
> and comparison of the result.
>
> Remove this duplication and leave up to the arches only the needed
> assembly which is now in arch_futex_atomic_op_inuser.
>
> This effectively distributes the Will Deacon's arm64 fix for undefined
> behaviour reported by UBSAN to all architectures. The fix was done in
> commit 5f16a046f8e1 (arm64: futex: Fix undefined behaviour with
> FUTEX_OP_OPARG_SHIFT usage). Look there for an example dump.
>
> Note that s390 removed access_ok check in d12a29703 ("s390/uaccess:
> remove pointless access_ok() checks") as access_ok there returns true.
> We introduce it back to the helper for the sake of simplicity (it gets
> optimized away anyway).
>
This required a minor manual merge for ARM on the tip of Linus' tree today. The
reduced duplication is a welcome improvement.
Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2017-06-22 3:53 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 13:07 [PATCH 1/1] futex: remove duplicated code Jiri Slaby
2017-05-15 13:07 ` [OpenRISC] " Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:07 ` Jiri Slaby
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` [OpenRISC] " Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-15 13:16 ` Will Deacon
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` [OpenRISC] " Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-17 8:01 ` Jiri Slaby
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` [OpenRISC] " Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-18 17:30 ` Will Deacon
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` [OpenRISC] " Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-22 21:11 ` Thomas Gleixner
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` [OpenRISC] " Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-25 14:28 ` Will Deacon
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` [OpenRISC] " Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-05-26 6:54 ` Thomas Gleixner
2017-06-21 11:53 ` [PATCH 1/1] futex: remove duplicated code and fix UB Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-21 11:53 ` Jiri Slaby
2017-06-22 3:53 ` Darren Hart [this message]
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-22 3:53 ` Darren Hart
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-23 7:51 ` Thomas Gleixner
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:02 ` Jiri Slaby
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-06-26 12:08 ` Will Deacon
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
2017-07-03 10:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170622035337.GF25900@fury \
--to=dvhart@infradead.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=jejb@parisc-linux.org \
--cc=jonas@southpole.se \
--cc=jslaby@suse.cz \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=mattst88@gmail.com \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.