From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] PCI: versatile: fix typo
Date: Tue, 27 Jun 2017 17:49:57 -0500 [thread overview]
Message-ID: <20170627224957.GG17844@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170621215323.3921382-3-arnd@arndb.de>
On Wed, Jun 21, 2017 at 11:53:01PM +0200, Arnd Bergmann wrote:
> There is no 'dev' variable in this function:
>
> drivers/pci/host/pci-versatile.c: In function 'versatile_pci_probe':
> drivers/pci/host/pci-versatile.c:131:38: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?
>
> This passes the device embedded in the platform_device instead.
>
> Fixes: 433d2671da1b ("PCI: versatile: Convert PCI scan API to pci_scan_root_bus_bridge()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Folded into Lorenzo's series on pci/enumeration, thanks!
> ---
> drivers/pci/host/pci-versatile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c
> index 3be25a9dd29a..f572c921cdd4 100644
> --- a/drivers/pci/host/pci-versatile.c
> +++ b/drivers/pci/host/pci-versatile.c
> @@ -128,7 +128,7 @@ static int versatile_pci_probe(struct platform_device *pdev)
> struct pci_host_bridge *bridge;
> LIST_HEAD(pci_res);
>
> - bridge = devm_pci_alloc_host_bridge(dev, 0);
> + bridge = devm_pci_alloc_host_bridge(&pdev->dev, 0);
> if (!bridge)
> return -ENOMEM;
>
> --
> 2.9.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Rob Herring <robh@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org,
Brian Norris <briannorris@chromium.org>,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] PCI: versatile: fix typo
Date: Tue, 27 Jun 2017 17:49:57 -0500 [thread overview]
Message-ID: <20170627224957.GG17844@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170621215323.3921382-3-arnd@arndb.de>
On Wed, Jun 21, 2017 at 11:53:01PM +0200, Arnd Bergmann wrote:
> There is no 'dev' variable in this function:
>
> drivers/pci/host/pci-versatile.c: In function 'versatile_pci_probe':
> drivers/pci/host/pci-versatile.c:131:38: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?
>
> This passes the device embedded in the platform_device instead.
>
> Fixes: 433d2671da1b ("PCI: versatile: Convert PCI scan API to pci_scan_root_bus_bridge()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Folded into Lorenzo's series on pci/enumeration, thanks!
> ---
> drivers/pci/host/pci-versatile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c
> index 3be25a9dd29a..f572c921cdd4 100644
> --- a/drivers/pci/host/pci-versatile.c
> +++ b/drivers/pci/host/pci-versatile.c
> @@ -128,7 +128,7 @@ static int versatile_pci_probe(struct platform_device *pdev)
> struct pci_host_bridge *bridge;
> LIST_HEAD(pci_res);
>
> - bridge = devm_pci_alloc_host_bridge(dev, 0);
> + bridge = devm_pci_alloc_host_bridge(&pdev->dev, 0);
> if (!bridge)
> return -ENOMEM;
>
> --
> 2.9.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] PCI: versatile: fix typo
Date: Tue, 27 Jun 2017 17:49:57 -0500 [thread overview]
Message-ID: <20170627224957.GG17844@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170621215323.3921382-3-arnd@arndb.de>
On Wed, Jun 21, 2017 at 11:53:01PM +0200, Arnd Bergmann wrote:
> There is no 'dev' variable in this function:
>
> drivers/pci/host/pci-versatile.c: In function 'versatile_pci_probe':
> drivers/pci/host/pci-versatile.c:131:38: error: 'dev' undeclared (first use in this function); did you mean 'pdev'?
>
> This passes the device embedded in the platform_device instead.
>
> Fixes: 433d2671da1b ("PCI: versatile: Convert PCI scan API to pci_scan_root_bus_bridge()")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Folded into Lorenzo's series on pci/enumeration, thanks!
> ---
> drivers/pci/host/pci-versatile.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-versatile.c b/drivers/pci/host/pci-versatile.c
> index 3be25a9dd29a..f572c921cdd4 100644
> --- a/drivers/pci/host/pci-versatile.c
> +++ b/drivers/pci/host/pci-versatile.c
> @@ -128,7 +128,7 @@ static int versatile_pci_probe(struct platform_device *pdev)
> struct pci_host_bridge *bridge;
> LIST_HEAD(pci_res);
>
> - bridge = devm_pci_alloc_host_bridge(dev, 0);
> + bridge = devm_pci_alloc_host_bridge(&pdev->dev, 0);
> if (!bridge)
> return -ENOMEM;
>
> --
> 2.9.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2017-06-27 22:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 21:52 [PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable warning Arnd Bergmann
2017-06-21 21:52 ` Arnd Bergmann
2017-06-21 21:52 ` Arnd Bergmann
2017-06-21 21:53 ` [PATCH 2/4] ARM/PCI: mv78xx0: pass pci_ops correctly again Arnd Bergmann
2017-06-21 21:53 ` Arnd Bergmann
2017-06-22 9:38 ` Lorenzo Pieralisi
2017-06-22 9:38 ` Lorenzo Pieralisi
2017-06-22 9:38 ` Lorenzo Pieralisi
2017-06-27 23:11 ` Bjorn Helgaas
2017-06-27 23:11 ` Bjorn Helgaas
2017-06-27 23:11 ` Bjorn Helgaas
2017-07-01 13:54 ` Lorenzo Pieralisi
2017-07-01 13:54 ` Lorenzo Pieralisi
2017-07-02 21:12 ` Bjorn Helgaas
2017-07-02 21:12 ` Bjorn Helgaas
2017-07-02 21:12 ` Bjorn Helgaas
2017-06-21 21:53 ` [PATCH 3/4] PCI: versatile: fix typo Arnd Bergmann
2017-06-21 21:53 ` Arnd Bergmann
2017-06-21 21:53 ` Arnd Bergmann
2017-06-27 22:49 ` Bjorn Helgaas [this message]
2017-06-27 22:49 ` Bjorn Helgaas
2017-06-27 22:49 ` Bjorn Helgaas
2017-06-21 21:53 ` [PATCH 4/4] PCI: versatile: fix another typo Arnd Bergmann
2017-06-21 21:53 ` Arnd Bergmann
2017-06-27 22:52 ` Bjorn Helgaas
2017-06-27 22:52 ` Bjorn Helgaas
2017-06-27 22:52 ` Bjorn Helgaas
2017-06-22 8:47 ` [PATCH 1/4] ARM/PCI: iop13xx: address uninitialized variable warning Lorenzo Pieralisi
2017-06-22 8:47 ` Lorenzo Pieralisi
2017-06-22 8:47 ` Lorenzo Pieralisi
2017-06-27 22:37 ` Bjorn Helgaas
2017-06-27 22:37 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170627224957.GG17844@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.