From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: make const array gamma_par_mask static
Date: Tue, 11 Jul 2017 19:45:16 +0200 [thread overview]
Message-ID: <20170711174516.GA13259@kroah.com> (raw)
In-Reply-To: <b46c6daf-a31d-3fc9-0319-172b2d14099a@canonical.com>
On Tue, Jul 11, 2017 at 06:39:59PM +0100, Colin Ian King wrote:
> On 11/07/17 18:30, Greg Kroah-Hartman wrote:
> > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Don't populate array gamma_par_mask on the stack but instead make it
> >> static. Makes the object code smaller by 148 bytes:
> >>
> >> Before:
> >> text data bss dec hex filename
> >> 2993 1104 0 4097 1001 drivers/staging/fbtft/fb_st7789v.o
> >>
> >> After:
> >> text data bss dec hex filename
> >> 2757 1192 0 3949 f6d drivers/staging/fbtft/fb_st7789v.o
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >> ---
> >> drivers/media/usb/gspca/xirlink_cit.c | 2 +-
> >> drivers/staging/fbtft/fb_st7789v.c | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Your subject doesn't match the patch :(
>
> Got distracted by the Trump Jnr tweet. Will resend.
Dude, the best thing is to just read:
https://whatthefuckjusthappenedtoday.com/
once a day, otherwise you will not get any work done ever again...
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: make const array gamma_par_mask static
Date: Tue, 11 Jul 2017 17:45:16 +0000 [thread overview]
Message-ID: <20170711174516.GA13259@kroah.com> (raw)
In-Reply-To: <b46c6daf-a31d-3fc9-0319-172b2d14099a@canonical.com>
On Tue, Jul 11, 2017 at 06:39:59PM +0100, Colin Ian King wrote:
> On 11/07/17 18:30, Greg Kroah-Hartman wrote:
> > On Tue, Jul 11, 2017 at 06:20:02PM +0100, Colin King wrote:
> >> From: Colin Ian King <colin.king@canonical.com>
> >>
> >> Don't populate array gamma_par_mask on the stack but instead make it
> >> static. Makes the object code smaller by 148 bytes:
> >>
> >> Before:
> >> text data bss dec hex filename
> >> 2993 1104 0 4097 1001 drivers/staging/fbtft/fb_st7789v.o
> >>
> >> After:
> >> text data bss dec hex filename
> >> 2757 1192 0 3949 f6d drivers/staging/fbtft/fb_st7789v.o
> >>
> >> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >> ---
> >> drivers/media/usb/gspca/xirlink_cit.c | 2 +-
> >> drivers/staging/fbtft/fb_st7789v.c | 2 +-
> >> 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Your subject doesn't match the patch :(
>
> Got distracted by the Trump Jnr tweet. Will resend.
Dude, the best thing is to just read:
https://whatthefuckjusthappenedtoday.com/
once a day, otherwise you will not get any work done ever again...
next prev parent reply other threads:[~2017-07-11 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 17:20 [PATCH] staging: fbtft: make const array gamma_par_mask static Colin King
2017-07-11 17:20 ` Colin King
2017-07-11 17:30 ` Greg Kroah-Hartman
2017-07-11 17:30 ` Greg Kroah-Hartman
2017-07-11 17:39 ` Colin Ian King
2017-07-11 17:39 ` Colin Ian King
2017-07-11 17:45 ` Greg Kroah-Hartman [this message]
2017-07-11 17:45 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170711174516.GA13259@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.king@canonical.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.