From: Arnd Bergmann <arnd@arndb.de> To: linux-kernel@vger.kernel.org, Bill Metzenthen <billm@melbpc.org.au>, x86@kernel.org Cc: Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, dri-devel@lists.freedesktop.org, linux-ide@vger.kernel.org, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, Tejun Heo <tj@kernel.org>, akpm@linux-foundation.org, Linus Torvalds <torvalds@linux-foundation.org>, Thomas Gleixner <tglx@linutronix.de>, Guenter Roeck <linux@roeck-us.net>, linux-media@vger.kernel.org Subject: [PATCH 04/14] x86: math-emu: avoid -Wint-in-bool-context warning Date: Fri, 14 Jul 2017 11:25:16 +0200 [thread overview] Message-ID: <20170714092540.1217397-5-arnd@arndb.de> (raw) In-Reply-To: <20170714092540.1217397-1-arnd@arndb.de> The setsign() macro gets called with an integer argument in a few places, leading to a harmless warning in gcc-7: arch/x86/math-emu/reg_add_sub.c: In function 'FPU_add': arch/x86/math-emu/reg_add_sub.c:80:48: error: ?: using integer constants in boolean context [-Werror=int-in-bool-context] This turns the integer into a boolean expression by comparing it to zero. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/x86/math-emu/fpu_emu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/math-emu/fpu_emu.h b/arch/x86/math-emu/fpu_emu.h index afbc4d805d66..c9c320dccca1 100644 --- a/arch/x86/math-emu/fpu_emu.h +++ b/arch/x86/math-emu/fpu_emu.h @@ -157,7 +157,7 @@ extern u_char const data_sizes_16[32]; #define signbyte(a) (((u_char *)(a))[9]) #define getsign(a) (signbyte(a) & 0x80) -#define setsign(a,b) { if (b) signbyte(a) |= 0x80; else signbyte(a) &= 0x7f; } +#define setsign(a,b) { if ((b) != 0) signbyte(a) |= 0x80; else signbyte(a) &= 0x7f; } #define copysign(a,b) { if (getsign(a)) signbyte(b) |= 0x80; \ else signbyte(b) &= 0x7f; } #define changesign(a) { signbyte(a) ^= 0x80; } -- 2.9.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de> To: linux-kernel@vger.kernel.org, Bill Metzenthen <billm@melbpc.org.au>, x86@kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, Tejun Heo <tj@kernel.org>, Guenter Roeck <linux@roeck-us.net>, linux-ide@vger.kernel.org, linux-media@vger.kernel.org, akpm@linux-foundation.org, dri-devel@lists.freedesktop.org, Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com> Subject: [PATCH 04/14] x86: math-emu: avoid -Wint-in-bool-context warning Date: Fri, 14 Jul 2017 11:25:16 +0200 [thread overview] Message-ID: <20170714092540.1217397-5-arnd@arndb.de> (raw) In-Reply-To: <20170714092540.1217397-1-arnd@arndb.de> The setsign() macro gets called with an integer argument in a few places, leading to a harmless warning in gcc-7: arch/x86/math-emu/reg_add_sub.c: In function 'FPU_add': arch/x86/math-emu/reg_add_sub.c:80:48: error: ?: using integer constants in boolean context [-Werror=int-in-bool-context] This turns the integer into a boolean expression by comparing it to zero. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/x86/math-emu/fpu_emu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/math-emu/fpu_emu.h b/arch/x86/math-emu/fpu_emu.h index afbc4d805d66..c9c320dccca1 100644 --- a/arch/x86/math-emu/fpu_emu.h +++ b/arch/x86/math-emu/fpu_emu.h @@ -157,7 +157,7 @@ extern u_char const data_sizes_16[32]; #define signbyte(a) (((u_char *)(a))[9]) #define getsign(a) (signbyte(a) & 0x80) -#define setsign(a,b) { if (b) signbyte(a) |= 0x80; else signbyte(a) &= 0x7f; } +#define setsign(a,b) { if ((b) != 0) signbyte(a) |= 0x80; else signbyte(a) &= 0x7f; } #define copysign(a,b) { if (getsign(a)) signbyte(b) |= 0x80; \ else signbyte(b) &= 0x7f; } #define changesign(a) { signbyte(a) ^= 0x80; } -- 2.9.0
next prev parent reply other threads:[~2017-07-14 9:25 UTC|newest] Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-07-14 9:25 [PATCH 00/14] gcc-7 warnings Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 9:25 ` [PATCH, RESEND 01/14] ide: avoid warning for timings calculation Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 9:25 ` [PATCH, RESEND 02/14] ata: avoid gcc-7 warning in ata_timing_quantize Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-15 10:56 ` Tejun Heo 2017-07-15 10:56 ` Tejun Heo 2017-07-14 9:25 ` [PATCH, RESEND 03/14] drm/vmwgfx: avoid gcc-7 parentheses warning Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 10:11 ` Jani Nikula 2017-07-14 10:11 ` Jani Nikula 2017-07-14 19:21 ` Linus Torvalds 2017-07-14 19:21 ` Linus Torvalds 2017-07-14 19:23 ` Linus Torvalds 2017-07-14 20:28 ` Arnd Bergmann 2017-07-17 13:15 ` Sinclair Yeh 2017-07-17 13:15 ` Sinclair Yeh 2017-07-14 9:25 ` Arnd Bergmann [this message] 2017-07-14 9:25 ` [PATCH 04/14] x86: math-emu: avoid -Wint-in-bool-context warning Arnd Bergmann 2017-07-14 9:25 ` [PATCH 05/14] isdn: isdnloop: suppress a gcc-7 warning Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 10:08 ` Joe Perches 2017-07-14 10:37 ` Arnd Bergmann 2017-07-15 4:20 ` Kevin Easton 2017-07-14 9:25 ` [PATCH 06/14] acpi: thermal: fix gcc-6/ccache warning Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 9:25 ` [PATCH 07/14] proc/kcore: hide a harmless warning Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 12:28 ` Ard Biesheuvel 2017-07-18 19:53 ` Arnd Bergmann 2017-07-18 19:53 ` Arnd Bergmann 2017-07-18 19:55 ` Ard Biesheuvel 2017-07-18 20:01 ` Arnd Bergmann 2017-07-18 20:07 ` Ard Biesheuvel 2017-07-18 20:21 ` Arnd Bergmann 2017-07-14 9:25 ` [PATCH 08/14] Input: adxl34x - fix gcc-7 -Wint-in-bool-context warning Arnd Bergmann 2017-07-14 9:25 ` Arnd Bergmann 2017-07-14 19:24 ` Linus Torvalds 2017-07-14 20:17 ` Arnd Bergmann 2017-07-14 21:40 ` Dmitry Torokhov 2017-07-14 9:30 ` [PATCH 09/14] SFI: fix tautological-compare warning Arnd Bergmann 2017-07-14 9:30 ` Arnd Bergmann 2017-07-14 9:31 ` [PATCH 10/14] staging:iio:resolver:ad2s1210 fix negative IIO_ANGL_VEL read Arnd Bergmann 2017-07-14 9:31 ` Arnd Bergmann 2017-07-15 11:42 ` Jonathan Cameron 2017-07-14 9:31 ` [PATCH 11/14] IB/uverbs: fix gcc-7 type warning Arnd Bergmann 2017-07-14 9:31 ` Arnd Bergmann 2017-07-14 9:46 ` Leon Romanovsky 2017-07-14 9:31 ` [PATCH 12/14] drm/nouveau/clk: fix gcc-7 -Wint-in-bool-context warning Arnd Bergmann 2017-07-14 9:31 ` Arnd Bergmann 2017-07-14 9:31 ` [PATCH 13/14] iopoll: avoid " Arnd Bergmann 2017-07-14 9:31 ` Arnd Bergmann 2017-07-14 9:55 ` Joe Perches 2017-07-14 10:22 ` Arnd Bergmann 2017-07-14 9:36 ` [PATCH 14/14] [media] fix warning on v4l2_subdev_call() result interpreted as bool Arnd Bergmann 2017-07-14 9:36 ` Arnd Bergmann 2017-07-14 9:36 ` Arnd Bergmann 2017-07-14 12:05 ` Dan Carpenter 2017-07-14 12:05 ` Dan Carpenter 2017-07-14 12:05 ` Dan Carpenter 2017-07-14 12:27 ` Arnd Bergmann 2017-07-14 12:27 ` Arnd Bergmann 2017-07-14 12:27 ` Arnd Bergmann 2017-07-14 12:55 ` Dan Carpenter 2017-07-14 12:55 ` Dan Carpenter 2017-07-14 12:55 ` Dan Carpenter 2017-07-14 13:09 ` Dan Carpenter 2017-07-14 13:09 ` Dan Carpenter 2017-07-14 13:09 ` Dan Carpenter 2017-07-14 19:32 ` Arnd Bergmann 2017-07-14 19:32 ` Arnd Bergmann 2017-07-14 19:32 ` Arnd Bergmann 2017-07-14 12:41 ` Dan Carpenter 2017-07-14 12:41 ` Dan Carpenter 2017-07-14 12:41 ` Dan Carpenter 2017-07-17 13:45 ` Hans Verkuil 2017-07-17 13:45 ` Hans Verkuil 2017-07-17 14:26 ` Arnd Bergmann 2017-07-17 14:26 ` Arnd Bergmann 2017-07-17 14:26 ` Arnd Bergmann 2017-07-17 14:28 ` Dan Carpenter 2017-07-17 14:28 ` Dan Carpenter 2017-07-17 14:28 ` Dan Carpenter 2017-07-17 14:32 ` Hans Verkuil 2017-07-17 14:32 ` Hans Verkuil 2017-07-17 14:32 ` Hans Verkuil 2017-07-17 14:35 ` Hans Verkuil 2017-07-17 14:35 ` Hans Verkuil 2017-07-17 14:35 ` Hans Verkuil 2017-07-17 21:23 ` Arnd Bergmann 2017-07-17 21:23 ` Arnd Bergmann 2017-07-17 21:23 ` Arnd Bergmann 2017-07-14 10:29 ` [PATCH 00/14] gcc-7 warnings Greg Kroah-Hartman 2017-07-14 10:29 ` Greg Kroah-Hartman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170714092540.1217397-5-arnd@arndb.de \ --to=arnd@arndb.de \ --cc=akpm@linux-foundation.org \ --cc=billm@melbpc.org.au \ --cc=dri-devel@lists.freedesktop.org \ --cc=gregkh@linuxfoundation.org \ --cc=hpa@zytor.com \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=tj@kernel.org \ --cc=torvalds@linux-foundation.org \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.