From: Jan Kara <jack@suse.cz>
To: Jeff Layton <jlayton@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
"J . Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>,
Bob Peterson <rpeterso@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>,
cluster-devel@redhat.com
Subject: Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait
Date: Thu, 27 Jul 2017 10:49:14 +0200 [thread overview]
Message-ID: <20170727084914.GC21100@quack2.suse.cz> (raw)
In-Reply-To: <20170726175538.13885-3-jlayton@kernel.org>
On Wed 26-07-17 13:55:36, Jeff Layton wrote:
> +int file_write_and_wait(struct file *file)
> +{
> + int err = 0, err2;
> + struct address_space *mapping = file->f_mapping;
> +
> + if ((!dax_mapping(mapping) && mapping->nrpages) ||
> + (dax_mapping(mapping) && mapping->nrexceptional)) {
> + err = filemap_fdatawrite(mapping);
> + /* See comment of filemap_write_and_wait() */
> + if (err != -EIO) {
> + loff_t i_size = i_size_read(mapping->host);
> +
> + if (i_size != 0)
> + __filemap_fdatawait_range(mapping, 0,
> + i_size - 1);
> + }
> + }
Err, what's the i_size check doing here? I'd just pass ~0 as the end of the
range and ignore i_size. It is much easier than trying to wrap your head
around possible races with file operations modifying i_size.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Jeff Layton <jlayton@kernel.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
"J . Bruce Fields" <bfields@fieldses.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Matthew Wilcox <willy@infradead.org>,
Bob Peterson <rpeterso@redhat.com>,
Steven Whitehouse <swhiteho@redhat.com>,
cluster-devel@redhat.com
Subject: Re: [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait
Date: Thu, 27 Jul 2017 10:49:14 +0200 [thread overview]
Message-ID: <20170727084914.GC21100@quack2.suse.cz> (raw)
In-Reply-To: <20170726175538.13885-3-jlayton@kernel.org>
On Wed 26-07-17 13:55:36, Jeff Layton wrote:
> +int file_write_and_wait(struct file *file)
> +{
> + int err = 0, err2;
> + struct address_space *mapping = file->f_mapping;
> +
> + if ((!dax_mapping(mapping) && mapping->nrpages) ||
> + (dax_mapping(mapping) && mapping->nrexceptional)) {
> + err = filemap_fdatawrite(mapping);
> + /* See comment of filemap_write_and_wait() */
> + if (err != -EIO) {
> + loff_t i_size = i_size_read(mapping->host);
> +
> + if (i_size != 0)
> + __filemap_fdatawait_range(mapping, 0,
> + i_size - 1);
> + }
> + }
Err, what's the i_size check doing here? I'd just pass ~0 as the end of the
range and ignore i_size. It is much easier than trying to wrap your head
around possible races with file operations modifying i_size.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait
Date: Thu, 27 Jul 2017 10:49:14 +0200 [thread overview]
Message-ID: <20170727084914.GC21100@quack2.suse.cz> (raw)
In-Reply-To: <20170726175538.13885-3-jlayton@kernel.org>
On Wed 26-07-17 13:55:36, Jeff Layton wrote:
> +int file_write_and_wait(struct file *file)
> +{
> + int err = 0, err2;
> + struct address_space *mapping = file->f_mapping;
> +
> + if ((!dax_mapping(mapping) && mapping->nrpages) ||
> + (dax_mapping(mapping) && mapping->nrexceptional)) {
> + err = filemap_fdatawrite(mapping);
> + /* See comment of filemap_write_and_wait() */
> + if (err != -EIO) {
> + loff_t i_size = i_size_read(mapping->host);
> +
> + if (i_size != 0)
> + __filemap_fdatawait_range(mapping, 0,
> + i_size - 1);
> + }
> + }
Err, what's the i_size check doing here? I'd just pass ~0 as the end of the
range and ignore i_size. It is much easier than trying to wrap your head
around possible races with file operations modifying i_size.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-07-27 8:49 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 17:55 [PATCH v2 0/4] mm/gfs2: extend file_* API, and convert gfs2 to errseq_t error reporting Jeff Layton
2017-07-26 17:55 ` [Cluster-devel] " Jeff Layton
2017-07-26 17:55 ` Jeff Layton
2017-07-26 17:55 ` [PATCH v2 1/4] mm: consolidate dax / non-dax checks for writeback Jeff Layton
2017-07-26 17:55 ` [Cluster-devel] " Jeff Layton
2017-07-26 17:55 ` Jeff Layton
2017-07-27 8:43 ` Jan Kara
2017-07-27 8:43 ` [Cluster-devel] " Jan Kara
2017-07-27 8:43 ` Jan Kara
2017-07-26 17:55 ` [PATCH v2 2/4] mm: add file_fdatawait_range and file_write_and_wait Jeff Layton
2017-07-26 17:55 ` [Cluster-devel] " Jeff Layton
2017-07-26 17:55 ` Jeff Layton
2017-07-26 19:13 ` Matthew Wilcox
2017-07-26 19:13 ` [Cluster-devel] " Matthew Wilcox
2017-07-26 19:13 ` Matthew Wilcox
2017-07-26 22:18 ` Jeff Layton
2017-07-26 22:18 ` [Cluster-devel] " Jeff Layton
2017-07-26 22:18 ` Jeff Layton
2017-07-26 22:18 ` Jeff Layton
2017-07-26 19:50 ` Bob Peterson
2017-07-26 19:50 ` [Cluster-devel] " Bob Peterson
2017-07-26 19:50 ` Bob Peterson
2017-07-27 8:49 ` Jan Kara [this message]
2017-07-27 8:49 ` [Cluster-devel] " Jan Kara
2017-07-27 8:49 ` Jan Kara
2017-07-27 12:48 ` Jeff Layton
2017-07-27 12:48 ` [Cluster-devel] " Jeff Layton
2017-07-27 12:48 ` Jeff Layton
2017-07-27 12:48 ` Jeff Layton
2017-07-31 11:27 ` Jeff Layton
2017-07-31 11:27 ` [Cluster-devel] " Jeff Layton
2017-07-31 11:27 ` Jeff Layton
2017-07-31 11:27 ` Jeff Layton
2017-07-31 11:32 ` Steven Whitehouse
2017-07-31 11:32 ` [Cluster-devel] " Steven Whitehouse
2017-07-31 11:32 ` Steven Whitehouse
2017-07-31 11:44 ` Jeff Layton
2017-07-31 11:44 ` [Cluster-devel] " Jeff Layton
2017-07-31 11:44 ` Jeff Layton
2017-07-31 11:44 ` Jeff Layton
2017-07-31 12:05 ` Steven Whitehouse
2017-07-31 12:05 ` [Cluster-devel] " Steven Whitehouse
2017-07-31 12:05 ` Steven Whitehouse
2017-07-31 12:22 ` Jeff Layton
2017-07-31 12:22 ` [Cluster-devel] " Jeff Layton
2017-07-31 12:22 ` Jeff Layton
2017-07-31 12:22 ` Jeff Layton
2017-07-31 12:25 ` Steven Whitehouse
2017-07-31 12:25 ` [Cluster-devel] " Steven Whitehouse
2017-07-31 12:25 ` Steven Whitehouse
2017-07-31 12:38 ` Bob Peterson
2017-07-31 12:38 ` [Cluster-devel] " Bob Peterson
2017-07-31 12:38 ` Bob Peterson
2017-07-31 12:07 ` Jan Kara
2017-07-31 12:07 ` [Cluster-devel] " Jan Kara
2017-07-31 12:07 ` Jan Kara
2017-07-31 13:00 ` Jeff Layton
2017-07-31 13:00 ` [Cluster-devel] " Jeff Layton
2017-07-31 13:00 ` Jeff Layton
2017-07-31 13:00 ` Jeff Layton
2017-07-31 13:32 ` Jan Kara
2017-07-31 13:32 ` [Cluster-devel] " Jan Kara
2017-07-31 13:32 ` Jan Kara
2017-07-31 16:49 ` [PATCH v3] " Jeff Layton
2017-07-31 16:49 ` [Cluster-devel] " Jeff Layton
2017-07-31 16:49 ` Jeff Layton
2017-08-01 9:52 ` Jan Kara
2017-08-01 9:52 ` [Cluster-devel] " Jan Kara
2017-08-01 9:52 ` Jan Kara
2017-07-26 17:55 ` [PATCH v2 3/4] fs: convert sync_file_range to use errseq_t based error-tracking Jeff Layton
2017-07-26 17:55 ` [Cluster-devel] " Jeff Layton
2017-07-26 17:55 ` Jeff Layton
2017-07-26 17:55 ` [PATCH v2 4/4] gfs2: convert to errseq_t based writeback error reporting for fsync Jeff Layton
2017-07-26 17:55 ` [Cluster-devel] " Jeff Layton
2017-07-26 17:55 ` Jeff Layton
2017-07-26 19:21 ` Matthew Wilcox
2017-07-26 19:21 ` [Cluster-devel] " Matthew Wilcox
2017-07-26 19:21 ` Matthew Wilcox
2017-07-26 22:22 ` Jeff Layton
2017-07-26 22:22 ` [Cluster-devel] " Jeff Layton
2017-07-26 22:22 ` Jeff Layton
2017-07-26 22:22 ` Jeff Layton
2017-07-27 12:47 ` Bob Peterson
2017-07-27 12:47 ` [Cluster-devel] " Bob Peterson
2017-07-27 12:47 ` Bob Peterson
2017-07-28 12:37 ` Steven Whitehouse
2017-07-28 12:37 ` [Cluster-devel] " Steven Whitehouse
2017-07-28 12:37 ` Steven Whitehouse
2017-07-28 12:47 ` Jeff Layton
2017-07-28 12:47 ` [Cluster-devel] " Jeff Layton
2017-07-28 12:47 ` Jeff Layton
2017-07-28 12:47 ` Jeff Layton
2017-07-28 12:54 ` Steven Whitehouse
2017-07-28 12:54 ` [Cluster-devel] " Steven Whitehouse
2017-07-28 12:54 ` Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727084914.GC21100@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=cluster-devel@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rpeterso@redhat.com \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.