From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: Tony Lindgren <tony@atomide.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update
Date: Thu, 27 Jul 2017 12:01:18 +0200 [thread overview]
Message-ID: <20170727100118.32p4fyfnkgnoz7op@earth> (raw)
In-Reply-To: <s5h7eywjzek.wl-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
Hi,
On Tue, Jul 25, 2017 at 05:42:59PM +0200, Takashi Iwai wrote:
> On Tue, 25 Jul 2017 17:10:25 +0200,
> Sebastian Reichel wrote:
> > Some codecs may need to use this from loadable modules. Without
> > this patch compilation for this kind of codec will fail with the
> > following error:
> >
> > ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko]
> > undefined!
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> If you do export the function, please make its comments prettier, so
> that it appears in kernel documentation properly as an API function.
>
> Also, in general, we use snd_ prefix for the exported stuff.
> You'd need to rename it accordingly, too.
>
> Last but not least, this is specific to ASoC, so use "ASoC" prefix to
> the subject line.
After fixing this locally I noticed, that I no longer need to call
soc_dpcm_runtime_update at all and it can remain private. So this
patch will be dropped in v4.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
linux-omap@vger.kernel.org
Subject: Re: [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update
Date: Thu, 27 Jul 2017 12:01:18 +0200 [thread overview]
Message-ID: <20170727100118.32p4fyfnkgnoz7op@earth> (raw)
In-Reply-To: <s5h7eywjzek.wl-tiwai@suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 1069 bytes --]
Hi,
On Tue, Jul 25, 2017 at 05:42:59PM +0200, Takashi Iwai wrote:
> On Tue, 25 Jul 2017 17:10:25 +0200,
> Sebastian Reichel wrote:
> > Some codecs may need to use this from loadable modules. Without
> > this patch compilation for this kind of codec will fail with the
> > following error:
> >
> > ERROR: "soc_dpcm_runtime_update" [sound/soc/codecs/snd-soc-cpcap.ko]
> > undefined!
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> If you do export the function, please make its comments prettier, so
> that it appears in kernel documentation properly as an API function.
>
> Also, in general, we use snd_ prefix for the exported stuff.
> You'd need to rename it accordingly, too.
>
> Last but not least, this is specific to ASoC, so use "ASoC" prefix to
> the subject line.
After fixing this locally I noticed, that I no longer need to call
soc_dpcm_runtime_update at all and it can remain private. So this
patch will be dropped in v4.
-- Sebastian
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-07-27 10:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 15:10 [PATCHv3 0/6] Motorola Droid 4 Audio Support Sebastian Reichel
2017-07-25 15:10 ` Sebastian Reichel
2017-07-25 15:10 ` [PATCHv3 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel
2017-07-25 15:42 ` Takashi Iwai
2017-07-25 15:42 ` Takashi Iwai
2017-07-26 11:38 ` Mark Brown
2017-07-27 10:01 ` Sebastian Reichel [this message]
2017-07-27 10:01 ` Sebastian Reichel
2017-07-25 15:10 ` [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2017-07-26 11:48 ` Mark Brown
2017-07-26 11:48 ` Mark Brown
2017-07-27 9:01 ` Sebastian Reichel
2017-07-27 9:01 ` Sebastian Reichel
2017-08-10 16:53 ` Tony Lindgren
2017-08-10 16:53 ` [PATCHv3 2/6] dt-bindings: sound: add motorola, cpcap-audio-codec Tony Lindgren
2017-08-18 11:47 ` [PATCHv3 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Mark Brown
2017-08-18 11:47 ` [PATCHv3 2/6] dt-bindings: sound: add motorola, cpcap-audio-codec Mark Brown
2017-07-25 15:10 ` [PATCHv3 3/6] ASoC: codec: cpcap: new codec Sebastian Reichel
2017-07-25 15:10 ` [PATCHv3 4/6] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
2017-07-25 15:10 ` [PATCHv3 5/6] ARM: dts: motorola-cpcap-mapphone: set initial mode for vaudio Sebastian Reichel
2017-07-25 15:10 ` [PATCHv3 6/6] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel
2017-07-27 12:01 ` [PATCHv3 0/6] Motorola Droid 4 Audio Support Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170727100118.32p4fyfnkgnoz7op@earth \
--to=sebastian.reichel@collabora.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.