From: Guenter Roeck <linux@roeck-us.net> To: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Jean Delvare <jdelvare@suse.com>, bhumirks@gmail.com, kernel-janitors@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [9/9, v2] hwmon: (scpi) constify thermal_zone_of_device_ops structures Date: Tue, 8 Aug 2017 19:02:00 -0700 [thread overview] Message-ID: <20170809020200.GA508@roeck-us.net> (raw) In-Reply-To: <1502204943-20075-10-git-send-email-Julia.Lawall@lip6.fr> On Tue, Aug 08, 2017 at 05:09:03PM +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to devm_thermal_zone_of_sensor_register, which is declared > as const. Thus the thermal_zone_of_device_ops structure itself can > be const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Applied to hwmon-next. Thanks, Guenter > --- > > v2: New patch > > drivers/hwmon/scpi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c > index a586480..7e49da5 100644 > --- a/drivers/hwmon/scpi-hwmon.c > +++ b/drivers/hwmon/scpi-hwmon.c > @@ -120,7 +120,7 @@ static int scpi_read_temp(void *dev, int *temp) > return sprintf(buf, "%s\n", sensor->info.name); > } > > -static struct thermal_zone_of_device_ops scpi_sensor_ops = { > +static const struct thermal_zone_of_device_ops scpi_sensor_ops = { > .get_temp = scpi_read_temp, > }; >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net> To: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Jean Delvare <jdelvare@suse.com>, bhumirks@gmail.com, kernel-janitors@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [9/9, v2] hwmon: (scpi) constify thermal_zone_of_device_ops structures Date: Wed, 09 Aug 2017 02:02:00 +0000 [thread overview] Message-ID: <20170809020200.GA508@roeck-us.net> (raw) In-Reply-To: <1502204943-20075-10-git-send-email-Julia.Lawall@lip6.fr> On Tue, Aug 08, 2017 at 05:09:03PM +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to devm_thermal_zone_of_sensor_register, which is declared > as const. Thus the thermal_zone_of_device_ops structure itself can > be const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Applied to hwmon-next. Thanks, Guenter > --- > > v2: New patch > > drivers/hwmon/scpi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c > index a586480..7e49da5 100644 > --- a/drivers/hwmon/scpi-hwmon.c > +++ b/drivers/hwmon/scpi-hwmon.c > @@ -120,7 +120,7 @@ static int scpi_read_temp(void *dev, int *temp) > return sprintf(buf, "%s\n", sensor->info.name); > } > > -static struct thermal_zone_of_device_ops scpi_sensor_ops = { > +static const struct thermal_zone_of_device_ops scpi_sensor_ops = { > .get_temp = scpi_read_temp, > }; >
next prev parent reply other threads:[~2017-08-09 2:02 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-08 15:08 [PATCH 0/9 v2] constify thermal_zone_of_device_ops structures Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` [PATCH 1/9 v2] thermal: hisilicon: " Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` [PATCH 2/9 v2] thermal: qoriq: " Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` [PATCH 3/9 v2] thermal: rcar_gen3_thermal: " Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` [PATCH 4/9 v2] thermal: zx2967: " Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` [PATCH 5/9 v2] thermal: exynos: " Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:08 ` Julia Lawall 2017-08-08 15:09 ` [PATCH 6/9 v2] Input: sun4i-ts - " Julia Lawall 2017-08-08 15:09 ` Julia Lawall 2017-08-08 15:09 ` Julia Lawall 2017-08-15 5:10 ` Dmitry Torokhov 2017-08-15 5:10 ` Dmitry Torokhov 2017-08-15 5:10 ` Dmitry Torokhov 2017-08-08 15:09 ` [PATCH 7/9 v2] thermal: bcm2835: " Julia Lawall 2017-08-08 15:09 ` Julia Lawall 2017-08-08 15:09 ` Julia Lawall 2017-08-08 19:58 ` Stefan Wahren 2017-08-08 19:58 ` Stefan Wahren 2017-08-08 19:58 ` Stefan Wahren 2017-08-08 15:09 ` [PATCH 8/9 v2] hwmon: (core) " Julia Lawall 2017-08-08 15:09 ` Julia Lawall 2017-08-09 2:01 ` [8/9, " Guenter Roeck 2017-08-09 2:01 ` Guenter Roeck 2017-08-08 15:09 ` [PATCH 9/9 v2] hwmon: (scpi) " Julia Lawall 2017-08-08 15:09 ` Julia Lawall 2017-08-09 2:02 ` Guenter Roeck [this message] 2017-08-09 2:02 ` [9/9, " Guenter Roeck 2017-08-11 3:36 ` [PATCH 0/9 v2] " Zhang Rui 2017-08-11 3:36 ` Zhang Rui 2017-08-11 3:36 ` Zhang Rui 2017-08-11 5:17 ` Julia Lawall 2017-08-11 5:17 ` Julia Lawall 2017-08-11 5:17 ` Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170809020200.GA508@roeck-us.net \ --to=linux@roeck-us.net \ --cc=Julia.Lawall@lip6.fr \ --cc=bhumirks@gmail.com \ --cc=jdelvare@suse.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.