From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> To: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> Cc: ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org, linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, hauke.mehrtens-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, kishon-l0cyMroinI0@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org Subject: Re: [PATCH v9 10/16] reset: Add a reset controller driver for the Lantiq XWAY based SoCs Date: Thu, 17 Aug 2017 10:10:12 -0500 [thread overview] Message-ID: <20170817151012.7hbnsgwv477mjnqx@rob-hp-laptop> (raw) In-Reply-To: <20170808225247.32266-11-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> On Wed, Aug 09, 2017 at 12:52:41AM +0200, Hauke Mehrtens wrote: > From: Martin Blumenstingl <martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> > > The reset controllers (on xRX200 and newer SoCs have two of them) are > provided by the RCU module. This was initially implemented as a simple > reset controller. However, the RCU module provides more functionality > (ethernet GPHYs, USB PHY, etc.), which makes it a MFD device. > The old reset controller driver implementation from > arch/mips/lantiq/xway/reset.c did not honor this fact. > > For some devices the request and the status bits are different. > > Signed-off-by: Hauke Mehrtens <hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> > Cc: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> > Reviewed-by: Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > --- > .../devicetree/bindings/reset/lantiq,reset.txt | 30 +++ > drivers/reset/Kconfig | 6 + > drivers/reset/Makefile | 1 + > drivers/reset/reset-lantiq.c | 212 +++++++++++++++++++++ > 4 files changed, 249 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/lantiq,reset.txt > create mode 100644 drivers/reset/reset-lantiq.c > > diff --git a/Documentation/devicetree/bindings/reset/lantiq,reset.txt b/Documentation/devicetree/bindings/reset/lantiq,reset.txt > new file mode 100644 > index 000000000000..c1c48aa099b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/lantiq,reset.txt > @@ -0,0 +1,30 @@ > +Lantiq XWAY SoC RCU reset controller binding > +============================================ > + > +This binding describes a reset-controller found on the RCU module on Lantiq > +XWAY SoCs. > + > +This driver has to be a sub node of the Lantiq RCU block. s/driver/node/ > + > +------------------------------------------------------------------------------- > +Required properties: > +- compatible : Should be one of > + "lantiq,danube-reset" > + "lantiq,xrx200-reset" > +- reg : Defines the following sets of registers in the parent > + syscon device > + - Offset of the reset set register > + - Offset of the reset status register > +- #reset-cells : Specifies the number of cells needed to encode the > + reset line, should be 2. > + The first cell takes the reset set bit and the > + second cell takes the status bit. > + > +------------------------------------------------------------------------------- > +Example for the reset-controllers on the xRX200 SoCs: > + reset0: reset-controller@0 { Should be: reset-controller@10 With those fixed, Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> > + compatible = "lantiq,xrx200-reset"; > + reg <0x10 0x04>, <0x14 0x04>; > + > + #reset-cells = <2>; > + }; -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Hauke Mehrtens <hauke@hauke-m.de> Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-mtd@lists.infradead.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, martin.blumenstingl@googlemail.com, john@phrozen.org, linux-spi@vger.kernel.org, hauke.mehrtens@intel.com, andy.shevchenko@gmail.com, p.zabel@pengutronix.de, kishon@ti.com, mark.rutland@arm.com Subject: Re: [PATCH v9 10/16] reset: Add a reset controller driver for the Lantiq XWAY based SoCs Date: Thu, 17 Aug 2017 10:10:12 -0500 [thread overview] Message-ID: <20170817151012.7hbnsgwv477mjnqx@rob-hp-laptop> (raw) In-Reply-To: <20170808225247.32266-11-hauke@hauke-m.de> On Wed, Aug 09, 2017 at 12:52:41AM +0200, Hauke Mehrtens wrote: > From: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > The reset controllers (on xRX200 and newer SoCs have two of them) are > provided by the RCU module. This was initially implemented as a simple > reset controller. However, the RCU module provides more functionality > (ethernet GPHYs, USB PHY, etc.), which makes it a MFD device. > The old reset controller driver implementation from > arch/mips/lantiq/xway/reset.c did not honor this fact. > > For some devices the request and the status bits are different. > > Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > .../devicetree/bindings/reset/lantiq,reset.txt | 30 +++ > drivers/reset/Kconfig | 6 + > drivers/reset/Makefile | 1 + > drivers/reset/reset-lantiq.c | 212 +++++++++++++++++++++ > 4 files changed, 249 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/lantiq,reset.txt > create mode 100644 drivers/reset/reset-lantiq.c > > diff --git a/Documentation/devicetree/bindings/reset/lantiq,reset.txt b/Documentation/devicetree/bindings/reset/lantiq,reset.txt > new file mode 100644 > index 000000000000..c1c48aa099b3 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/lantiq,reset.txt > @@ -0,0 +1,30 @@ > +Lantiq XWAY SoC RCU reset controller binding > +============================================ > + > +This binding describes a reset-controller found on the RCU module on Lantiq > +XWAY SoCs. > + > +This driver has to be a sub node of the Lantiq RCU block. s/driver/node/ > + > +------------------------------------------------------------------------------- > +Required properties: > +- compatible : Should be one of > + "lantiq,danube-reset" > + "lantiq,xrx200-reset" > +- reg : Defines the following sets of registers in the parent > + syscon device > + - Offset of the reset set register > + - Offset of the reset status register > +- #reset-cells : Specifies the number of cells needed to encode the > + reset line, should be 2. > + The first cell takes the reset set bit and the > + second cell takes the status bit. > + > +------------------------------------------------------------------------------- > +Example for the reset-controllers on the xRX200 SoCs: > + reset0: reset-controller@0 { Should be: reset-controller@10 With those fixed, Acked-by: Rob Herring <robh@kernel.org> > + compatible = "lantiq,xrx200-reset"; > + reg <0x10 0x04>, <0x14 0x04>; > + > + #reset-cells = <2>; > + };
next prev parent reply other threads:[~2017-08-17 15:10 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-08 22:52 [PATCH v9 00/16] MIPS: lantiq: handle RCU register by separate drivers Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens [not found] ` <20170808225247.32266-1-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> 2017-08-08 22:52 ` [PATCH v9 01/16] MIPS: lantiq: Use of_platform_default_populate instead of __dt_register_buses Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 02/16] mtd: lantiq-flash: drop check of boot select Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 03/16] mtd: spi-falcon: " Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens [not found] ` <20170808225247.32266-4-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> 2017-08-09 11:44 ` Mark Brown 2017-08-09 11:44 ` Mark Brown [not found] ` <20170809114421.oo2bunardgw3p4tk-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> 2017-08-09 14:02 ` Langer, Thomas 2017-08-09 14:02 ` Langer, Thomas 2017-08-09 14:02 ` Langer, Thomas [not found] ` <0DAF21CFE1B20740AE23D6AF6E54843F1EA0A385-kPTMFJFq+rF9qrmMLTLiibfspsVTdybXVpNB7YpNyf8@public.gmane.org> 2017-08-10 15:05 ` Mark Brown 2017-08-10 15:05 ` Mark Brown 2017-08-10 15:05 ` Mark Brown 2017-08-08 22:52 ` [PATCH v9 04/16] watchdog: lantiq: access boot cause register through regmap Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 05/16] watchdog: lantiq: add device tree binding documentation Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens [not found] ` <20170808225247.32266-6-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> 2017-08-17 15:09 ` Rob Herring 2017-08-17 15:09 ` Rob Herring 2017-08-08 22:52 ` [PATCH v9 06/16] MIPS: lantiq: Enable MFD_SYSCON to be able to use it for the RCU MFD Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 07/16] Documentation: DT: MIPS: lantiq: Add docs for the RCU bindings Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 08/16] MIPS: lantiq: Convert the fpi bus driver to a platform_driver Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 09/16] MIPS: lantiq: remove ltq_reset_cause() and ltq_boot_select() Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 10/16] reset: Add a reset controller driver for the Lantiq XWAY based SoCs Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens [not found] ` <20170808225247.32266-11-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> 2017-08-17 15:10 ` Rob Herring [this message] 2017-08-17 15:10 ` Rob Herring 2017-08-08 22:52 ` [PATCH v9 11/16] MIPS: lantiq: remove old reset controller implementation Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 12/16] MIPS: lantiq: Add a GPHY driver which uses the RCU syscon-mfd Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 13/16] MIPS: lantiq: remove old GPHY loader code Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 14/16] phy: Add an USB PHY driver for the Lantiq SoCs using the RCU module Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-11 10:23 ` Kishon Vijay Abraham I 2017-08-11 10:23 ` Kishon Vijay Abraham I [not found] ` <20170808225247.32266-15-hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org> 2017-08-17 15:10 ` Rob Herring 2017-08-17 15:10 ` Rob Herring 2017-08-08 22:52 ` [PATCH v9 15/16] MIPS: lantiq: remove old USB PHY initialisation Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens 2017-08-08 22:52 ` [PATCH v9 16/16] MIPS: lantiq: Remove the arch/mips/lantiq/xway/reset.c implementation Hauke Mehrtens 2017-08-08 22:52 ` Hauke Mehrtens
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170817151012.7hbnsgwv477mjnqx@rob-hp-laptop \ --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \ --cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=hauke-5/S+JYg5SzeELgA04lAiVw@public.gmane.org \ --cc=hauke.mehrtens-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=john-Pj+rj9U5foFAfugRpC6u6w@public.gmane.org \ --cc=kishon-l0cyMroinI0@public.gmane.org \ --cc=linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \ --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \ --cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ --cc=ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.