From: Roger Pau Monn303251 <roger.pau@citrix.com>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 12/12] xen-blkfront: Avoid that gcc 7 warns about fall-through when building with W=1
Date: Fri, 18 Aug 2017 09:54:01 +0100 [thread overview]
Message-ID: <20170818085401.5fokhfurydomfxow@MacBook-Pro-de-Roger.local> (raw)
In-Reply-To: <20170817232311.25948-13-bart.vanassche@wdc.com>
On Thu, Aug 17, 2017 at 04:23:11PM -0700, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Cc: Roger Pau Monn303251 <roger.pau@citrix.com>
> Cc: xen-devel@lists.xenproject.org
> ---
> drivers/block/xen-blkfront.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 98e34e4c62b8..270019e3e5d8 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -2456,7 +2456,7 @@ static void blkback_changed(struct xenbus_device *dev,
> case XenbusStateClosed:
> if (dev->state == XenbusStateClosed)
> break;
> - /* Missed the backend's Closing state -- fallthrough */
> + /* fall through */
This is losing information present in the original comment. Would
splitting the comment into two make gcc happy?
Roger.
next prev parent reply other threads:[~2017-08-18 8:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 23:22 [PATCH 00/12] Twelve small block layer patches Bart Van Assche
2017-08-17 23:23 ` [PATCH 01/12] block: Fix two comments that refer to .queue_rq() return values Bart Van Assche
2017-08-18 7:31 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 02/12] block: Unexport blk_queue_end_tag() Bart Van Assche
2017-08-18 7:31 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 03/12] blk-mq: Explain when 'active_queues' is decremented Bart Van Assche
2017-08-18 7:32 ` Hannes Reinecke
2017-08-18 14:34 ` Jens Axboe
2017-08-17 23:23 ` [PATCH 04/12] blk-mq: Make blk_mq_reinit_tagset() calls easier to read Bart Van Assche
2017-08-18 7:32 ` Hannes Reinecke
2017-08-20 6:15 ` Sagi Grimberg
2017-08-17 23:23 ` [PATCH 05/12] blk-mq-debugfs: Declare a local symbol static Bart Van Assche
2017-08-18 6:52 ` Omar Sandoval
2017-08-18 7:33 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 06/12] blk-mq-debugfs: Generate name-to-text translation tables Bart Van Assche
2017-08-18 7:38 ` Hannes Reinecke
2017-08-18 14:35 ` Jens Axboe
2017-08-18 15:11 ` Bart Van Assche
2017-08-18 15:36 ` Jens Axboe
2017-08-17 23:23 ` [PATCH 07/12] genhd: Annotate all part and part_tbl pointer dereferences Bart Van Assche
2017-08-18 7:39 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() Bart Van Assche
2017-08-18 5:00 ` David Miller
2017-08-18 7:39 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 09/12] virtio_blk: " Bart Van Assche
2017-08-17 23:23 ` Bart Van Assche
2017-08-18 7:39 ` Hannes Reinecke
2017-08-18 7:39 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 10/12] xen-blkback: Fix indentation Bart Van Assche
2017-08-17 23:23 ` Bart Van Assche
2017-08-18 7:40 ` Hannes Reinecke
2017-08-18 7:40 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1 Bart Van Assche
2017-08-17 23:23 ` Bart Van Assche
2017-08-18 7:40 ` Hannes Reinecke
2017-08-18 7:40 ` Hannes Reinecke
2017-08-17 23:23 ` [PATCH 12/12] xen-blkfront: " Bart Van Assche
2017-08-17 23:23 ` Bart Van Assche
2017-08-18 8:54 ` Roger Pau Monn303251
2017-08-18 8:54 ` Roger Pau Monn303251 [this message]
2017-08-18 11:46 ` [Xen-devel] " Anthony PERARD
2017-08-18 11:46 ` Anthony PERARD
2017-08-18 11:57 ` [Xen-devel] " Roger Pau Monn303251
2017-08-18 11:57 ` Roger Pau Monn303251
2017-08-18 14:37 ` [PATCH 00/12] Twelve small block layer patches Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818085401.5fokhfurydomfxow@MacBook-Pro-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=hch@lst.de \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.