From: Bart Van Assche <bart.vanassche@wdc.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Bart Van Assche <bart.vanassche@wdc.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Roger Pau Monn303251 <roger.pau@citrix.com>, xen-devel@lists.xenproject.org Subject: [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1 Date: Thu, 17 Aug 2017 16:23:10 -0700 [thread overview] Message-ID: <20170817232311.25948-12-bart.vanassche@wdc.com> (raw) In-Reply-To: <20170817232311.25948-1-bart.vanassche@wdc.com> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Roger Pau Monn303251 <roger.pau@citrix.com> Cc: xen-devel@lists.xenproject.org --- drivers/block/xen-blkback/blkback.c | 1 + drivers/block/xen-blkback/xenbus.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 68157a84bf4d..5f3a813e7ae0 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -1251,6 +1251,7 @@ static int dispatch_rw_block_io(struct xen_blkif_ring *ring, break; case BLKIF_OP_WRITE_BARRIER: drain = true; + /* fall through */ case BLKIF_OP_FLUSH_DISKCACHE: ring->st_f_req++; operation = REQ_OP_WRITE; diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 792da683e70d..88eaea6475d7 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -810,7 +810,8 @@ static void frontend_changed(struct xenbus_device *dev, xenbus_switch_state(dev, XenbusStateClosed); if (xenbus_dev_is_online(dev)) break; - /* fall through if not online */ + /* fall through */ + /* if not online */ case XenbusStateUnknown: /* implies xen_blkif_disconnect() via xen_blkbk_remove() */ device_unregister(&dev->dev); -- 2.14.0
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@wdc.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Bart Van Assche <bart.vanassche@wdc.com>, xen-devel@lists.xenproject.org, Christoph Hellwig <hch@lst.de>, Roger Pau Monn303251 <roger.pau@citrix.com> Subject: [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1 Date: Thu, 17 Aug 2017 16:23:10 -0700 [thread overview] Message-ID: <20170817232311.25948-12-bart.vanassche@wdc.com> (raw) In-Reply-To: <20170817232311.25948-1-bart.vanassche@wdc.com> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Roger Pau Monn303251 <roger.pau@citrix.com> Cc: xen-devel@lists.xenproject.org --- drivers/block/xen-blkback/blkback.c | 1 + drivers/block/xen-blkback/xenbus.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index 68157a84bf4d..5f3a813e7ae0 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -1251,6 +1251,7 @@ static int dispatch_rw_block_io(struct xen_blkif_ring *ring, break; case BLKIF_OP_WRITE_BARRIER: drain = true; + /* fall through */ case BLKIF_OP_FLUSH_DISKCACHE: ring->st_f_req++; operation = REQ_OP_WRITE; diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 792da683e70d..88eaea6475d7 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -810,7 +810,8 @@ static void frontend_changed(struct xenbus_device *dev, xenbus_switch_state(dev, XenbusStateClosed); if (xenbus_dev_is_online(dev)) break; - /* fall through if not online */ + /* fall through */ + /* if not online */ case XenbusStateUnknown: /* implies xen_blkif_disconnect() via xen_blkbk_remove() */ device_unregister(&dev->dev); -- 2.14.0 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-08-17 23:23 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-08-17 23:22 [PATCH 00/12] Twelve small block layer patches Bart Van Assche 2017-08-17 23:23 ` [PATCH 01/12] block: Fix two comments that refer to .queue_rq() return values Bart Van Assche 2017-08-18 7:31 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 02/12] block: Unexport blk_queue_end_tag() Bart Van Assche 2017-08-18 7:31 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 03/12] blk-mq: Explain when 'active_queues' is decremented Bart Van Assche 2017-08-18 7:32 ` Hannes Reinecke 2017-08-18 14:34 ` Jens Axboe 2017-08-17 23:23 ` [PATCH 04/12] blk-mq: Make blk_mq_reinit_tagset() calls easier to read Bart Van Assche 2017-08-18 7:32 ` Hannes Reinecke 2017-08-20 6:15 ` Sagi Grimberg 2017-08-17 23:23 ` [PATCH 05/12] blk-mq-debugfs: Declare a local symbol static Bart Van Assche 2017-08-18 6:52 ` Omar Sandoval 2017-08-18 7:33 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 06/12] blk-mq-debugfs: Generate name-to-text translation tables Bart Van Assche 2017-08-18 7:38 ` Hannes Reinecke 2017-08-18 14:35 ` Jens Axboe 2017-08-18 15:11 ` Bart Van Assche 2017-08-18 15:36 ` Jens Axboe 2017-08-17 23:23 ` [PATCH 07/12] genhd: Annotate all part and part_tbl pointer dereferences Bart Van Assche 2017-08-18 7:39 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 08/12] ide-floppy: Use blk_rq_is_scsi() Bart Van Assche 2017-08-18 5:00 ` David Miller 2017-08-18 7:39 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 09/12] virtio_blk: " Bart Van Assche 2017-08-17 23:23 ` Bart Van Assche 2017-08-18 7:39 ` Hannes Reinecke 2017-08-18 7:39 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 10/12] xen-blkback: Fix indentation Bart Van Assche 2017-08-17 23:23 ` Bart Van Assche 2017-08-18 7:40 ` Hannes Reinecke 2017-08-18 7:40 ` Hannes Reinecke 2017-08-17 23:23 ` Bart Van Assche [this message] 2017-08-17 23:23 ` [PATCH 11/12] xen-blkback: Avoid that gcc 7 warns about fall-through when building with W=1 Bart Van Assche 2017-08-18 7:40 ` Hannes Reinecke 2017-08-18 7:40 ` Hannes Reinecke 2017-08-17 23:23 ` [PATCH 12/12] xen-blkfront: " Bart Van Assche 2017-08-17 23:23 ` Bart Van Assche 2017-08-18 8:54 ` Roger Pau Monn303251 2017-08-18 8:54 ` Roger Pau Monn303251 2017-08-18 11:46 ` [Xen-devel] " Anthony PERARD 2017-08-18 11:46 ` Anthony PERARD 2017-08-18 11:57 ` [Xen-devel] " Roger Pau Monn303251 2017-08-18 11:57 ` Roger Pau Monn303251 2017-08-18 14:37 ` [PATCH 00/12] Twelve small block layer patches Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170817232311.25948-12-bart.vanassche@wdc.com \ --to=bart.vanassche@wdc.com \ --cc=axboe@kernel.dk \ --cc=hch@lst.de \ --cc=konrad.wilk@oracle.com \ --cc=linux-block@vger.kernel.org \ --cc=roger.pau@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.