From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
<patches@opensource.wolfsonmicro.com>,
<alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support
Date: Mon, 4 Sep 2017 11:18:49 +0100 [thread overview]
Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain> (raw)
In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr>
On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v4:
> - added #ifdef spotted by Charles
> ---
> snd_soc_codec_init_regmap(codec, regmap);
> @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
> struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
>
> snd_soc_codec_exit_regmap(codec);
> - snd_soc_free_ac97_codec(wm9712->ac97);
> + if (!wm9712->mfd_pdata)
> + snd_soc_free_ac97_codec(wm9712->ac97);
This bit is still missing the ifdef it has in the preceeding
patch.
Otherwise looks good to me.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
patches@opensource.wolfsonmicro.com,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support
Date: Mon, 4 Sep 2017 11:18:49 +0100 [thread overview]
Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain> (raw)
In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr>
On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v4:
> - added #ifdef spotted by Charles
> ---
> snd_soc_codec_init_regmap(codec, regmap);
> @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
> struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
>
> snd_soc_codec_exit_regmap(codec);
> - snd_soc_free_ac97_codec(wm9712->ac97);
> + if (!wm9712->mfd_pdata)
> + snd_soc_free_ac97_codec(wm9712->ac97);
This bit is still missing the ifdef it has in the preceeding
patch.
Otherwise looks good to me.
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: ckeepax@opensource.cirrus.com (Charles Keepax)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support
Date: Mon, 4 Sep 2017 11:18:49 +0100 [thread overview]
Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain> (raw)
In-Reply-To: <20170902195414.3699-10-robert.jarzmik@free.fr>
On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> ---
> Since v4:
> - added #ifdef spotted by Charles
> ---
> snd_soc_codec_init_regmap(codec, regmap);
> @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
> struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
>
> snd_soc_codec_exit_regmap(codec);
> - snd_soc_free_ac97_codec(wm9712->ac97);
> + if (!wm9712->mfd_pdata)
> + snd_soc_free_ac97_codec(wm9712->ac97);
This bit is still missing the ifdef it has in the preceeding
patch.
Otherwise looks good to me.
Thanks,
Charles
next prev parent reply other threads:[~2017-09-04 10:21 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-02 19:54 [PATCH v6 00/12] AC97 device/driver model revamp Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 01/12] ALSA: ac97: split out the generic ac97 registers Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-03 7:15 ` [alsa-devel] " Takashi Iwai
2017-09-03 7:15 ` Takashi Iwai
2017-09-02 19:54 ` [PATCH v6 02/12] ALSA: ac97: add an ac97 bus Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-03 7:19 ` [alsa-devel] " Takashi Iwai
2017-09-03 7:19 ` Takashi Iwai
2017-09-02 19:54 ` [PATCH v6 03/12] ASoC: add new ac97 bus support Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 04/12] ASoC: arm: make pxa2xx-ac97-lib ac97 codec agnostic Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 05/12] Input: wm97xx: split out touchscreen registering Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 06/12] mfd: wm97xx-core: core support for wm97xx Codec Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-05 8:04 ` Lee Jones
2017-09-05 8:04 ` Lee Jones
2017-09-02 19:54 ` [PATCH v6 07/12] Input: wm97xx: add new AC97 bus support Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 08/12] ASoC: wm9713: add ac97 new " Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 09/12] ASoC: wm9712: " Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-04 10:18 ` Charles Keepax [this message]
2017-09-04 10:18 ` Charles Keepax
2017-09-04 10:18 ` Charles Keepax
2017-09-04 13:14 ` Robert Jarzmik
2017-09-04 13:14 ` Robert Jarzmik
2017-09-04 13:14 ` Robert Jarzmik
2017-09-04 16:42 ` Mark Brown
2017-09-04 16:42 ` Mark Brown
2017-09-02 19:54 ` [PATCH v6 10/12] ASoC: wm9705: add private structure Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 11/12] ASoC: wm9705: add ac97 new bus support Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
2017-09-02 19:54 ` [PATCH v6 12/12] ASoC: pxa: switch to new ac97 " Robert Jarzmik
2017-09-02 19:54 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170904101849.7uefwhuqz4vtntrp@localhost.localdomain \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=daniel@zonque.org \
--cc=dmitry.torokhov@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=robert.jarzmik@free.fr \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.