All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nayna Jain <nayna@linux.vnet.ibm.com>
To: tpmdd-devel@lists.sourceforge.net
Cc: peterhuewe@gmx.de, tpmdd@selhorst.net,
	jarkko.sakkinen@linux.intel.com, jgunthorpe@obsidianresearch.com,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-ima-devel@lists.sourceforge.net, patrickc@us.ibm.com,
	Nayna Jain <nayna@linux.vnet.ibm.com>
Subject: [PATCH v2 0/4] additional TPM performance improvements
Date: Wed,  6 Sep 2017 08:56:35 -0400	[thread overview]
Message-ID: <20170906125643.5070-1-nayna@linux.vnet.ibm.com> (raw)

After further discussions with the Device Driver working group (ddwg),
the following changes were made: 

* Check for burstcount at least once to confirm the TPM is ready to accept
the data. Similarly, query for the TPM Expect status as sanity check at
the end.

* Make the sleep for status check during send() in the loop less than
5msec.

* Make the sleep in the loop while querying for burstcount less than
5msec.

Below is the list of patches along with the performance improvements
seen with a TPM 1.2 with an 8 byte burstcount for 1000 extends: 

Patch                                        |Improvement(time in sec)

tpm: ignore burstcount to improve tpm_tis    | ~41 - ~14
send() performance.

tpm: define __wait_for_tpm_stat to specify   | ~14 - ~10
variable polling sleep time

tpm: reduce tpm_msleep() time in             | ~10 - ~9
get_burstcount()

tpm: modify tpm_msleep() function to have    | ~9 - ~8
max range

Changelog v2:

* Add module parameter to handle ignoring of burst count during
tpm tis send() operation.
* Add improvements over sleep time to reduce delays.

Nayna Jain (4):
  tpm: ignore burstcount to improve tpm_tis send() performance.
  tpm: define __wait_for_tpm_stat to specify variable polling sleep time
  tpm: reduce tpm_msleep() time in get_burstcount()
  tpm: use tpm_msleep() value as max delay

 Documentation/admin-guide/kernel-parameters.txt |  8 ++++++
 drivers/char/tpm/tpm-interface.c                | 15 ++++++++--
 drivers/char/tpm/tpm.h                          |  7 +++--
 drivers/char/tpm/tpm_tis_core.c                 | 37 +++++++++++++++++++------
 4 files changed, 53 insertions(+), 14 deletions(-)

-- 
2.13.3

WARNING: multiple messages have this Message-ID (diff)
From: nayna@linux.vnet.ibm.com (Nayna Jain)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 0/4] additional TPM performance improvements
Date: Wed,  6 Sep 2017 08:56:35 -0400	[thread overview]
Message-ID: <20170906125643.5070-1-nayna@linux.vnet.ibm.com> (raw)

After further discussions with the Device Driver working group (ddwg),
the following changes were made: 

* Check for burstcount at least once to confirm the TPM is ready to accept
the data. Similarly, query for the TPM Expect status as sanity check at
the end.

* Make the sleep for status check during send() in the loop less than
5msec.

* Make the sleep in the loop while querying for burstcount less than
5msec.

Below is the list of patches along with the performance improvements
seen with a TPM 1.2 with an 8 byte burstcount for 1000 extends: 

Patch                                        |Improvement(time in sec)

tpm: ignore burstcount to improve tpm_tis    | ~41 - ~14
send() performance.

tpm: define __wait_for_tpm_stat to specify   | ~14 - ~10
variable polling sleep time

tpm: reduce tpm_msleep() time in             | ~10 - ~9
get_burstcount()

tpm: modify tpm_msleep() function to have    | ~9 - ~8
max range

Changelog v2:

* Add module parameter to handle ignoring of burst count during
tpm tis send() operation.
* Add improvements over sleep time to reduce delays.

Nayna Jain (4):
  tpm: ignore burstcount to improve tpm_tis send() performance.
  tpm: define __wait_for_tpm_stat to specify variable polling sleep time
  tpm: reduce tpm_msleep() time in get_burstcount()
  tpm: use tpm_msleep() value as max delay

 Documentation/admin-guide/kernel-parameters.txt |  8 ++++++
 drivers/char/tpm/tpm-interface.c                | 15 ++++++++--
 drivers/char/tpm/tpm.h                          |  7 +++--
 drivers/char/tpm/tpm_tis_core.c                 | 37 +++++++++++++++++++------
 4 files changed, 53 insertions(+), 14 deletions(-)

-- 
2.13.3

--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Nayna Jain <nayna-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: patrickc-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
	linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-ima-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [PATCH v2 0/4] additional TPM performance improvements
Date: Wed,  6 Sep 2017 08:56:35 -0400	[thread overview]
Message-ID: <20170906125643.5070-1-nayna@linux.vnet.ibm.com> (raw)

After further discussions with the Device Driver working group (ddwg),
the following changes were made: 

* Check for burstcount at least once to confirm the TPM is ready to accept
the data. Similarly, query for the TPM Expect status as sanity check at
the end.

* Make the sleep for status check during send() in the loop less than
5msec.

* Make the sleep in the loop while querying for burstcount less than
5msec.

Below is the list of patches along with the performance improvements
seen with a TPM 1.2 with an 8 byte burstcount for 1000 extends: 

Patch                                        |Improvement(time in sec)

tpm: ignore burstcount to improve tpm_tis    | ~41 - ~14
send() performance.

tpm: define __wait_for_tpm_stat to specify   | ~14 - ~10
variable polling sleep time

tpm: reduce tpm_msleep() time in             | ~10 - ~9
get_burstcount()

tpm: modify tpm_msleep() function to have    | ~9 - ~8
max range

Changelog v2:

* Add module parameter to handle ignoring of burst count during
tpm tis send() operation.
* Add improvements over sleep time to reduce delays.

Nayna Jain (4):
  tpm: ignore burstcount to improve tpm_tis send() performance.
  tpm: define __wait_for_tpm_stat to specify variable polling sleep time
  tpm: reduce tpm_msleep() time in get_burstcount()
  tpm: use tpm_msleep() value as max delay

 Documentation/admin-guide/kernel-parameters.txt |  8 ++++++
 drivers/char/tpm/tpm-interface.c                | 15 ++++++++--
 drivers/char/tpm/tpm.h                          |  7 +++--
 drivers/char/tpm/tpm_tis_core.c                 | 37 +++++++++++++++++++------
 4 files changed, 53 insertions(+), 14 deletions(-)

-- 
2.13.3


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

             reply	other threads:[~2017-09-06 13:01 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 12:56 Nayna Jain [this message]
2017-09-06 12:56 ` [PATCH v2 0/4] additional TPM performance improvements Nayna Jain
2017-09-06 12:56 ` Nayna Jain
2017-09-06 12:56 ` [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 16:12   ` Jason Gunthorpe
2017-09-06 16:12     ` Jason Gunthorpe
2017-09-13 18:52     ` [tpmdd-devel] " Ken Goldman
2017-09-13 18:52       ` Ken Goldman
2017-09-13 18:52       ` Ken Goldman
2017-09-13 19:01       ` Peter Huewe
2017-09-13 19:01         ` Peter Huewe
2017-09-13 19:01         ` [tpmdd-devel] " Peter Huewe
2017-09-13  0:45   ` Jarkko Sakkinen
2017-09-13  0:45     ` Jarkko Sakkinen
2017-09-13 18:39     ` Peter Huewe
2017-09-13 18:39       ` Peter Huewe
2017-09-13 18:39       ` Peter Huewe
2017-09-13 23:10       ` Jarkko Sakkinen
2017-09-13 23:10         ` Jarkko Sakkinen
2017-09-15 12:29         ` Nayna Jain
2017-09-15 12:29           ` Nayna Jain
2017-09-15 15:19           ` Jarkko Sakkinen
2017-09-15 15:19             ` Jarkko Sakkinen
2017-09-06 12:56 ` [PATCH v2 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-13  0:58   ` Jarkko Sakkinen
2017-09-13  0:58     ` Jarkko Sakkinen
2017-09-15 12:37     ` Nayna Jain
2017-09-15 12:37       ` Nayna Jain
2017-09-15 15:20       ` Jarkko Sakkinen
2017-09-15 15:20         ` Jarkko Sakkinen
2017-09-06 12:56 ` [PATCH v2 3/4] tpm: reduce tpm_msleep() time in get_burstcount() Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-13  1:00   ` Jarkko Sakkinen
2017-09-13  1:00     ` Jarkko Sakkinen
2017-09-15 12:40     ` Nayna Jain
2017-09-15 12:40       ` Nayna Jain
2017-09-06 12:56 ` [PATCH v2 4/4] tpm: use tpm_msleep() value as max delay Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-13  0:47   ` Jarkko Sakkinen
2017-09-13  0:47     ` Jarkko Sakkinen
2017-09-14  9:25     ` Nayna Jain
2017-09-14  9:25       ` Nayna Jain
2017-09-14 12:28       ` Jarkko Sakkinen
2017-09-14 12:28         ` Jarkko Sakkinen
2017-09-06 12:56 ` [PATCH 1/4] tpm: ignore burstcount to improve tpm_tis send() performance Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 12:58   ` Nayna
2017-09-06 12:58     ` Nayna
2017-09-06 12:58     ` Nayna
2017-09-06 12:56 ` [PATCH 2/4] tpm: define __wait_for_tpm_stat to specify variable polling sleep time Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 12:56   ` Nayna Jain
2017-09-06 12:58   ` Nayna
2017-09-06 12:58     ` Nayna
2017-09-07 16:18 ` [PATCH v2 0/4] additional TPM performance improvements Jarkko Sakkinen
2017-09-07 16:18   ` Jarkko Sakkinen
2017-09-11 15:20 ` [tpmdd-devel] " Alexander.Steffen
2017-09-11 15:20   ` Alexander.Steffen
2017-09-11 15:20   ` Alexander.Steffen at infineon.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170906125643.5070-1-nayna@linux.vnet.ibm.com \
    --to=nayna@linux.vnet.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-ima-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=patrickc@us.ibm.com \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.