From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 8/8] staging: ccree: remove BUG macro usage
Date: Wed, 6 Sep 2017 22:28:21 +0300 [thread overview]
Message-ID: <20170906192821.4ytcxj436uyug6pr@mwanda> (raw)
In-Reply-To: <1504429011-25514-9-git-send-email-gilad@benyossef.com>
On Sun, Sep 03, 2017 at 11:56:50AM +0300, Gilad Ben-Yossef wrote:
> @@ -1154,7 +1150,8 @@ static inline int ssi_buffer_mgr_aead_chain_data(
> //if have reached the end of the sgl, then this is unexpected
> if (!areq_ctx->src_sgl) {
> SSI_LOG_ERR("reached end of sg list. unexpected\n");
> - BUG();
> + return -EINVAL;
> + goto chain_data_exit;
You've got a direct return followed by a goto.
It's a do-nothing goto that just returns rc. I hate those. I've tried
to review locking bugs to see if single returns prevent future
programmers from introducing new error paths which don't unlock. They
don't really help...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-crypto@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 8/8] staging: ccree: remove BUG macro usage
Date: Wed, 6 Sep 2017 22:28:21 +0300 [thread overview]
Message-ID: <20170906192821.4ytcxj436uyug6pr@mwanda> (raw)
In-Reply-To: <1504429011-25514-9-git-send-email-gilad@benyossef.com>
On Sun, Sep 03, 2017 at 11:56:50AM +0300, Gilad Ben-Yossef wrote:
> @@ -1154,7 +1150,8 @@ static inline int ssi_buffer_mgr_aead_chain_data(
> //if have reached the end of the sgl, then this is unexpected
> if (!areq_ctx->src_sgl) {
> SSI_LOG_ERR("reached end of sg list. unexpected\n");
> - BUG();
> + return -EINVAL;
> + goto chain_data_exit;
You've got a direct return followed by a goto.
It's a do-nothing goto that just returns rc. I hate those. I've tried
to review locking bugs to see if single returns prevent future
programmers from introducing new error paths which don't unlock. They
don't really help...
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Ofir Drang <ofir.drang@arm.com>
Subject: Re: [PATCH 8/8] staging: ccree: remove BUG macro usage
Date: Wed, 6 Sep 2017 22:28:21 +0300 [thread overview]
Message-ID: <20170906192821.4ytcxj436uyug6pr@mwanda> (raw)
In-Reply-To: <1504429011-25514-9-git-send-email-gilad@benyossef.com>
On Sun, Sep 03, 2017 at 11:56:50AM +0300, Gilad Ben-Yossef wrote:
> @@ -1154,7 +1150,8 @@ static inline int ssi_buffer_mgr_aead_chain_data(
> //if have reached the end of the sgl, then this is unexpected
> if (!areq_ctx->src_sgl) {
> SSI_LOG_ERR("reached end of sg list. unexpected\n");
> - BUG();
> + return -EINVAL;
> + goto chain_data_exit;
You've got a direct return followed by a goto.
It's a do-nothing goto that just returns rc. I hate those. I've tried
to review locking bugs to see if single returns prevent future
programmers from introducing new error paths which don't unlock. They
don't really help...
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2017-09-06 19:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 8:56 [PATCH 0/8] staging: ccree: more cleanup work for 4.14 Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 1/8] staging: ccree: Replace kzalloc with devm_kzalloc Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 2/8] staging: ccree: Convert to devm_ioremap_resource for map, unmap Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 3/8] staging: ccree: Use platform_get_irq and devm_request_irq Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 4/8] staging: ccree: simplify resource release on error Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 5/8] staging: ccree: remove unused completion Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 6/8] staging: ccree: move over to BIT macro for bit defines Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-03 8:56 ` [PATCH 7/8] staging: ccree: replace noop macro with inline Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-09 9:11 ` Dan Carpenter
2017-09-09 9:11 ` Dan Carpenter
2017-09-03 8:56 ` [PATCH 8/8] staging: ccree: remove BUG macro usage Gilad Ben-Yossef
2017-09-03 8:56 ` Gilad Ben-Yossef
2017-09-06 19:28 ` Dan Carpenter [this message]
2017-09-06 19:28 ` Dan Carpenter
2017-09-06 19:28 ` Dan Carpenter
2017-09-07 9:00 ` Gilad Ben-Yossef
2017-09-07 9:00 ` Gilad Ben-Yossef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906192821.4ytcxj436uyug6pr@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gilad@benyossef.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ofir.drang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.