From: Jonathan Cameron <jic23@kernel.org> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, wsa@the-dreams.de, kishon@ti.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'twl4030_madc_probe()' Date: Sun, 24 Sep 2017 13:05:06 +0100 [thread overview] Message-ID: <20170924130506.19e1b733@archlinux> (raw) In-Reply-To: <128d2bb662f174ed84c61dc268940bd87878f0d1.1506146101.git.christophe.jaillet@wanadoo.fr> On Sat, 23 Sep 2017 08:06:20 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > If we can not enable the regulator, go through the error handling path > instead of silently continuing. > > Fixes: 7cc97d77ee8a ("iio: adc: twl4030: Fix ADC[3:6] readings") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied to the fixes-togreg-post-rc1 branch of iio.git. I haven't explicitly marked this one for stable as it isn't broken as such, just inconsistent. Thanks, Jonathan > --- > This patch is highly speculative. > I don't find logical to return an error if we don't find the 'vusb3v1' > regulator, but continue if we find it, but can't enable it. > Returning an error if both cases (i.e. failing 'devm_regulator_get()' or > 'regulator_enable)' seems the usual pattern in all the .probe functions > with a 'regulator_enable()' call have looked at (~ 10 of them taken > randomly) > --- > drivers/iio/adc/twl4030-madc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 32db23d9a483..e3cfb91bffc6 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -893,8 +893,10 @@ static int twl4030_madc_probe(struct platform_device *pdev) > } > > ret = regulator_enable(madc->usb3v1); > - if (ret) > + if (ret) { > dev_err(madc->dev, "could not enable 3v1 bias regulator\n"); > + goto err_i2c; > + } > > ret = iio_device_register(iio_dev); > if (ret) {
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, sre@kernel.org, wsa@the-dreams.de, kishon@ti.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'tw Date: Sun, 24 Sep 2017 12:05:06 +0000 [thread overview] Message-ID: <20170924130506.19e1b733@archlinux> (raw) In-Reply-To: <128d2bb662f174ed84c61dc268940bd87878f0d1.1506146101.git.christophe.jaillet@wanadoo.fr> On Sat, 23 Sep 2017 08:06:20 +0200 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > If we can not enable the regulator, go through the error handling path > instead of silently continuing. > > Fixes: 7cc97d77ee8a ("iio: adc: twl4030: Fix ADC[3:6] readings") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied to the fixes-togreg-post-rc1 branch of iio.git. I haven't explicitly marked this one for stable as it isn't broken as such, just inconsistent. Thanks, Jonathan > --- > This patch is highly speculative. > I don't find logical to return an error if we don't find the 'vusb3v1' > regulator, but continue if we find it, but can't enable it. > Returning an error if both cases (i.e. failing 'devm_regulator_get()' or > 'regulator_enable)' seems the usual pattern in all the .probe functions > with a 'regulator_enable()' call have looked at (~ 10 of them taken > randomly) > --- > drivers/iio/adc/twl4030-madc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/twl4030-madc.c b/drivers/iio/adc/twl4030-madc.c > index 32db23d9a483..e3cfb91bffc6 100644 > --- a/drivers/iio/adc/twl4030-madc.c > +++ b/drivers/iio/adc/twl4030-madc.c > @@ -893,8 +893,10 @@ static int twl4030_madc_probe(struct platform_device *pdev) > } > > ret = regulator_enable(madc->usb3v1); > - if (ret) > + if (ret) { > dev_err(madc->dev, "could not enable 3v1 bias regulator\n"); > + goto err_i2c; > + } > > ret = iio_device_register(iio_dev); > if (ret) {
next prev parent reply other threads:[~2017-09-24 12:05 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-23 6:03 [PATCH 0/3] iio: adc: twl4030: Fix some error handling issues in 'twl4030_madc_probe()' Christophe JAILLET 2017-09-23 6:03 ` Christophe JAILLET 2017-09-23 6:06 ` [PATCH 1/3] iio: adc: twl4030: Fix an error handling path " Christophe JAILLET 2017-09-23 6:06 ` Christophe JAILLET 2017-09-24 11:58 ` Jonathan Cameron 2017-09-24 11:58 ` Jonathan Cameron 2017-09-23 6:06 ` [PATCH 2/3] iio: adc: twl4030: Disable the vusb3v1 rugulator in the error handling path of 'twl4030_madc_probe()' Christophe JAILLET 2017-09-23 6:06 ` [PATCH 2/3] iio: adc: twl4030: Disable the vusb3v1 rugulator in the error handling path of 'twl4030_ Christophe JAILLET 2017-09-24 12:00 ` [PATCH 2/3] iio: adc: twl4030: Disable the vusb3v1 rugulator in the error handling path of 'twl4030_madc_probe()' Jonathan Cameron 2017-09-24 12:00 ` [PATCH 2/3] iio: adc: twl4030: Disable the vusb3v1 rugulator in the error handling path of 'twl4 Jonathan Cameron 2017-09-23 6:06 ` [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'twl4030_madc_probe()' Christophe JAILLET 2017-09-23 6:06 ` [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'twl403 Christophe JAILLET 2017-09-24 12:05 ` Jonathan Cameron [this message] 2017-09-24 12:05 ` [PATCH 3/3] iio: adc: twl4030: Return an error if we can not enable the vusb3v1 regulator in 'tw Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170924130506.19e1b733@archlinux \ --to=jic23@kernel.org \ --cc=christophe.jaillet@wanadoo.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=kishon@ti.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=sre@kernel.org \ --cc=wsa@the-dreams.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.