From: Daniel Vetter <daniel@ffwll.ch> To: Helge Deller <deller@gmx.de> Cc: linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [Intel-gfx] [PATCH 05/14] i915: Use %pS printk format for direct addresses Date: Wed, 27 Sep 2017 14:24:01 +0200 [thread overview] Message-ID: <20170927122401.oqvdnaduzdk5tdwl@phenom.ffwll.local> (raw) In-Reply-To: <1504729681-3504-6-git-send-email-deller@gmx.de> On Wed, Sep 06, 2017 at 10:27:52PM +0200, Helge Deller wrote: > Use the %pS printk format for printing symbols from direct addresses. > This is important for the ia64, ppc64 and parisc64 architectures, while on > other architectures there is no difference between %pS and %pF. > Fix it for consistency across the kernel. i915.ko never runs on any of these, but if it helps with keeping things consistent, why not. Applied, thanks. -Daniel > > Signed-off-by: Helge Deller <deller@gmx.de> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: intel-gfx@lists.freedesktop.org > --- > drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c > index 4e00e5c..29c62d4 100644 > --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c > +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c > @@ -64,7 +64,7 @@ static unsigned long wait_timeout(void) > > static noinline void missed_breadcrumb(struct intel_engine_cs *engine) > { > - DRM_DEBUG_DRIVER("%s missed breadcrumb at %pF, irq posted? %s, current seqno=%x, last=%x\n", > + DRM_DEBUG_DRIVER("%s missed breadcrumb at %pS, irq posted? %s, current seqno=%x, last=%x\n", > engine->name, __builtin_return_address(0), > yesno(test_bit(ENGINE_IRQ_BREADCRUMB, > &engine->irq_posted)), > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch> To: Helge Deller <deller@gmx.de> Cc: Petr Mladek <pmladek@suse.com>, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Andrew Morton <akpm@linux-foundation.org> Subject: Re: [PATCH 05/14] i915: Use %pS printk format for direct addresses Date: Wed, 27 Sep 2017 14:24:01 +0200 [thread overview] Message-ID: <20170927122401.oqvdnaduzdk5tdwl@phenom.ffwll.local> (raw) In-Reply-To: <1504729681-3504-6-git-send-email-deller@gmx.de> On Wed, Sep 06, 2017 at 10:27:52PM +0200, Helge Deller wrote: > Use the %pS printk format for printing symbols from direct addresses. > This is important for the ia64, ppc64 and parisc64 architectures, while on > other architectures there is no difference between %pS and %pF. > Fix it for consistency across the kernel. i915.ko never runs on any of these, but if it helps with keeping things consistent, why not. Applied, thanks. -Daniel > > Signed-off-by: Helge Deller <deller@gmx.de> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: David Airlie <airlied@linux.ie> > Cc: intel-gfx@lists.freedesktop.org > --- > drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c b/drivers/gpu/drm/i915/intel_breadcrumbs.c > index 4e00e5c..29c62d4 100644 > --- a/drivers/gpu/drm/i915/intel_breadcrumbs.c > +++ b/drivers/gpu/drm/i915/intel_breadcrumbs.c > @@ -64,7 +64,7 @@ static unsigned long wait_timeout(void) > > static noinline void missed_breadcrumb(struct intel_engine_cs *engine) > { > - DRM_DEBUG_DRIVER("%s missed breadcrumb at %pF, irq posted? %s, current seqno=%x, last=%x\n", > + DRM_DEBUG_DRIVER("%s missed breadcrumb at %pS, irq posted? %s, current seqno=%x, last=%x\n", > engine->name, __builtin_return_address(0), > yesno(test_bit(ENGINE_IRQ_BREADCRUMB, > &engine->irq_posted)), > -- > 2.1.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-27 12:24 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-06 20:27 [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Helge Deller 2017-09-06 20:27 ` [PATCH 01/14] arm: Use %pS printk format for symbols from direct addresses Helge Deller 2017-09-06 20:27 ` Helge Deller 2017-09-06 20:27 ` [PATCH 02/14] um: " Helge Deller 2017-09-12 12:10 ` Petr Mladek 2017-09-21 20:13 ` Richard Weinberger 2017-09-06 20:27 ` [PATCH 03/14] x86: " Helge Deller 2017-09-06 20:27 ` [PATCH 04/14] ti_sci: Use %pS printk format for " Helge Deller 2017-09-06 20:27 ` Helge Deller 2017-09-08 23:30 ` Nishanth Menon 2017-09-08 23:30 ` Nishanth Menon 2017-09-09 0:30 ` Santosh Shilimkar 2017-09-09 0:30 ` Santosh Shilimkar 2017-09-06 20:27 ` [PATCH 05/14] i915: " Helge Deller 2017-09-27 12:24 ` Daniel Vetter [this message] 2017-09-27 12:24 ` Daniel Vetter 2017-09-06 20:27 ` [PATCH 06/14] md/bcache: " Helge Deller 2017-09-07 4:50 ` Coly Li 2017-09-07 7:42 ` Helge Deller 2017-09-07 7:49 ` Coly Li 2017-09-07 8:05 ` Sergey Senozhatsky 2017-09-06 20:27 ` [PATCH 07/14] power/avs: " Helge Deller 2017-09-08 23:37 ` Nishanth Menon 2017-09-08 23:37 ` Nishanth Menon 2017-09-06 20:27 ` [PATCH 08/14] fs/f2fs: " Helge Deller 2017-09-06 20:27 ` Helge Deller 2017-09-06 20:27 ` [PATCH 09/14] fs/pstore: " Helge Deller 2018-11-29 23:26 ` Kees Cook 2018-11-29 23:49 ` Luck, Tony 2018-11-30 0:40 ` Kees Cook 2017-09-06 20:27 ` [PATCH 10/14] fs/xfs: " Helge Deller 2017-09-08 7:38 ` Christoph Hellwig 2017-09-18 18:37 ` Darrick J. Wong 2017-09-06 20:27 ` [PATCH 11/14] smp: Use %pF printk format specifier for function pointers Helge Deller 2017-09-06 20:27 ` [PATCH 12/14] mm/memblock: Use %pS printk format for direct addresses Helge Deller 2017-09-06 20:27 ` Helge Deller 2017-09-06 20:28 ` [PATCH 13/14] netfilter/ipvs: " Helge Deller 2017-10-09 5:52 ` Simon Horman 2017-11-06 13:46 ` Pablo Neira Ayuso 2017-09-06 20:28 ` [PATCH 14/14] sound/core: " Helge Deller 2017-09-07 8:36 ` Takashi Iwai 2017-09-07 8:36 ` Takashi Iwai 2017-09-07 0:45 ` [PATCH 00/14] Fix wrong %pF and %pS printk format specifier usages Sergey Senozhatsky 2017-09-07 6:01 ` Helge Deller 2017-09-07 7:56 ` Sergey Senozhatsky 2017-09-07 8:32 ` Sergey Senozhatsky 2017-09-07 9:12 ` Helge Deller 2017-09-07 9:36 ` Sergey Senozhatsky 2017-09-07 9:51 ` Sergey Senozhatsky 2017-09-07 12:38 ` Helge Deller 2017-09-07 16:05 ` Luck, Tony 2017-09-08 6:18 ` Sergey Senozhatsky 2017-09-08 17:25 ` Luck, Tony 2017-09-08 18:28 ` Helge Deller 2017-09-14 7:40 ` Sergey Senozhatsky 2017-09-14 8:03 ` Sergey Senozhatsky 2017-09-14 8:39 ` Helge Deller 2017-09-14 9:27 ` Sergey Senozhatsky 2017-09-14 9:47 ` Helge Deller 2017-09-14 16:01 ` Luck, Tony 2017-09-18 7:03 ` Sergey Senozhatsky 2017-09-14 6:53 ` Sergey Senozhatsky 2017-09-08 20:49 ` Helge Deller 2017-09-12 11:18 ` Petr Mladek 2017-09-14 6:44 ` Sergey Senozhatsky 2017-09-08 22:23 ` Yu, Fenghua 2017-09-14 6:35 ` Sergey Senozhatsky 2017-09-07 16:50 ` Joe Perches 2017-09-08 6:23 ` Sergey Senozhatsky 2017-09-08 20:39 ` Helge Deller 2017-09-12 12:23 ` Petr Mladek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20170927122401.oqvdnaduzdk5tdwl@phenom.ffwll.local \ --to=daniel@ffwll.ch \ --cc=airlied@linux.ie \ --cc=akpm@linux-foundation.org \ --cc=deller@gmx.de \ --cc=intel-gfx@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmladek@suse.com \ --cc=sergey.senozhatsky@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.