All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Christoph Hellwig <hch@lst.de>,
	Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] xfs: always use DAX if mount option is used
Date: Sun, 1 Oct 2017 10:17:02 +0200	[thread overview]
Message-ID: <20171001081702.GC11895@lst.de> (raw)
In-Reply-To: <20170927161510.GB24314@linux.intel.com>

On Wed, Sep 27, 2017 at 10:15:10AM -0600, Ross Zwisler wrote:
> Well, I don't know if platforms that support HMAT + PMEM are widely available,
> but we have all the details in the ACPI spec, so we could begin to code it up
> and things will "just work" when platforms arrive.

Then again currently all actually shipping NVDIMMs are battery backed
dram and DAX mode should work just fine for them.  Things will get
interesting once companies start shipping actually persistent technologies
that will be significantly slower than DRAM.  And we sould make sure
we have the infrastruture for that in place.

> Hum, I wonder if maybe we need/want three different mount modes?  What about:
> 
> autodax (the default): the filesystem is free to use DAX or not, as it sees
> fit and thinks is optimal.  For the time being we can make this mean "don't
> use DAX", and phase in DAX usage as we add support for the HMAT, etc.

What does "use DAX" really mean anyway?

I think we are conflating a few things:

 a) use a block device or use a dax_device for accessing the device
 b) use the pagecache for caching data in DRAM or not.

Now we actually have a really nice way to control a) already, it's
called O_DIRECT.  Currently O_DIRECT only works with read/write I/O,
but with a byte addressable scheme we now can implement it for mmap
as well, which is what the DAX mmap path does.

b) right now is implied by a), but it's really an implementation
detail.

So the modes would be more like two options to:

 a) disallow any byte-level access.  The right way to do that would
    be to mount the /dev/dax* device instead of the block device
    to allow byte access, and disallow any DAXish operation if you
    mount the block device in the long run.
 b) have a mode to always force an O_DIRECT-like mode for devices
    that are fast enough.  We should always do that with the right
    HMAT entries if mounting the /dev/dax devices, and maybe have
    a mount option to force it.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Christoph Hellwig <hch@lst.de>,
	Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] xfs: always use DAX if mount option is used
Date: Sun, 1 Oct 2017 10:17:02 +0200	[thread overview]
Message-ID: <20171001081702.GC11895@lst.de> (raw)
In-Reply-To: <20170927161510.GB24314@linux.intel.com>

On Wed, Sep 27, 2017 at 10:15:10AM -0600, Ross Zwisler wrote:
> Well, I don't know if platforms that support HMAT + PMEM are widely available,
> but we have all the details in the ACPI spec, so we could begin to code it up
> and things will "just work" when platforms arrive.

Then again currently all actually shipping NVDIMMs are battery backed
dram and DAX mode should work just fine for them.  Things will get
interesting once companies start shipping actually persistent technologies
that will be significantly slower than DRAM.  And we sould make sure
we have the infrastruture for that in place.

> Hum, I wonder if maybe we need/want three different mount modes?  What about:
> 
> autodax (the default): the filesystem is free to use DAX or not, as it sees
> fit and thinks is optimal.  For the time being we can make this mean "don't
> use DAX", and phase in DAX usage as we add support for the HMAT, etc.

What does "use DAX" really mean anyway?

I think we are conflating a few things:

 a) use a block device or use a dax_device for accessing the device
 b) use the pagecache for caching data in DRAM or not.

Now we actually have a really nice way to control a) already, it's
called O_DIRECT.  Currently O_DIRECT only works with read/write I/O,
but with a byte addressable scheme we now can implement it for mmap
as well, which is what the DAX mmap path does.

b) right now is implied by a), but it's really an implementation
detail.

So the modes would be more like two options to:

 a) disallow any byte-level access.  The right way to do that would
    be to mount the /dev/dax* device instead of the block device
    to allow byte access, and disallow any DAXish operation if you
    mount the block device in the long run.
 b) have a mode to always force an O_DIRECT-like mode for devices
    that are fast enough.  We should always do that with the right
    HMAT entries if mounting the /dev/dax devices, and maybe have
    a mount option to force it.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
	Christoph Hellwig <hch@infradead.org>,
	Christoph Hellwig <hch@lst.de>,
	Dave Chinner <david@fromorbit.com>, Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] xfs: always use DAX if mount option is used
Date: Sun, 1 Oct 2017 10:17:02 +0200	[thread overview]
Message-ID: <20171001081702.GC11895@lst.de> (raw)
In-Reply-To: <20170927161510.GB24314@linux.intel.com>

On Wed, Sep 27, 2017 at 10:15:10AM -0600, Ross Zwisler wrote:
> Well, I don't know if platforms that support HMAT + PMEM are widely available,
> but we have all the details in the ACPI spec, so we could begin to code it up
> and things will "just work" when platforms arrive.

Then again currently all actually shipping NVDIMMs are battery backed
dram and DAX mode should work just fine for them.  Things will get
interesting once companies start shipping actually persistent technologies
that will be significantly slower than DRAM.  And we sould make sure
we have the infrastruture for that in place.

> Hum, I wonder if maybe we need/want three different mount modes?  What about:
> 
> autodax (the default): the filesystem is free to use DAX or not, as it sees
> fit and thinks is optimal.  For the time being we can make this mean "don't
> use DAX", and phase in DAX usage as we add support for the HMAT, etc.

What does "use DAX" really mean anyway?

I think we are conflating a few things:

 a) use a block device or use a dax_device for accessing the device
 b) use the pagecache for caching data in DRAM or not.

Now we actually have a really nice way to control a) already, it's
called O_DIRECT.  Currently O_DIRECT only works with read/write I/O,
but with a byte addressable scheme we now can implement it for mmap
as well, which is what the DAX mmap path does.

b) right now is implied by a), but it's really an implementation
detail.

So the modes would be more like two options to:

 a) disallow any byte-level access.  The right way to do that would
    be to mount the /dev/dax* device instead of the block device
    to allow byte access, and disallow any DAXish operation if you
    mount the block device in the long run.
 b) have a mode to always force an O_DIRECT-like mode for devices
    that are fast enough.  We should always do that with the right
    HMAT entries if mounting the /dev/dax devices, and maybe have
    a mount option to force it.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-10-01  8:13 UTC|newest]

Thread overview: 130+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 23:13 [PATCH 0/7] re-enable XFS per-inode DAX Ross Zwisler
2017-09-25 23:13 ` Ross Zwisler
2017-09-25 23:13 ` Ross Zwisler
2017-09-25 23:13 ` [PATCH 1/7] xfs: always use DAX if mount option is used Ross Zwisler
2017-09-25 23:13   ` Ross Zwisler
2017-09-25 23:13   ` Ross Zwisler
2017-09-25 23:38   ` Dave Chinner
2017-09-25 23:38     ` Dave Chinner
2017-09-25 23:38     ` Dave Chinner
2017-09-26  9:35     ` Jan Kara
2017-09-26  9:35       ` Jan Kara
2017-09-26  9:35       ` Jan Kara
2017-09-26 11:09       ` Dave Chinner
2017-09-26 11:09         ` Dave Chinner
2017-09-26 11:09         ` Dave Chinner
2017-09-26 14:37         ` Christoph Hellwig
2017-09-26 14:37           ` Christoph Hellwig
2017-09-26 17:30           ` Ross Zwisler
2017-09-26 17:30             ` Ross Zwisler
2017-09-26 17:30             ` Ross Zwisler
2017-09-26 19:48             ` Darrick J. Wong
2017-09-26 19:48               ` Darrick J. Wong
2017-09-26 22:00               ` Dave Chinner
2017-09-26 22:00                 ` Dave Chinner
2017-09-26 22:00                 ` Dave Chinner
2017-09-27  6:40             ` Christoph Hellwig
2017-09-27  6:40               ` Christoph Hellwig
2017-09-27  6:40               ` Christoph Hellwig
2017-09-27 16:15               ` Ross Zwisler
2017-09-27 16:15                 ` Ross Zwisler
2017-10-01  8:17                 ` Christoph Hellwig [this message]
2017-10-01  8:17                   ` Christoph Hellwig
2017-10-01  8:17                   ` Christoph Hellwig
2017-09-26 18:02         ` Eric Sandeen
2017-09-26 18:02           ` Eric Sandeen
2017-09-26 18:02           ` Eric Sandeen
2017-09-26 18:50     ` Ross Zwisler
2017-09-26 18:50       ` Ross Zwisler
2017-09-26 18:50       ` Ross Zwisler
2017-09-25 23:13 ` [PATCH 2/7] xfs: validate bdev support for DAX inode flag Ross Zwisler
2017-09-25 23:13   ` Ross Zwisler
2017-09-25 23:13   ` Ross Zwisler
2017-09-26  6:36   ` Christoph Hellwig
2017-09-26  6:36     ` Christoph Hellwig
2017-09-26  6:36     ` Christoph Hellwig
2017-09-26 17:16     ` Ross Zwisler
2017-09-26 17:16       ` Ross Zwisler
2017-09-26 17:16       ` Ross Zwisler
2017-09-26 17:57       ` Darrick J. Wong
2017-09-26 17:57         ` Darrick J. Wong
2017-09-25 23:14 ` [PATCH 3/7] xfs: protect S_DAX transitions in XFS read path Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:27   ` Dave Chinner
2017-09-25 23:27     ` Dave Chinner
2017-09-25 23:27     ` Dave Chinner
2017-09-26  6:32   ` Christoph Hellwig
2017-09-26  6:32     ` Christoph Hellwig
2017-09-26  6:32     ` Christoph Hellwig
2017-09-26 13:59     ` Dan Williams
2017-09-26 13:59       ` Dan Williams
2017-09-26 13:59       ` Dan Williams
2017-09-26 14:33       ` Christoph Hellwig
2017-09-26 14:33         ` Christoph Hellwig
2017-09-26 14:33         ` Christoph Hellwig
2017-09-26 18:11         ` Dan Williams
2017-09-26 18:11           ` Dan Williams
2017-10-01  8:17           ` Christoph Hellwig
2017-10-01  8:17             ` Christoph Hellwig
2017-10-01  8:17             ` Christoph Hellwig
2017-09-25 23:14 ` [PATCH 4/7] xfs: protect S_DAX transitions in XFS write path Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:29   ` Dave Chinner
2017-09-25 23:29     ` Dave Chinner
2017-09-25 23:29     ` Dave Chinner
2017-09-25 23:14 ` [PATCH 5/7] xfs: introduce xfs_is_dax_state_changing Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-26  6:33   ` Christoph Hellwig
2017-09-26  6:33     ` Christoph Hellwig
2017-09-26  6:33     ` Christoph Hellwig
2017-09-25 23:14 ` [PATCH 6/7] mm, fs: introduce file_operations->post_mmap() Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:38   ` Dan Williams
2017-09-25 23:38     ` Dan Williams
2017-09-26 18:57     ` Ross Zwisler
2017-09-26 18:57       ` Ross Zwisler
2017-09-26 18:57       ` Ross Zwisler
2017-09-26 19:19       ` Dan Williams
2017-09-26 19:19         ` Dan Williams
2017-09-26 19:19         ` Dan Williams
2017-09-26 21:06         ` Ross Zwisler
2017-09-26 21:06           ` Ross Zwisler
2017-09-26 21:06           ` Ross Zwisler
2017-09-26 21:41           ` Dan Williams
2017-09-26 21:41             ` Dan Williams
2017-09-26 21:41             ` Dan Williams
2017-09-27 11:35             ` Jan Kara
2017-09-27 11:35               ` Jan Kara
2017-09-27 11:35               ` Jan Kara
2017-09-27 14:00               ` Dan Williams
2017-09-27 14:00                 ` Dan Williams
2017-09-27 14:00                 ` Dan Williams
2017-09-27 15:07                 ` Jan Kara
2017-09-27 15:07                   ` Jan Kara
2017-09-27 15:07                   ` Jan Kara
2017-09-27 15:36                   ` Dan Williams
2017-09-27 15:36                     ` Dan Williams
2017-09-27 15:39               ` Ross Zwisler
2017-09-27 15:39                 ` Ross Zwisler
2017-09-27 15:39                 ` Ross Zwisler
2017-09-27 15:54                 ` Dan Williams
2017-09-27 15:54                   ` Dan Williams
2017-09-27 15:54                   ` Dan Williams
2017-09-26  6:34   ` Christoph Hellwig
2017-09-26  6:34     ` Christoph Hellwig
2017-09-26  6:34     ` Christoph Hellwig
2017-09-25 23:14 ` [PATCH 7/7] xfs: re-enable XFS per-inode DAX Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-25 23:14   ` Ross Zwisler
2017-09-26  0:31   ` Dave Chinner
2017-09-26  0:31     ` Dave Chinner
2017-09-26  0:31     ` Dave Chinner
2017-09-26  6:36   ` Christoph Hellwig
2017-09-26  6:36     ` Christoph Hellwig
2017-09-26 19:01     ` Ross Zwisler
2017-09-26 19:01       ` Ross Zwisler
2017-09-26 19:01       ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171001081702.GC11895@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=dan.j.williams@intel.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=jlayton@poochiereds.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=ross.zwisler@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.