From: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Sathya Perla <sathya.perla@broadcom.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
Kalle Valo <kvalo@codeaurora.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
intel-wired-lan@lists.osuosl.org, USB <linux-usb@vger.kernel.org>,
"open list:TI WILINK WIRELES..." <linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
brcm80211-dev-list@cypress.com
Subject: Re: [PATCH 05/18] net: use ARRAY_SIZE
Date: Mon, 2 Oct 2017 21:22:14 -0400 [thread overview]
Message-ID: <20171002212214.30d7013a@blatinox-laptop.localdomain> (raw)
In-Reply-To: <CAHp75VfC2e+h8GCiB-1Rbe=_z3siBBo0WfqEf3qz8yWh8Cm3RQ@mail.gmail.com>
On Mon, 2 Oct 2017 16:07:36 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192,
> > + 32},
>
> For all such cases I would rather put on one line disregard checkpatch
> warning for better readability.
I agree that it would be better. I didn't know that it was possible to
not follow this rule for anything else than a string.
I am waiting for more comments and I will send a v2.
Thank you,
Jérémy
WARNING: multiple messages have this Message-ID (diff)
From: "Jérémy Lefaure" <jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
To: Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Sathya Perla
<sathya.perla-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Ajit Khaparde
<ajit.khaparde-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Sriharsha Basavapatna
<sriharsha.basavapatna-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Somnath Kotur
<somnath.kotur-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Jeff Kirsher
<jeffrey.t.kirsher-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Arend van Spriel
<arend.vanspriel-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Franky Lin <franky.lin-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Hante Meuleman
<hante.meuleman-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>,
Chi-Hsien Lin
<chi-hsien.lin-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
Wright Feng <wright.feng-+wT8y+m8/X5BDgjK7y7TUQ@public.gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Larry Finger
<Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>,
Chaoming Li <chaoming_li-kXabqFNEczNtrwSWzY7KCg@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Alexey Kuznetsov <kuznet-v/Mj1YrvjDBInbfyfbPRSQ@public.gmane.org>,
Hideaki YOSHIFUJI
<yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org>,
netdev <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <
Subject: Re: [PATCH 05/18] net: use ARRAY_SIZE
Date: Mon, 2 Oct 2017 21:22:14 -0400 [thread overview]
Message-ID: <20171002212214.30d7013a@blatinox-laptop.localdomain> (raw)
In-Reply-To: <CAHp75VfC2e+h8GCiB-1Rbe=_z3siBBo0WfqEf3qz8yWh8Cm3RQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, 2 Oct 2017 16:07:36 +0300
Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192,
> > + 32},
>
> For all such cases I would rather put on one line disregard checkpatch
> warning for better readability.
I agree that it would be better. I didn't know that it was possible to
not follow this rule for anything else than a string.
I am waiting for more comments and I will send a v2.
Thank you,
Jérémy
WARNING: multiple messages have this Message-ID (diff)
From: =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure <jeremy.lefaure@lse.epita.fr>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 05/18] net: use ARRAY_SIZE
Date: Mon, 2 Oct 2017 21:22:14 -0400 [thread overview]
Message-ID: <20171002212214.30d7013a@blatinox-laptop.localdomain> (raw)
In-Reply-To: <CAHp75VfC2e+h8GCiB-1Rbe=_z3siBBo0WfqEf3qz8yWh8Cm3RQ@mail.gmail.com>
On Mon, 2 Oct 2017 16:07:36 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192,
> > + 32},
>
> For all such cases I would rather put on one line disregard checkpatch
> warning for better readability.
I agree that it would be better. I didn't know that it was possible to
not follow this rule for anything else than a string.
I am waiting for more comments and I will send a v2.
Thank you,
J?r?my
next prev parent reply other threads:[~2017-10-03 1:38 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 19:30 [PATCH 00/18] use ARRAY_SIZE macro Jérémy Lefaure
2017-10-01 19:30 ` Jérémy Lefaure
2017-10-01 19:30 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure
2017-10-01 19:30 ` Jérémy Lefaure
2017-10-01 19:30 ` Jérémy Lefaure
2017-10-01 19:30 ` Jérémy Lefaure
2017-10-01 19:30 ` Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 01/18] sound: use ARRAY_SIZE Jérémy Lefaure
2017-10-02 4:16 ` Joe Perches
2017-10-03 1:12 ` Jérémy Lefaure
2017-10-03 1:12 ` Jérémy Lefaure
2017-10-03 7:03 ` Takashi Iwai
2017-10-03 7:03 ` Takashi Iwai
2017-10-01 19:30 ` [PATCH 02/18] tracing/filter: " Jérémy Lefaure
2017-10-04 1:05 ` Steven Rostedt
2017-10-01 19:30 ` [PATCH 03/18] media: " Jérémy Lefaure
2017-10-02 10:34 ` Michael Ira Krufky
2017-10-01 19:30 ` [PATCH 04/18] IB/mlx5: Use ARRAY_SIZE Jérémy Lefaure
[not found] ` <20171001193101.8898-5-jeremy.lefaure-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
2017-10-02 4:38 ` Leon Romanovsky
2017-10-02 4:38 ` Leon Romanovsky
2017-10-01 19:30 ` [PATCH 05/18] net: use ARRAY_SIZE Jérémy Lefaure
2017-10-01 19:30 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure
2017-10-02 13:07 ` Andy Shevchenko
2017-10-02 13:07 ` [Intel-wired-lan] " Andy Shevchenko
2017-10-02 13:07 ` Andy Shevchenko
2017-10-02 13:07 ` Andy Shevchenko
2017-10-03 1:22 ` Jérémy Lefaure [this message]
2017-10-03 1:22 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure
2017-10-03 1:22 ` Jérémy Lefaure
2017-10-03 1:22 ` Jérémy Lefaure
2017-10-03 8:09 ` Andy Shevchenko
2017-10-03 8:09 ` [Intel-wired-lan] " Andy Shevchenko
2017-10-03 8:09 ` Andy Shevchenko
2017-10-03 8:09 ` Andy Shevchenko
2017-10-02 13:46 ` Kalle Valo
2017-10-02 13:46 ` [Intel-wired-lan] " Kalle Valo
2017-10-02 13:46 ` Kalle Valo
2017-10-02 13:46 ` Kalle Valo
2017-10-03 1:23 ` Jérémy Lefaure
2017-10-03 1:23 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure
2017-10-03 1:23 ` Jérémy Lefaure
2017-11-14 3:19 ` [PATCH v2] wireless: " Jérémy Lefaure
2017-12-08 13:20 ` [v2] " Kalle Valo
2017-11-14 3:24 ` [PATCH v2] net: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 06/18] drm: " Jérémy Lefaure
2017-10-02 7:43 ` Jani Nikula
2017-10-02 7:43 ` Jani Nikula
2017-10-02 8:27 ` Thierry Reding
2017-10-02 8:27 ` Thierry Reding
2017-10-01 19:30 ` [PATCH 07/18] scsi: bfa: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 08/18] ecryptfs: " Jérémy Lefaure
2017-10-14 1:31 ` Tyler Hicks
2017-10-01 19:30 ` [PATCH 09/18] nfsd: " Jérémy Lefaure
2017-10-02 11:03 ` Jeff Layton
2017-10-01 19:30 ` [PATCH 10/18] orangefs: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 11/18] dm space map metadata: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 12/18] x86: " Jérémy Lefaure
2017-10-19 14:18 ` [tip:x86/cleanups] x86: Use ARRAY_SIZE tip-bot for Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 13/18] tpm: use ARRAY_SIZE Jérémy Lefaure
2017-10-01 19:30 ` Jérémy Lefaure
2017-10-04 12:14 ` Jarkko Sakkinen
2017-10-04 12:14 ` Jarkko Sakkinen
2017-10-10 20:30 ` Jérémy Lefaure
2017-10-10 20:30 ` Jérémy Lefaure
2017-10-11 11:48 ` Jarkko Sakkinen
2017-10-11 11:48 ` Jarkko Sakkinen
2017-10-01 19:30 ` [PATCH 14/18] ipmi: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 15/18] acpi: " Jérémy Lefaure
2017-10-02 12:27 ` Rafael J. Wysocki
2017-10-02 12:27 ` [Devel] " Rafael J. Wysocki
2017-10-03 1:16 ` Jérémy Lefaure
2017-10-03 11:39 ` Rafael J. Wysocki
2017-10-03 11:39 ` [Devel] " Rafael J. Wysocki
2017-10-03 12:34 ` Colin Ian King
2017-10-03 12:34 ` Colin Ian King
2017-10-03 16:04 ` Rafael J. Wysocki
2017-10-03 16:04 ` Rafael J. Wysocki
2017-10-03 16:38 ` Moore, Robert
2017-10-03 16:38 ` Moore, Robert
2017-10-01 19:30 ` [PATCH 16/18] media: staging: atomisp: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 17/18] staging: rtl8723bs: " Jérémy Lefaure
2017-10-01 19:30 ` [PATCH 18/18] staging: rtlwifi: " Jérémy Lefaure
2017-10-01 22:01 ` [PATCH 00/18] use ARRAY_SIZE macro Tobin C. Harding
2017-10-01 22:01 ` [Intel-wired-lan] " Tobin C. Harding
2017-10-01 22:01 ` Tobin C. Harding
2017-10-01 22:01 ` Tobin C. Harding
2017-10-02 0:52 ` Jérémy Lefaure
2017-10-02 0:52 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure
2017-10-02 0:52 ` Jérémy Lefaure
2017-10-02 0:52 ` Jérémy Lefaure
2017-10-02 0:52 ` Jérémy Lefaure
2017-10-02 5:35 ` Greg KH
2017-10-02 5:35 ` [Intel-wired-lan] " Greg KH
2017-10-02 5:35 ` Greg KH
2017-10-02 5:35 ` Greg KH
2017-10-02 19:22 ` J. Bruce Fields
2017-10-02 19:22 ` [Intel-wired-lan] " J. Bruce Fields
2017-10-02 19:22 ` J. Bruce Fields
2017-10-02 19:22 ` J. Bruce Fields
2017-10-03 1:33 ` Jérémy Lefaure
2017-10-03 1:33 ` Jérémy Lefaure
2017-10-03 1:33 ` [Intel-wired-lan] " =?unknown-8bit?q?J=C3=A9r=C3=A9my?= Lefaure
2017-10-03 1:33 ` Jérémy Lefaure
2017-10-03 1:33 ` Jérémy Lefaure
2017-10-03 1:33 ` Jérémy Lefaure
2017-10-05 17:57 ` J. Bruce Fields
2017-10-05 17:57 ` [Intel-wired-lan] " J. Bruce Fields
2017-10-05 17:57 ` J. Bruce Fields
2017-10-05 17:57 ` J. Bruce Fields
2017-10-02 16:37 ` Mauro Carvalho Chehab
2017-10-02 16:37 ` [Intel-wired-lan] " Mauro Carvalho Chehab
2017-10-02 16:37 ` Mauro Carvalho Chehab
2017-10-02 16:37 ` Mauro Carvalho Chehab
2017-10-02 17:05 ` Zhi Wang
2017-10-02 17:05 ` [Intel-wired-lan] [Intel-gfx] " Zhi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171002212214.30d7013a@blatinox-laptop.localdomain \
--to=jeremy.lefaure@lse.epita.fr \
--cc=Larry.Finger@lwfinger.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andy.shevchenko@gmail.com \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chaoming_li@realsil.com.cn \
--cc=chi-hsien.lin@cypress.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@broadcom.com \
--cc=somnath.kotur@broadcom.com \
--cc=sriharsha.basavapatna@broadcom.com \
--cc=wright.feng@cypress.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.