From: Byungchul Park <byungchul.park@lge.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "mingo@kernel.org" <mingo@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amir73il@gmail.com" <amir73il@gmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"oleg@redhat.com" <oleg@redhat.com>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"johannes.berg@intel.com" <johannes.berg@intel.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"idryomov@gmail.com" <idryomov@gmail.com>,
"tj@kernel.org" <tj@kernel.org>,
"kernel-team@lge.com" <kernel-team@lge.com>,
"david@fromorbit.com" <david@fromorbit.com>
Subject: Re: Fix false positive by LOCKDEP_CROSSRELEASE
Date: Thu, 19 Oct 2017 10:57:06 +0900 [thread overview]
Message-ID: <20171019015705.GD32368@X58A-UD3R> (raw)
In-Reply-To: <1508336995.2923.2.camel@wdc.com>
On Wed, Oct 18, 2017 at 02:29:56PM +0000, Bart Van Assche wrote:
> On Wed, 2017-10-18 at 18:38 +0900, Byungchul Park wrote:
> > Several false positives were reported, so I tried to fix them.
> >
> > It would be appreciated if you tell me if it works as expected, or let
> > me know your opinion.
>
> What I have been wondering about is whether the crosslock checking makes
> sense from a conceptual point of view. I tried to find documentation for the
> crosslock checking in Documentation/locking/lockdep-design.txt but
> couldn't find a description of the crosslock checking. Shouldn't it be
> documented somewhere what the crosslock checks do and what the theory is
> behind these checks?
Documentation/locking/crossrelease.txt would be helpful.
WARNING: multiple messages have this Message-ID (diff)
From: Byungchul Park <byungchul.park@lge.com>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "mingo@kernel.org" <mingo@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amir73il@gmail.com" <amir73il@gmail.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"oleg@redhat.com" <oleg@redhat.com>,
"darrick.wong@oracle.com" <darrick.wong@oracle.com>,
"johannes.berg@intel.com" <johannes.berg@intel.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"idryomov@gmail.com" <idryomov@gmail.com>,
"tj@kernel.org" <tj@kernel.org>,
"kernel-team@lge.com" <kernel-team@lge.com>,
"david@fromorbit.com" <david@fromorbit.com>
Subject: Re: Fix false positive by LOCKDEP_CROSSRELEASE
Date: Thu, 19 Oct 2017 10:57:06 +0900 [thread overview]
Message-ID: <20171019015705.GD32368@X58A-UD3R> (raw)
In-Reply-To: <1508336995.2923.2.camel@wdc.com>
On Wed, Oct 18, 2017 at 02:29:56PM +0000, Bart Van Assche wrote:
> On Wed, 2017-10-18 at 18:38 +0900, Byungchul Park wrote:
> > Several false positives were reported, so I tried to fix them.
> >
> > It would be appreciated if you tell me if it works as expected, or let
> > me know your opinion.
>
> What I have been wondering about is whether the crosslock checking makes
> sense from a conceptual point of view. I tried to find documentation for the
> crosslock checking in Documentation/locking/lockdep-design.txt but
> couldn't find a description of the crosslock checking. Shouldn't it be
> documented somewhere what the crosslock checks do and what the theory is
> behind these checks?
Documentation/locking/crossrelease.txt would be helpful.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-19 1:57 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 9:38 Fix false positive by LOCKDEP_CROSSRELEASE Byungchul Park
2017-10-18 9:38 ` Byungchul Park
2017-10-18 9:38 ` [RESEND PATCH 1/3] completion: Add support for initializing completion with lockdep_map Byungchul Park
2017-10-18 9:38 ` Byungchul Park
2017-10-19 23:24 ` Bart Van Assche
2017-10-19 23:24 ` Bart Van Assche
2017-10-20 6:14 ` Byungchul Park
2017-10-20 6:14 ` Byungchul Park
2017-10-20 6:34 ` Thomas Gleixner
2017-10-20 6:34 ` Thomas Gleixner
2017-10-20 19:58 ` Bart Van Assche
2017-10-20 19:58 ` Bart Van Assche
2017-10-20 19:58 ` Bart Van Assche
2017-10-21 2:23 ` Byungchul Park
2017-10-21 2:23 ` Byungchul Park
2017-10-22 14:34 ` Bart Van Assche
2017-10-22 14:34 ` Bart Van Assche
2017-10-23 2:08 ` Byungchul Park
2017-10-23 2:08 ` Byungchul Park
2017-10-25 7:07 ` Bart Van Assche
2017-10-25 7:07 ` Bart Van Assche
2017-10-25 11:49 ` Byungchul Park
2017-10-25 11:49 ` Byungchul Park
2017-10-18 9:38 ` [RESEND PATCH 2/3] lockdep: Remove unnecessary acquisitions wrt workqueue flush Byungchul Park
2017-10-18 9:38 ` Byungchul Park
2017-10-18 9:38 ` [RESEND PATCH 3/3] lockdep: Assign a lock_class per gendisk used for wait_for_completion() Byungchul Park
2017-10-18 9:38 ` Byungchul Park
2017-10-18 9:59 ` Ingo Molnar
2017-10-18 9:59 ` Ingo Molnar
2017-10-19 1:57 ` Byungchul Park
2017-10-19 1:57 ` Byungchul Park
2017-10-18 14:29 ` Fix false positive by LOCKDEP_CROSSRELEASE Bart Van Assche
2017-10-18 14:29 ` Bart Van Assche
2017-10-19 1:57 ` Byungchul Park [this message]
2017-10-19 1:57 ` Byungchul Park
2017-10-19 14:52 ` Bart Van Assche
2017-10-19 14:52 ` Bart Van Assche
2017-10-19 14:52 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019015705.GD32368@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=Bart.VanAssche@wdc.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=idryomov@gmail.com \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.