From: Brian Norris <briannorris@chromium.org> To: Kalle Valo <kvalo@qca.qualcomm.com> Cc: Ryan Hsu <ryanhsu@qti.qualcomm.com>, Grant Grundler <grundler@chromium.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>, Arnd Bergmann <arnd@arndb.de> Subject: Re: ath10k: fix core PCI suspend when WoWLAN is supported but disabled Date: Thu, 19 Oct 2017 10:12:25 -0700 [thread overview] Message-ID: <20171019171224.GA46096@google.com> (raw) In-Reply-To: <87vajbgqcz.fsf@kamboji.qca.qualcomm.com> + Arnd On Thu, Oct 19, 2017 at 02:32:45PM +0000, Kalle Valo wrote: > Kalle Valo <kvalo@qca.qualcomm.com> writes: > > > Brian Norris <briannorris@chromium.org> wrote: > > > >> For devices where the FW supports WoWLAN but user-space has not > >> configured it, we don't do any PCI-specific suspend/resume operations, > >> because mac80211 doesn't call drv_suspend() when !wowlan. This has > >> particularly bad effects for some platforms, because we don't stop the > >> power-save timer, and if this timer goes off after the PCI controller > >> has suspended the link, Bad Things will happen. > >> > >> Commit 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > >> got some of this right, in that it understood there was a problem on > >> non-WoWLAN firmware. But it forgot the $subject case. > >> > >> Fix this by moving all the PCI driver suspend/resume logic exclusively > >> into the driver PM hooks. This shouldn't affect WoWLAN support much > >> (this just gets executed later on). > >> > >> I would just as well kill the entirety of ath10k_hif_suspend(), as it's > >> not even implemented on the USB or SDIO drivers. I expect that we don't > >> need the callback, except to return "supported" (i.e., 0) or "not > >> supported" (i.e., -EOPNOTSUPP). > >> > >> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > >> Fixes: 77258d409ce4 ("ath10k: enable pci soc powersaving") > >> Signed-off-by: Brian Norris <briannorris@chromium.org> > >> Cc: Ryan Hsu <ryanhsu@qti.qualcomm.com> > >> Cc: Kalle Valo <kvalo@qca.qualcomm.com> > >> Cc: Michal Kazior <michal.kazior@tieto.com> > >> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> > > > > Patch applied to ath-next branch of ath.git, thanks. > > > > 96378bd2c6cd ath10k: fix core PCI suspend when WoWLAN is supported but disabled > > Kbuild found a build problem, I suspect it's caused by this patch: Actually, it's the interaction of this patch and Arnd's patch: 6af1de2e4ec4 ath10k: mark PM functions as __maybe_unused I see that's now in these branches: ath/ath-current ath/ath-qca ath/master ath/master-pending wireless-drivers-next/master wireless-drivers-next/pending Whereas mine got applied to: ath/ath-next So technically, the problem is in your merge here :) 096ad2a15fd8 Merge branch 'ath-next' > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit > declaration of function 'ath10k_pci_suspend' > [-Werror=implicit-function-declaration] > > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit > declaration of function 'ath10k_pci_resume' > [-Werror=implicit-function-declaration] > > http://lists.infradead.org/pipermail/ath10k/2017-October/010269.html > > The .config.gz there doesn't have CONFIG_PM set, maybe that's the > problem? Yes, indirectly that's also the problem. The solution would seem to be either to kill the #ifdefs around ath10k_pci_{suspend,resume}() and friends (and use __maybe_unused instead, to further extend Arnd's patch), or else revert Arnd's stuff and go with CONFIG_PM_SLEEP everywhere, which would resolve the original warning (promoted to error) that Arnd was resolving. I can send out one of these if you'd like. Brian
WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <briannorris@chromium.org> To: Kalle Valo <kvalo@qca.qualcomm.com> Cc: Ryan Hsu <ryanhsu@qti.qualcomm.com>, Arnd Bergmann <arnd@arndb.de>, Grant Grundler <grundler@chromium.org>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: ath10k: fix core PCI suspend when WoWLAN is supported but disabled Date: Thu, 19 Oct 2017 10:12:25 -0700 [thread overview] Message-ID: <20171019171224.GA46096@google.com> (raw) In-Reply-To: <87vajbgqcz.fsf@kamboji.qca.qualcomm.com> + Arnd On Thu, Oct 19, 2017 at 02:32:45PM +0000, Kalle Valo wrote: > Kalle Valo <kvalo@qca.qualcomm.com> writes: > > > Brian Norris <briannorris@chromium.org> wrote: > > > >> For devices where the FW supports WoWLAN but user-space has not > >> configured it, we don't do any PCI-specific suspend/resume operations, > >> because mac80211 doesn't call drv_suspend() when !wowlan. This has > >> particularly bad effects for some platforms, because we don't stop the > >> power-save timer, and if this timer goes off after the PCI controller > >> has suspended the link, Bad Things will happen. > >> > >> Commit 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > >> got some of this right, in that it understood there was a problem on > >> non-WoWLAN firmware. But it forgot the $subject case. > >> > >> Fix this by moving all the PCI driver suspend/resume logic exclusively > >> into the driver PM hooks. This shouldn't affect WoWLAN support much > >> (this just gets executed later on). > >> > >> I would just as well kill the entirety of ath10k_hif_suspend(), as it's > >> not even implemented on the USB or SDIO drivers. I expect that we don't > >> need the callback, except to return "supported" (i.e., 0) or "not > >> supported" (i.e., -EOPNOTSUPP). > >> > >> Fixes: 32faa3f0ee50 ("ath10k: add the PCI PM core suspend/resume ops") > >> Fixes: 77258d409ce4 ("ath10k: enable pci soc powersaving") > >> Signed-off-by: Brian Norris <briannorris@chromium.org> > >> Cc: Ryan Hsu <ryanhsu@qti.qualcomm.com> > >> Cc: Kalle Valo <kvalo@qca.qualcomm.com> > >> Cc: Michal Kazior <michal.kazior@tieto.com> > >> Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> > > > > Patch applied to ath-next branch of ath.git, thanks. > > > > 96378bd2c6cd ath10k: fix core PCI suspend when WoWLAN is supported but disabled > > Kbuild found a build problem, I suspect it's caused by this patch: Actually, it's the interaction of this patch and Arnd's patch: 6af1de2e4ec4 ath10k: mark PM functions as __maybe_unused I see that's now in these branches: ath/ath-current ath/ath-qca ath/master ath/master-pending wireless-drivers-next/master wireless-drivers-next/pending Whereas mine got applied to: ath/ath-next So technically, the problem is in your merge here :) 096ad2a15fd8 Merge branch 'ath-next' > drivers/net/wireless/ath/ath10k/pci.c:3416:8: error: implicit > declaration of function 'ath10k_pci_suspend' > [-Werror=implicit-function-declaration] > > drivers/net/wireless/ath/ath10k/pci.c:3428:8: error: implicit > declaration of function 'ath10k_pci_resume' > [-Werror=implicit-function-declaration] > > http://lists.infradead.org/pipermail/ath10k/2017-October/010269.html > > The .config.gz there doesn't have CONFIG_PM set, maybe that's the > problem? Yes, indirectly that's also the problem. The solution would seem to be either to kill the #ifdefs around ath10k_pci_{suspend,resume}() and friends (and use __maybe_unused instead, to further extend Arnd's patch), or else revert Arnd's stuff and go with CONFIG_PM_SLEEP everywhere, which would resolve the original warning (promoted to error) that Arnd was resolving. I can send out one of these if you'd like. Brian _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2017-10-19 17:12 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-19 23:24 [PATCH] ath10k: fix core PCI suspend when WoWLAN is supported but disabled Brian Norris 2017-09-19 23:24 ` Brian Norris 2017-10-12 0:38 ` Brian Norris 2017-10-12 0:38 ` Brian Norris 2017-10-12 0:43 ` Adrian Chadd 2017-10-12 0:43 ` Adrian Chadd 2017-10-12 3:58 ` Kalle Valo 2017-10-12 3:58 ` Kalle Valo 2017-10-12 3:58 ` Kalle Valo 2017-10-13 11:37 ` Kalle Valo 2017-10-13 11:37 ` Kalle Valo 2017-10-19 14:32 ` Kalle Valo 2017-10-19 14:32 ` Kalle Valo 2017-10-19 14:32 ` Kalle Valo 2017-10-19 17:12 ` Brian Norris [this message] 2017-10-19 17:12 ` Brian Norris 2017-10-19 18:45 ` [PATCH] ath10k: fix build errors with !CONFIG_PM Brian Norris 2017-10-19 18:45 ` Brian Norris 2017-10-20 6:29 ` Kalle Valo 2017-10-20 6:29 ` Kalle Valo 2017-10-20 6:29 ` Kalle Valo 2017-10-27 13:44 ` Kalle Valo 2017-10-27 13:44 ` Kalle Valo 2017-10-20 6:24 ` ath10k: fix core PCI suspend when WoWLAN is supported but disabled Kalle Valo 2017-10-20 6:24 ` Kalle Valo 2017-10-20 6:24 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171019171224.GA46096@google.com \ --to=briannorris@chromium.org \ --cc=arnd@arndb.de \ --cc=ath10k@lists.infradead.org \ --cc=grundler@chromium.org \ --cc=kvalo@qca.qualcomm.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=ryanhsu@qti.qualcomm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.