From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> To: mst@redhat.com, wei.w.wang@intel.com Cc: mhocko@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v1 2/3] virtio-balloon: deflate up to oom_pages on OOM Date: Sun, 22 Oct 2017 13:11:13 +0900 [thread overview] Message-ID: <201710221311.FFI17148.VStOJQLHOFFMOF@I-love.SAKURA.ne.jp> (raw) In-Reply-To: <20171022062119-mutt-send-email-mst@kernel.org> Michael S. Tsirkin wrote: > On Fri, Oct 20, 2017 at 07:54:25PM +0800, Wei Wang wrote: > > The current implementation only deflates 256 pages even when a user > > specifies more than that via the oom_pages module param. This patch > > enables the deflating of up to oom_pages pages if there are enough > > inflated pages. > > This seems reasonable. Does this by itself help? At least > > - num_freed_pages = leak_balloon(vb, oom_pages); > > + > > + /* Don't deflate more than the number of inflated pages */ > > + while (npages && atomic64_read(&vb->num_pages)) > > + npages -= leak_balloon(vb, npages); don't we need to abort if leak_balloon() returned 0 for some reason?
WARNING: multiple messages have this Message-ID (diff)
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> To: mst@redhat.com, wei.w.wang@intel.com Cc: mhocko@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v1 2/3] virtio-balloon: deflate up to oom_pages on OOM Date: Sun, 22 Oct 2017 13:11:13 +0900 [thread overview] Message-ID: <201710221311.FFI17148.VStOJQLHOFFMOF@I-love.SAKURA.ne.jp> (raw) In-Reply-To: <20171022062119-mutt-send-email-mst@kernel.org> Michael S. Tsirkin wrote: > On Fri, Oct 20, 2017 at 07:54:25PM +0800, Wei Wang wrote: > > The current implementation only deflates 256 pages even when a user > > specifies more than that via the oom_pages module param. This patch > > enables the deflating of up to oom_pages pages if there are enough > > inflated pages. > > This seems reasonable. Does this by itself help? At least > > - num_freed_pages = leak_balloon(vb, oom_pages); > > + > > + /* Don't deflate more than the number of inflated pages */ > > + while (npages && atomic64_read(&vb->num_pages)) > > + npages -= leak_balloon(vb, npages); don't we need to abort if leak_balloon() returned 0 for some reason? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-10-22 4:11 UTC|newest] Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-20 11:54 [PATCH v1 0/3] Virtio-balloon Improvement Wei Wang 2017-10-20 11:54 ` Wei Wang 2017-10-20 11:54 ` [PATCH v1 1/3] virtio-balloon: replace the coarse-grained balloon_lock Wei Wang 2017-10-20 11:54 ` Wei Wang 2017-10-22 5:20 ` Tetsuo Handa 2017-10-22 5:20 ` Tetsuo Handa 2017-10-22 5:20 ` Tetsuo Handa 2017-10-22 11:24 ` Wei Wang 2017-10-22 11:24 ` Wei Wang 2017-10-22 11:24 ` Wei Wang 2017-10-22 11:50 ` Tetsuo Handa 2017-10-22 11:50 ` Tetsuo Handa 2017-10-24 1:46 ` Wei Wang 2017-10-24 1:46 ` Wei Wang 2017-10-24 1:46 ` Wei Wang 2017-10-22 11:50 ` Tetsuo Handa 2017-10-20 11:54 ` Wei Wang 2017-10-20 11:54 ` [PATCH v1 2/3] virtio-balloon: deflate up to oom_pages on OOM Wei Wang 2017-10-20 11:54 ` Wei Wang 2017-10-20 11:54 ` Wei Wang 2017-10-22 3:21 ` Michael S. Tsirkin 2017-10-22 3:21 ` Michael S. Tsirkin 2017-10-22 3:21 ` Michael S. Tsirkin 2017-10-22 4:11 ` Tetsuo Handa 2017-10-22 4:11 ` Tetsuo Handa [this message] 2017-10-22 4:11 ` Tetsuo Handa 2017-10-22 11:31 ` Wei Wang 2017-10-22 11:31 ` Wei Wang 2017-10-22 11:31 ` Wei Wang 2017-10-20 11:54 ` [PATCH v1 3/3] virtio-balloon: stop inflating when OOM occurs Wei Wang 2017-10-20 11:54 ` Wei Wang 2017-10-22 17:13 ` Michael S. Tsirkin 2017-10-22 17:13 ` Michael S. Tsirkin 2017-10-22 17:13 ` Michael S. Tsirkin 2017-10-24 1:58 ` Wei Wang 2017-10-24 1:58 ` Wei Wang 2017-10-24 1:58 ` Wei Wang 2017-10-20 11:54 ` Wei Wang 2017-10-22 3:19 ` [PATCH v1 0/3] Virtio-balloon Improvement Michael S. Tsirkin 2017-10-22 3:19 ` Michael S. Tsirkin 2017-10-22 3:19 ` Michael S. Tsirkin 2017-10-22 11:19 ` Wei Wang 2017-10-22 11:19 ` Wei Wang 2017-10-22 11:19 ` Wei Wang 2017-11-03 8:35 ` Wei Wang 2017-11-03 8:35 ` Wei Wang 2017-11-03 8:35 ` Wei Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201710221311.FFI17148.VStOJQLHOFFMOF@I-love.SAKURA.ne.jp \ --to=penguin-kernel@i-love.sakura.ne.jp \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@kernel.org \ --cc=mst@redhat.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=wei.w.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.