All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 2/2] kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib
Date: Sun, 5 Nov 2017 09:39:28 +0100	[thread overview]
Message-ID: <20171105083928.GA28930@ravnborg.org> (raw)
In-Reply-To: <1509859853-27473-3-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro

Nice cleanup - looks good.

> --- a/arch/mips/boot/dts/brcm/Makefile
> +++ b/arch/mips/boot/dts/brcm/Makefile
> @@ -37,5 +37,3 @@ obj-y				+= $(patsubst %.dtb, %.dtb.o, $(dtb-y))
>  
>  # Force kbuild to make empty built-in.o if necessary
>  obj-				+= dummy.o

I noticed a few of these dummy.o in the patched files.
Looks like another candidate for cleaning up - in a separate patch.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib
Date: Sun, 5 Nov 2017 09:39:28 +0100	[thread overview]
Message-ID: <20171105083928.GA28930@ravnborg.org> (raw)
In-Reply-To: <1509859853-27473-3-git-send-email-yamada.masahiro@socionext.com>

Hi Masahiro

Nice cleanup - looks good.

> --- a/arch/mips/boot/dts/brcm/Makefile
> +++ b/arch/mips/boot/dts/brcm/Makefile
> @@ -37,5 +37,3 @@ obj-y				+= $(patsubst %.dtb, %.dtb.o, $(dtb-y))
>  
>  # Force kbuild to make empty built-in.o if necessary
>  obj-				+= dummy.o

I noticed a few of these dummy.o in the patched files.
Looks like another candidate for cleaning up - in a separate patch.

	Sam

  reply	other threads:[~2017-11-05  8:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-05  5:30 [PATCH 0/2] kbuild: move dtb-y and CONFIG_OF_ALL_DTBS to Kbuild core to fix some issues Masahiro Yamada
2017-11-05  5:30 ` Masahiro Yamada
2017-11-05  5:30 ` Masahiro Yamada
2017-11-05  5:30 ` [PATCH 1/2] MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry Masahiro Yamada
2017-11-05  5:30   ` Masahiro Yamada
2017-11-05 14:11   ` Masahiro Yamada
2017-11-05 14:11     ` Masahiro Yamada
2017-11-06 10:41     ` James Hogan
2017-11-06 10:41       ` James Hogan
2017-11-06 10:41       ` James Hogan
2017-11-06 11:00       ` Masahiro Yamada
2017-11-06 11:00         ` Masahiro Yamada
2017-11-08 16:51         ` Rob Herring
2017-11-08 16:51           ` Rob Herring
2017-11-09  0:11           ` Masahiro Yamada
2017-11-09  0:11             ` Masahiro Yamada
2017-11-09  0:38             ` Masahiro Yamada
2017-11-09  0:38               ` Masahiro Yamada
2017-11-09  0:38               ` Masahiro Yamada
2017-11-09 23:06               ` Rob Herring
2017-11-09 23:06                 ` Rob Herring
2017-11-09 23:06                 ` Rob Herring
2017-11-09  8:06         ` James Hogan
2017-11-09  8:06           ` James Hogan
2017-11-09  8:06           ` James Hogan
2017-11-09  8:06           ` James Hogan
2017-11-05  5:30 ` [PATCH 2/2] kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib Masahiro Yamada
2017-11-05  5:30   ` Masahiro Yamada
2017-11-05  8:39   ` Sam Ravnborg [this message]
2017-11-05  8:39     ` Sam Ravnborg
2017-11-05 13:49   ` Arnd Bergmann
2017-11-05 13:49     ` Arnd Bergmann
2017-11-05 13:49     ` Arnd Bergmann
2017-11-08 17:23     ` Rob Herring
2017-11-08 17:23       ` Rob Herring
2017-11-08 17:23       ` Rob Herring
     [not found]   ` <CAAG0J98rRS+Sw8k_87gmTqYdNWByk=9zWVbWnC348vd63H4N9w@mail.gmail.com>
2017-11-09 12:19     ` James Hogan
2017-11-09 12:19       ` James Hogan
2017-11-09 12:19       ` James Hogan
2017-11-09 12:23       ` Masahiro Yamada
2017-11-09 12:23         ` Masahiro Yamada
2017-11-09 12:23         ` Masahiro Yamada
2017-11-09 20:34         ` Rob Herring
2017-11-09 20:34           ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105083928.GA28930@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=michal.lkml@markovi.net \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robh+dt@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.