From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Chris Zhong <zyw@rock-chips.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Roger Quadros <rogerq@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, heiko@sntech.de,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac
Date: Tue, 7 Nov 2017 16:59:47 +0100 [thread overview]
Message-ID: <20171107155947.GC18410@lunn.ch> (raw)
In-Reply-To: <e6f2393e-cb3b-9006-d0f5-6b30fd2a5192@mentor.com>
> As a side question, which is mainly addressed to Sergei and Roger,
> I don't quite understand why PHY properties were initially added to
> MAC/MDIO bus device tree nodes, in my opinion they must be moved under
> PHY device tree nodes.
If you look at the implementation, they are not actually PHY
properties. They are MDIO properties. It is the MDIO driver using them
to perform an 'MDIO bus reset'. The property names are wrong.
The device tree structure could be better. It mixes the MAC and the
MDIO properties in the same node. It would of been better to have
separate nodes.
The MDIO core now has equivalent functionality. So yes, it would be
better to use the generic MDIO properties, not these driver
properties.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Vladimir Zapolskiy
<vladimir_zapolskiy-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
Cc: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac
Date: Tue, 7 Nov 2017 16:59:47 +0100 [thread overview]
Message-ID: <20171107155947.GC18410@lunn.ch> (raw)
In-Reply-To: <e6f2393e-cb3b-9006-d0f5-6b30fd2a5192-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>
> As a side question, which is mainly addressed to Sergei and Roger,
> I don't quite understand why PHY properties were initially added to
> MAC/MDIO bus device tree nodes, in my opinion they must be moved under
> PHY device tree nodes.
If you look at the implementation, they are not actually PHY
properties. They are MDIO properties. It is the MDIO driver using them
to perform an 'MDIO bus reset'. The property names are wrong.
The device tree structure could be better. It mixes the MAC and the
MDIO properties in the same node. It would of been better to have
separate nodes.
The MDIO core now has equivalent functionality. So yes, it would be
better to use the generic MDIO properties, not these driver
properties.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac
Date: Tue, 7 Nov 2017 16:59:47 +0100 [thread overview]
Message-ID: <20171107155947.GC18410@lunn.ch> (raw)
In-Reply-To: <e6f2393e-cb3b-9006-d0f5-6b30fd2a5192@mentor.com>
> As a side question, which is mainly addressed to Sergei and Roger,
> I don't quite understand why PHY properties were initially added to
> MAC/MDIO bus device tree nodes, in my opinion they must be moved under
> PHY device tree nodes.
If you look at the implementation, they are not actually PHY
properties. They are MDIO properties. It is the MDIO driver using them
to perform an 'MDIO bus reset'. The property names are wrong.
The device tree structure could be better. It mixes the MAC and the
MDIO properties in the same node. It would of been better to have
separate nodes.
The MDIO core now has equivalent functionality. So yes, it would be
better to use the generic MDIO properties, not these driver
properties.
Andrew
next prev parent reply other threads:[~2017-11-07 16:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 2:49 [PATCH] ARM: dts: add phy-reset property for rk3066a-rayeager emac Chris Zhong
2017-11-07 2:49 ` Chris Zhong
2017-11-07 7:54 ` Vladimir Zapolskiy
2017-11-07 7:54 ` Vladimir Zapolskiy
2017-11-07 7:54 ` Vladimir Zapolskiy
2017-11-07 9:51 ` Chris Zhong
2017-11-07 9:51 ` Chris Zhong
2017-11-07 18:26 ` Florian Fainelli
2017-11-07 18:26 ` Florian Fainelli
2017-11-07 18:26 ` Florian Fainelli
2017-11-08 9:49 ` Chris Zhong
2017-11-08 9:49 ` Chris Zhong
2017-11-09 8:28 ` Roger Quadros
2017-11-09 8:28 ` Roger Quadros
2017-11-09 8:28 ` Roger Quadros
2017-11-09 8:28 ` Roger Quadros
2017-11-09 8:40 ` Roger Quadros
2017-11-09 8:40 ` Roger Quadros
2017-11-09 8:40 ` Roger Quadros
2017-11-09 8:40 ` Roger Quadros
2017-11-07 15:59 ` Andrew Lunn [this message]
2017-11-07 15:59 ` Andrew Lunn
2017-11-07 15:59 ` Andrew Lunn
2017-11-09 8:20 ` Roger Quadros
2017-11-09 8:20 ` Roger Quadros
2017-11-09 8:20 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107155947.GC18410@lunn.ch \
--to=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vladimir_zapolskiy@mentor.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.