From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: dmitry.torokhov@gmail.com, maxime.ripard@free-electrons.com,
wens@csie.org, mcuos.com@gmail.com, linux@roeck-us.net,
lee.jones@linaro.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking
Date: Mon, 20 Nov 2017 16:29:42 +0000 [thread overview]
Message-ID: <20171120162941.GD31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <987ac156e9590cbe2f667f9782b56515d7a991a4.1511194239.git.arvind.yadav.cs@gmail.com>
On Mon, Nov 20, 2017 at 09:56:21PM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
> Return keypad->irq insted of -ENXIO.
> changes in v3 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes ib v4 :
> Return -ENXIO insted of keypad->irq. Which was not correct in v3.
>
> drivers/input/keyboard/ep93xx_keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index f77b295..c6eb31a 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
> }
>
> keypad->irq = platform_get_irq(pdev, 0);
> - if (!keypad->irq) {
> + if (keypad->irq <= 0) {
> err = -ENXIO;
Still not right.
err = keypad->irq < 0 ? keypad->irq : -ENXIO;
would have the right effect.
However, I disagree with the idea of making platform_get_irq() return
an error if there is a zero irq specified as suggested in a previous
review - zero means "not present" and that is not necessarily an error -
it's up to the driver to decide whether it can proceed without an
interrupt, or whether it should error out on the probe function.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking
Date: Mon, 20 Nov 2017 16:29:42 +0000 [thread overview]
Message-ID: <20171120162941.GD31757@n2100.armlinux.org.uk> (raw)
In-Reply-To: <987ac156e9590cbe2f667f9782b56515d7a991a4.1511194239.git.arvind.yadav.cs@gmail.com>
On Mon, Nov 20, 2017 at 09:56:21PM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
> Return keypad->irq insted of -ENXIO.
> changes in v3 :
> Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid.
> changes ib v4 :
> Return -ENXIO insted of keypad->irq. Which was not correct in v3.
>
> drivers/input/keyboard/ep93xx_keypad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/ep93xx_keypad.c b/drivers/input/keyboard/ep93xx_keypad.c
> index f77b295..c6eb31a 100644
> --- a/drivers/input/keyboard/ep93xx_keypad.c
> +++ b/drivers/input/keyboard/ep93xx_keypad.c
> @@ -257,7 +257,7 @@ static int ep93xx_keypad_probe(struct platform_device *pdev)
> }
>
> keypad->irq = platform_get_irq(pdev, 0);
> - if (!keypad->irq) {
> + if (keypad->irq <= 0) {
> err = -ENXIO;
Still not right.
err = keypad->irq < 0 ? keypad->irq : -ENXIO;
would have the right effect.
However, I disagree with the idea of making platform_get_irq() return
an error if there is a zero irq specified as suggested in a previous
review - zero means "not present" and that is not necessarily an error -
it's up to the driver to decide whether it can proceed without an
interrupt, or whether it should error out on the probe function.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
next prev parent reply other threads:[~2017-11-20 16:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 16:26 [PATCH 01/10 v4] Input: ep93xx_keypad: Fix platform_get_irq's error checking Arvind Yadav
2017-11-20 16:26 ` Arvind Yadav
2017-11-20 16:29 ` Russell King - ARM Linux [this message]
2017-11-20 16:29 ` Russell King - ARM Linux
2017-11-20 16:48 ` Dmitry Torokhov
2017-11-20 16:48 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120162941.GD31757@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=arvind.yadav.cs@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=maxime.ripard@free-electrons.com \
--cc=mcuos.com@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.