All of lore.kernel.org
 help / color / mirror / Atom feed
From: Beniamino Galvani <b.galvani@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] i2c: meson: reduce timeout
Date: Sun, 26 Nov 2017 17:40:55 +0100	[thread overview]
Message-ID: <20171126164057.27728-3-b.galvani@gmail.com> (raw)
In-Reply-To: <20171126164057.27728-1-b.galvani@gmail.com>

The datasheet doesn't specify a suggested timeout and 500ms seems very
long: reduce it to 100ms.

Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
 drivers/i2c/meson_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/meson_i2c.c b/drivers/i2c/meson_i2c.c
index 2434d9ed53..84e1997c76 100644
--- a/drivers/i2c/meson_i2c.c
+++ b/drivers/i2c/meson_i2c.c
@@ -9,7 +9,7 @@
 #include <dm.h>
 #include <i2c.h>
 
-#define I2C_TIMEOUT_MS		500
+#define I2C_TIMEOUT_MS		100
 
 /* Control register fields */
 #define REG_CTRL_START		BIT(0)
-- 
2.14.3

WARNING: multiple messages have this Message-ID (diff)
From: b.galvani@gmail.com (Beniamino Galvani)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/4] i2c: meson: reduce timeout
Date: Sun, 26 Nov 2017 17:40:55 +0100	[thread overview]
Message-ID: <20171126164057.27728-3-b.galvani@gmail.com> (raw)
In-Reply-To: <20171126164057.27728-1-b.galvani@gmail.com>

The datasheet doesn't specify a suggested timeout and 500ms seems very
long: reduce it to 100ms.

Signed-off-by: Beniamino Galvani <b.galvani@gmail.com>
---
 drivers/i2c/meson_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/meson_i2c.c b/drivers/i2c/meson_i2c.c
index 2434d9ed53..84e1997c76 100644
--- a/drivers/i2c/meson_i2c.c
+++ b/drivers/i2c/meson_i2c.c
@@ -9,7 +9,7 @@
 #include <dm.h>
 #include <i2c.h>
 
-#define I2C_TIMEOUT_MS		500
+#define I2C_TIMEOUT_MS		100
 
 /* Control register fields */
 #define REG_CTRL_START		BIT(0)
-- 
2.14.3

  parent reply	other threads:[~2017-11-26 16:40 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 16:40 [U-Boot] [PATCH 0/4] meson i2c driver cleanups Beniamino Galvani
2017-11-26 16:40 ` Beniamino Galvani
2017-11-26 16:40 ` [U-Boot] [PATCH 1/4] i2c: meson: improve Kconfig description Beniamino Galvani
2017-11-26 16:40   ` Beniamino Galvani
2017-11-27 17:09   ` [U-Boot] " Simon Glass
2017-11-27 17:09     ` Simon Glass
2017-12-07  8:24   ` [U-Boot] " Heiko Schocher
2017-12-07  8:24     ` Heiko Schocher
2017-12-07 12:19   ` [U-Boot] " Heiko Schocher
2017-12-07 12:19     ` Heiko Schocher
2017-11-26 16:40 ` Beniamino Galvani [this message]
2017-11-26 16:40   ` [PATCH 2/4] i2c: meson: reduce timeout Beniamino Galvani
2017-11-27 17:09   ` [U-Boot] " Simon Glass
2017-11-27 17:09     ` Simon Glass
2017-12-07  8:24   ` [U-Boot] " Heiko Schocher
2017-12-07  8:24     ` Heiko Schocher
2017-12-07 12:19   ` [U-Boot] " Heiko Schocher
2017-12-07 12:19     ` Heiko Schocher
2017-11-26 16:40 ` [U-Boot] [PATCH 3/4] i2c: meson: fix return codes on error Beniamino Galvani
2017-11-26 16:40   ` Beniamino Galvani
2017-11-27 17:09   ` [U-Boot] " Simon Glass
2017-11-27 17:09     ` Simon Glass
2017-12-07  8:25   ` [U-Boot] " Heiko Schocher
2017-12-07  8:25     ` Heiko Schocher
2017-12-07 12:20   ` [U-Boot] " Heiko Schocher
2017-12-07 12:20     ` Heiko Schocher
2017-11-26 16:40 ` [U-Boot] [PATCH 4/4] i2c: meson: add some comments Beniamino Galvani
2017-11-26 16:40   ` Beniamino Galvani
2017-11-27 17:10   ` [U-Boot] " Simon Glass
2017-11-27 17:10     ` Simon Glass
2017-12-07  8:25   ` [U-Boot] " Heiko Schocher
2017-12-07  8:25     ` Heiko Schocher
2017-12-07 12:20   ` [U-Boot] " Heiko Schocher
2017-12-07 12:20     ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171126164057.27728-3-b.galvani@gmail.com \
    --to=b.galvani@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.