From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
alsa-devel@alsa-project.org, fabio.estevam@nxp.com,
timur@tabi.org, mail@maciej.szmigiero.name, caleb@crome.org,
lgirdwood@gmail.com
Subject: Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device
Date: Tue, 5 Dec 2017 13:04:46 +0000 [thread overview]
Message-ID: <20171205130446.GI11658@finisterre> (raw)
In-Reply-To: <1512420403-10164-2-git-send-email-nicoleotsuka@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 378 bytes --]
On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote:
> struct device is defined in system level header files any way.
> As long as fsl_ssi.h is included after those header files, it
> should be safe to remove this line.
It's better practice to either directly include those headers or have a
forward declaration like this, it means there's no way things can go
wrong.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: mail@maciej.szmigiero.name, timur@tabi.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, caleb@crome.org,
linux-kernel@vger.kernel.org, fabio.estevam@nxp.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device
Date: Tue, 5 Dec 2017 13:04:46 +0000 [thread overview]
Message-ID: <20171205130446.GI11658@finisterre> (raw)
In-Reply-To: <1512420403-10164-2-git-send-email-nicoleotsuka@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 378 bytes --]
On Mon, Dec 04, 2017 at 12:46:34PM -0800, Nicolin Chen wrote:
> struct device is defined in system level header files any way.
> As long as fsl_ssi.h is included after those header files, it
> should be safe to remove this line.
It's better practice to either directly include those headers or have a
forward declaration like this, it means there's no way things can go
wrong.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2017-12-05 13:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 20:46 [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level Nicolin Chen
2017-12-04 20:46 ` Nicolin Chen
2017-12-04 20:46 ` [PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device Nicolin Chen
2017-12-05 13:04 ` Mark Brown [this message]
2017-12-05 13:04 ` Mark Brown
2017-12-05 19:39 ` Nicolin Chen
2017-12-04 20:46 ` [PATCH 02/10] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi Nicolin Chen
2017-12-04 20:46 ` Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-04 20:46 ` [PATCH 03/10] ASoC: fsl_ssi: Cache pdev->dev pointer Nicolin Chen
2017-12-04 20:46 ` Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Cache pdev->dev pointer" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-04 20:46 ` [PATCH 04/10] ASoC: fsl_ssi: Refine all comments Nicolin Chen
2017-12-04 20:46 ` Nicolin Chen
2017-12-05 4:04 ` Timur Tabi
2017-12-05 4:36 ` Nicolin Chen
2017-12-04 20:46 ` [PATCH 05/10] ASoC: fsl_ssi: Rename registers and fields macros Nicolin Chen
2017-12-04 20:46 ` [PATCH 06/10] ASoC: fsl_ssi: Refine indentations and wrappings Nicolin Chen
2017-12-04 20:46 ` [PATCH 07/10] ASoC: fsl_ssi: Refine printk outputs Nicolin Chen
2017-12-19 11:00 ` Applied "ASoC: fsl_ssi: Refine printk outputs" to the asoc tree Mark Brown
2017-12-19 11:00 ` Mark Brown
2017-12-04 20:46 ` [PATCH 08/10] ASoC: fsl_ssi: Rename cpu_dai parameter to dai Nicolin Chen
2017-12-04 20:46 ` [PATCH 09/10] ASoC: fsl_ssi: Rename scr_val to scr Nicolin Chen
2017-12-04 20:46 ` [PATCH 10/10] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals Nicolin Chen
2017-12-05 13:01 ` [PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level Maciej S. Szmigiero
2017-12-05 13:01 ` Maciej S. Szmigiero
2017-12-05 19:33 ` Nicolin Chen
2017-12-05 19:33 ` Nicolin Chen
2017-12-06 1:01 ` Maciej S. Szmigiero
2017-12-06 1:23 ` Nicolin Chen
2017-12-12 23:32 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205130446.GI11658@finisterre \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mail@maciej.szmigiero.name \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.