From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jean Delvare <jdelvare@suse.de>,
Sean Wang <sean.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/7] soc: mediatek: Add USB wakeup driver
Date: Fri, 15 Dec 2017 14:55:50 -0600 [thread overview]
Message-ID: <20171215205550.dkiymkok6arheidg@rob-hp-laptop> (raw)
In-Reply-To: <1512809136-2779-2-git-send-email-chunfeng.yun@mediatek.com>
On Sat, Dec 09, 2017 at 04:45:30PM +0800, Chunfeng Yun wrote:
> This driver is used to support usb wakeup which is controlled by
> the glue layer between SSUSB and SPM. Usually the glue layer is put
> into a system controller, such as pericfg module, which is
> represented by a syscon node in DTS.
> Due to the glue layer may vary on different SoCs, it's useful to
> extract a separated driver to simplify usb controller drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/soc/mediatek/Kconfig | 8 +
> drivers/soc/mediatek/Makefile | 1 +
> drivers/soc/mediatek/mtk-usb-wakeup.c | 519 ++++++++++++++++++++++++++
> include/dt-bindings/soc/mediatek,usb-wakeup.h | 15 +
This belongs in the binding patch and that should come first.
> include/linux/soc/mediatek/usb-wakeup.h | 88 +++++
> 5 files changed, 631 insertions(+)
> create mode 100644 drivers/soc/mediatek/mtk-usb-wakeup.c
> create mode 100644 include/dt-bindings/soc/mediatek,usb-wakeup.h
> create mode 100644 include/linux/soc/mediatek/usb-wakeup.h
> +++ b/drivers/soc/mediatek/mtk-usb-wakeup.c
> @@ -0,0 +1,519 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0
This should be the first line of the file and use a // style comment.
[...]
> diff --git a/include/dt-bindings/soc/mediatek,usb-wakeup.h b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> new file mode 100644
> index 0000000..2461795
> --- /dev/null
> +++ b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0
ditto. Except headers use /* */ comments...
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Felipe Balbi
<felipe.balbi-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Matthias Brugger
<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mathias Nyman
<mathias.nyman-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
Jean Delvare <jdelvare-l3A5Bk7waGM@public.gmane.org>,
Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/7] soc: mediatek: Add USB wakeup driver
Date: Fri, 15 Dec 2017 14:55:50 -0600 [thread overview]
Message-ID: <20171215205550.dkiymkok6arheidg@rob-hp-laptop> (raw)
In-Reply-To: <1512809136-2779-2-git-send-email-chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
On Sat, Dec 09, 2017 at 04:45:30PM +0800, Chunfeng Yun wrote:
> This driver is used to support usb wakeup which is controlled by
> the glue layer between SSUSB and SPM. Usually the glue layer is put
> into a system controller, such as pericfg module, which is
> represented by a syscon node in DTS.
> Due to the glue layer may vary on different SoCs, it's useful to
> extract a separated driver to simplify usb controller drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/soc/mediatek/Kconfig | 8 +
> drivers/soc/mediatek/Makefile | 1 +
> drivers/soc/mediatek/mtk-usb-wakeup.c | 519 ++++++++++++++++++++++++++
> include/dt-bindings/soc/mediatek,usb-wakeup.h | 15 +
This belongs in the binding patch and that should come first.
> include/linux/soc/mediatek/usb-wakeup.h | 88 +++++
> 5 files changed, 631 insertions(+)
> create mode 100644 drivers/soc/mediatek/mtk-usb-wakeup.c
> create mode 100644 include/dt-bindings/soc/mediatek,usb-wakeup.h
> create mode 100644 include/linux/soc/mediatek/usb-wakeup.h
> +++ b/drivers/soc/mediatek/mtk-usb-wakeup.c
> @@ -0,0 +1,519 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> + *
> + * SPDX-License-Identifier: GPL-2.0
This should be the first line of the file and use a // style comment.
[...]
> diff --git a/include/dt-bindings/soc/mediatek,usb-wakeup.h b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> new file mode 100644
> index 0000000..2461795
> --- /dev/null
> +++ b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> + *
> + * SPDX-License-Identifier: GPL-2.0
ditto. Except headers use /* */ comments...
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Mark Rutland <mark.rutland@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jean Delvare <jdelvare@suse.de>,
Sean Wang <sean.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [1/7] soc: mediatek: Add USB wakeup driver
Date: Fri, 15 Dec 2017 14:55:50 -0600 [thread overview]
Message-ID: <20171215205550.dkiymkok6arheidg@rob-hp-laptop> (raw)
On Sat, Dec 09, 2017 at 04:45:30PM +0800, Chunfeng Yun wrote:
> This driver is used to support usb wakeup which is controlled by
> the glue layer between SSUSB and SPM. Usually the glue layer is put
> into a system controller, such as pericfg module, which is
> represented by a syscon node in DTS.
> Due to the glue layer may vary on different SoCs, it's useful to
> extract a separated driver to simplify usb controller drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/soc/mediatek/Kconfig | 8 +
> drivers/soc/mediatek/Makefile | 1 +
> drivers/soc/mediatek/mtk-usb-wakeup.c | 519 ++++++++++++++++++++++++++
> include/dt-bindings/soc/mediatek,usb-wakeup.h | 15 +
This belongs in the binding patch and that should come first.
> include/linux/soc/mediatek/usb-wakeup.h | 88 +++++
> 5 files changed, 631 insertions(+)
> create mode 100644 drivers/soc/mediatek/mtk-usb-wakeup.c
> create mode 100644 include/dt-bindings/soc/mediatek,usb-wakeup.h
> create mode 100644 include/linux/soc/mediatek/usb-wakeup.h
> +++ b/drivers/soc/mediatek/mtk-usb-wakeup.c
> @@ -0,0 +1,519 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0
This should be the first line of the file and use a // style comment.
[...]
> diff --git a/include/dt-bindings/soc/mediatek,usb-wakeup.h b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> new file mode 100644
> index 0000000..2461795
> --- /dev/null
> +++ b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0
ditto. Except headers use /* */ comments...
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] soc: mediatek: Add USB wakeup driver
Date: Fri, 15 Dec 2017 14:55:50 -0600 [thread overview]
Message-ID: <20171215205550.dkiymkok6arheidg@rob-hp-laptop> (raw)
In-Reply-To: <1512809136-2779-2-git-send-email-chunfeng.yun@mediatek.com>
On Sat, Dec 09, 2017 at 04:45:30PM +0800, Chunfeng Yun wrote:
> This driver is used to support usb wakeup which is controlled by
> the glue layer between SSUSB and SPM. Usually the glue layer is put
> into a system controller, such as pericfg module, which is
> represented by a syscon node in DTS.
> Due to the glue layer may vary on different SoCs, it's useful to
> extract a separated driver to simplify usb controller drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/soc/mediatek/Kconfig | 8 +
> drivers/soc/mediatek/Makefile | 1 +
> drivers/soc/mediatek/mtk-usb-wakeup.c | 519 ++++++++++++++++++++++++++
> include/dt-bindings/soc/mediatek,usb-wakeup.h | 15 +
This belongs in the binding patch and that should come first.
> include/linux/soc/mediatek/usb-wakeup.h | 88 +++++
> 5 files changed, 631 insertions(+)
> create mode 100644 drivers/soc/mediatek/mtk-usb-wakeup.c
> create mode 100644 include/dt-bindings/soc/mediatek,usb-wakeup.h
> create mode 100644 include/linux/soc/mediatek/usb-wakeup.h
> +++ b/drivers/soc/mediatek/mtk-usb-wakeup.c
> @@ -0,0 +1,519 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0
This should be the first line of the file and use a // style comment.
[...]
> diff --git a/include/dt-bindings/soc/mediatek,usb-wakeup.h b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> new file mode 100644
> index 0000000..2461795
> --- /dev/null
> +++ b/include/dt-bindings/soc/mediatek,usb-wakeup.h
> @@ -0,0 +1,15 @@
> +/*
> + * Copyright (c) 2017 MediaTek Inc.
> + * Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
> + *
> + * SPDX-License-Identifier: GPL-2.0
ditto. Except headers use /* */ comments...
next prev parent reply other threads:[~2017-12-15 20:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 8:45 [PATCH 0/7] Add USB remote wakeup driver Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [PATCH 1/7] soc: mediatek: Add USB " Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [1/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 1/7] " Chunfeng Yun
2017-12-15 20:55 ` Rob Herring [this message]
2017-12-15 20:55 ` Rob Herring
2017-12-15 20:55 ` [1/7] " Rob Herring
2017-12-15 20:55 ` [PATCH 1/7] " Rob Herring
2017-12-21 6:50 ` Chunfeng Yun
2017-12-21 6:50 ` Chunfeng Yun
2017-12-21 6:50 ` [1/7] " Chunfeng Yun
2017-12-21 6:50 ` [PATCH 1/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 2/7] dt-bindings: soc: mediatek: add bindings document for USB wakeup Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [2/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 2/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 3/7] usb: xhci-mtk: use APIs of mtu_wakeup to support remote wakeup Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [3/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 3/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 4/7] usb: mtu3: " Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [4/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 4/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 5/7] dt-bindings: usb: mtk-xhci: add USB wakeup properties Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [5/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 5/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 6/7] dt-bindings: usb: mtu3: " Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [6/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 6/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 7/7] arm64: dts: mt8173: add uwk node and remove unused usb property Chunfeng Yun
2017-12-09 8:45 ` Chunfeng Yun
2017-12-09 8:45 ` [7/7] " Chunfeng Yun
2017-12-09 8:45 ` [PATCH 7/7] " Chunfeng Yun
2017-12-15 20:55 ` [PATCH 0/7] Add USB remote wakeup driver Rob Herring
2017-12-15 20:55 ` Rob Herring
2017-12-15 20:55 ` Rob Herring
2017-12-21 6:48 ` Chunfeng Yun
2017-12-21 6:48 ` Chunfeng Yun
2017-12-21 6:48 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171215205550.dkiymkok6arheidg@rob-hp-laptop \
--to=robh@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.