From: Mike Snitzer <snitzer@redhat.com> To: axboe@kernel.dk, hch@lst.de, emilne@redhat.com, james.smart@broadcom.com Cc: hare@suse.de, Bart.VanAssche@wdc.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, dm-devel@redhat.com Subject: [for-4.16 PATCH 0/5] block, nvme, dm: allow DM multipath to use NVMe's error handler Date: Tue, 19 Dec 2017 16:05:41 -0500 [thread overview] Message-ID: <20171219210546.65928-1-snitzer@redhat.com> (raw) These patches enable DM multipath to work well on NVMe over Fabrics devices. Currently that implies CONFIG_NVME_MULTIPATH is _not_ set. But follow-on work will be to make it so that native NVMe multipath and DM multipath can be made to co-exist (e.g. blacklisting certain NVMe devices from being consumed by native NVMe multipath?) Patch 1 updates block core to formalize a recent construct that Christoph embeedded into NVMe core (and native NVMe multipath): callback into a bio-based driver from the blk-mq driver's .complete hook to blk_steal_bios() a request's bios. Patch 2 switches NVMe over to using the block infrastructure established by Patch 1. Patch 3 moves the nvme_req_needs_failover() from NVMe multipath to core. Which allow sstacked devices (like DM multipath) to make use of NVMe's enhanced error handling. Patch 4 updates DM multipath to also make use of the block infrastructure established by Patch 1. Patch 5 can be largely ignored.. but it illustrates that Patch 1 - 4 enable DM multipath to avoid extra DM endio callbacks. These patches have been developed ontop of numerous DM changes I've staged for 4.16, see: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.16 (which happens to include these 5 patches at the end, purely for interim linux-next coverage purposes as these changes land in the appropriate maintainer tree). I've updated the "mptest" DM multipath testsuite to provide NVMe test coverage (using NVMe fcloop), see: https://github.com/snitm/mptest The tree I've been testing includes all of 'dm-4.16' and all but one of the commits from 'nvme-4.16', see: https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git/log/?h=dm-4.16_nvme-4.16 (I've let James Smart know that commit a0b69cc8 causes "nvme connect" to not work on my fcloop testbed). Jens, provided review is favorable, I'd very much appreciate it you'd pick up patches 1 - 3 for 4.16. Thanks, Mike Mike Snitzer (5): block: establish request failover callback infrastructure nvme: use request's failover callback for multipath failover nvme: move nvme_req_needs_failover() from multipath to core dm mpath: use NVMe error handling to know when an error is retryable dm mpath: skip calls to end_io_bio if using NVMe bio-based and round-robin block/blk-core.c | 2 ++ block/blk-mq.c | 1 + drivers/md/dm-mpath.c | 68 ++++++++++++++++++++++++++++++++++++++++++- drivers/md/dm-rq.c | 8 ++--- drivers/md/dm.c | 7 +++-- drivers/nvme/host/core.c | 50 +++++++++++++++++++++++++++++-- drivers/nvme/host/multipath.c | 52 ++------------------------------- drivers/nvme/host/nvme.h | 14 --------- include/linux/blk_types.h | 4 +++ include/linux/blkdev.h | 6 ++++ include/linux/device-mapper.h | 6 ++++ 11 files changed, 145 insertions(+), 73 deletions(-) -- 2.15.0
WARNING: multiple messages have this Message-ID (diff)
From: snitzer@redhat.com (Mike Snitzer) Subject: [for-4.16 PATCH 0/5] block, nvme, dm: allow DM multipath to use NVMe's error handler Date: Tue, 19 Dec 2017 16:05:41 -0500 [thread overview] Message-ID: <20171219210546.65928-1-snitzer@redhat.com> (raw) These patches enable DM multipath to work well on NVMe over Fabrics devices. Currently that implies CONFIG_NVME_MULTIPATH is _not_ set. But follow-on work will be to make it so that native NVMe multipath and DM multipath can be made to co-exist (e.g. blacklisting certain NVMe devices from being consumed by native NVMe multipath?) Patch 1 updates block core to formalize a recent construct that Christoph embeedded into NVMe core (and native NVMe multipath): callback into a bio-based driver from the blk-mq driver's .complete hook to blk_steal_bios() a request's bios. Patch 2 switches NVMe over to using the block infrastructure established by Patch 1. Patch 3 moves the nvme_req_needs_failover() from NVMe multipath to core. Which allow sstacked devices (like DM multipath) to make use of NVMe's enhanced error handling. Patch 4 updates DM multipath to also make use of the block infrastructure established by Patch 1. Patch 5 can be largely ignored.. but it illustrates that Patch 1 - 4 enable DM multipath to avoid extra DM endio callbacks. These patches have been developed ontop of numerous DM changes I've staged for 4.16, see: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-4.16 (which happens to include these 5 patches at the end, purely for interim linux-next coverage purposes as these changes land in the appropriate maintainer tree). I've updated the "mptest" DM multipath testsuite to provide NVMe test coverage (using NVMe fcloop), see: https://github.com/snitm/mptest The tree I've been testing includes all of 'dm-4.16' and all but one of the commits from 'nvme-4.16', see: https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git/log/?h=dm-4.16_nvme-4.16 (I've let James Smart know that commit a0b69cc8 causes "nvme connect" to not work on my fcloop testbed). Jens, provided review is favorable, I'd very much appreciate it you'd pick up patches 1 - 3 for 4.16. Thanks, Mike Mike Snitzer (5): block: establish request failover callback infrastructure nvme: use request's failover callback for multipath failover nvme: move nvme_req_needs_failover() from multipath to core dm mpath: use NVMe error handling to know when an error is retryable dm mpath: skip calls to end_io_bio if using NVMe bio-based and round-robin block/blk-core.c | 2 ++ block/blk-mq.c | 1 + drivers/md/dm-mpath.c | 68 ++++++++++++++++++++++++++++++++++++++++++- drivers/md/dm-rq.c | 8 ++--- drivers/md/dm.c | 7 +++-- drivers/nvme/host/core.c | 50 +++++++++++++++++++++++++++++-- drivers/nvme/host/multipath.c | 52 ++------------------------------- drivers/nvme/host/nvme.h | 14 --------- include/linux/blk_types.h | 4 +++ include/linux/blkdev.h | 6 ++++ include/linux/device-mapper.h | 6 ++++ 11 files changed, 145 insertions(+), 73 deletions(-) -- 2.15.0
next reply other threads:[~2017-12-19 21:05 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-12-19 21:05 Mike Snitzer [this message] 2017-12-19 21:05 ` [for-4.16 PATCH 0/5] block, nvme, dm: allow DM multipath to use NVMe's error handler Mike Snitzer 2017-12-19 21:05 ` [for-4.16 PATCH 1/5] block: establish request failover callback infrastructure Mike Snitzer 2017-12-19 21:05 ` Mike Snitzer 2017-12-19 21:05 ` [for-4.16 PATCH 2/5] nvme: use request's failover callback for multipath failover Mike Snitzer 2017-12-19 21:05 ` Mike Snitzer 2017-12-19 21:05 ` [for-4.16 PATCH 3/5] nvme: move nvme_req_needs_failover() from multipath to core Mike Snitzer 2017-12-19 21:05 ` Mike Snitzer 2017-12-19 21:05 ` [for-4.16 PATCH 4/5] dm mpath: use NVMe error handling to know when an error is retryable Mike Snitzer 2017-12-19 21:05 ` Mike Snitzer 2017-12-20 16:58 ` Mike Snitzer 2017-12-20 16:58 ` Mike Snitzer 2017-12-20 20:33 ` [dm-devel] " Sagi Grimberg 2017-12-20 20:33 ` Sagi Grimberg 2017-12-19 21:05 ` [for-4.16 PATCH 5/5] dm mpath: skip calls to end_io_bio if using NVMe bio-based and round-robin Mike Snitzer 2017-12-19 21:05 ` Mike Snitzer 2017-12-22 18:02 ` [for-4.16 PATCH 0/5] block, nvme, dm: allow DM multipath to use NVMe's error handler Mike Snitzer 2017-12-22 18:02 ` Mike Snitzer 2017-12-26 20:51 ` Keith Busch 2017-12-26 20:51 ` Keith Busch 2017-12-27 2:42 ` Mike Snitzer 2017-12-27 2:42 ` Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171219210546.65928-1-snitzer@redhat.com \ --to=snitzer@redhat.com \ --cc=Bart.VanAssche@wdc.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=emilne@redhat.com \ --cc=hare@suse.de \ --cc=hch@lst.de \ --cc=james.smart@broadcom.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.