From: Matthew Wilcox <willy@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: jack@suse.cz, linux-nvdimm@lists.01.org,
Matthew Wilcox <mawilcox@microsoft.com>,
hch@lst.de, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH v4 11/18] fs, dax: introduce DEFINE_FSDAX_AOPS
Date: Tue, 26 Dec 2017 21:29:10 -0800 [thread overview]
Message-ID: <20171227052910.GE24828@bombadil.infradead.org> (raw)
In-Reply-To: <151407701943.38751.8997225433943672290.stgit@dwillia2-desk3.amr.corp.intel.com>
On Sat, Dec 23, 2017 at 04:56:59PM -0800, Dan Williams wrote:
> +int dax_set_page_dirty(struct page *page)
> +{
> + /*
> + * Unlike __set_page_dirty_no_writeback, dax does all dirty
> + * tracking in the radix in response to mkwrite faults.
Please stop saying "in the radix". I think you mean "in the page cache".
> +EXPORT_SYMBOL(dax_set_page_dirty);
> +EXPORT_SYMBOL(dax_direct_IO);
> +EXPORT_SYMBOL(dax_writepage);
> +EXPORT_SYMBOL(dax_readpage);
> +EXPORT_SYMBOL(dax_readpages);
> +EXPORT_SYMBOL(dax_write_begin);
> +EXPORT_SYMBOL(dax_write_end);
> +EXPORT_SYMBOL(dax_invalidatepage);
Exporting all these symbols to modules isn't exactly free. Are you sure it
doesn't make more sense to put tests for dax in the existing aops?
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, jack@suse.cz,
Matthew Wilcox <mawilcox@microsoft.com>,
linux-nvdimm@lists.01.org, linux-xfs@vger.kernel.org,
Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel@vger.kernel.org, ross.zwisler@linux.intel.com,
hch@lst.de
Subject: Re: [PATCH v4 11/18] fs, dax: introduce DEFINE_FSDAX_AOPS
Date: Tue, 26 Dec 2017 21:29:10 -0800 [thread overview]
Message-ID: <20171227052910.GE24828@bombadil.infradead.org> (raw)
In-Reply-To: <151407701943.38751.8997225433943672290.stgit@dwillia2-desk3.amr.corp.intel.com>
On Sat, Dec 23, 2017 at 04:56:59PM -0800, Dan Williams wrote:
> +int dax_set_page_dirty(struct page *page)
> +{
> + /*
> + * Unlike __set_page_dirty_no_writeback, dax does all dirty
> + * tracking in the radix in response to mkwrite faults.
Please stop saying "in the radix". I think you mean "in the page cache".
> +EXPORT_SYMBOL(dax_set_page_dirty);
> +EXPORT_SYMBOL(dax_direct_IO);
> +EXPORT_SYMBOL(dax_writepage);
> +EXPORT_SYMBOL(dax_readpage);
> +EXPORT_SYMBOL(dax_readpages);
> +EXPORT_SYMBOL(dax_write_begin);
> +EXPORT_SYMBOL(dax_write_end);
> +EXPORT_SYMBOL(dax_invalidatepage);
Exporting all these symbols to modules isn't exactly free. Are you sure it
doesn't make more sense to put tests for dax in the existing aops?
next prev parent reply other threads:[~2017-12-27 5:24 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 0:56 [PATCH v4 00/18] dax: fix dma vs truncate/hole-punch Dan Williams
2017-12-24 0:56 ` Dan Williams
2017-12-24 0:56 ` Dan Williams
2017-12-24 0:56 ` [PATCH v4 01/18] mm, dax: introduce pfn_t_special() Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-04 8:16 ` Christoph Hellwig
2018-01-04 8:16 ` Christoph Hellwig
2017-12-24 0:56 ` [PATCH v4 02/18] ext4: auto disable dax instead of failing mount Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-03 14:20 ` Jan Kara
2018-01-03 14:20 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 03/18] ext2: " Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-03 14:21 ` Jan Kara
2018-01-03 14:21 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 04/18] dax: require 'struct page' by default for filesystem dax Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-03 15:29 ` Jan Kara
2018-01-03 15:29 ` Jan Kara
2018-01-04 8:16 ` Christoph Hellwig
2018-01-04 8:16 ` Christoph Hellwig
2018-01-08 11:58 ` Gerald Schaefer
2018-01-08 11:58 ` Gerald Schaefer
2017-12-24 0:56 ` [PATCH v4 05/18] dax: stop using VM_MIXEDMAP for dax Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-03 15:27 ` Jan Kara
2018-01-03 15:27 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 06/18] dax: stop using VM_HUGEPAGE " Dan Williams
2017-12-24 0:56 ` Dan Williams
2017-12-24 0:56 ` [PATCH v4 07/18] dax: store pfns in the radix Dan Williams
2017-12-24 0:56 ` Dan Williams
2017-12-27 0:17 ` Ross Zwisler
2017-12-27 0:17 ` Ross Zwisler
2018-01-02 20:15 ` Dan Williams
2018-01-02 20:15 ` Dan Williams
2018-01-03 15:39 ` Jan Kara
2018-01-03 15:39 ` Jan Kara
2017-12-24 0:56 ` [PATCH v4 08/18] tools/testing/nvdimm: add 'bio_delay' mechanism Dan Williams
2017-12-24 0:56 ` Dan Williams
2017-12-27 18:08 ` Ross Zwisler
2017-12-27 18:08 ` Ross Zwisler
2018-01-02 20:35 ` Dan Williams
2018-01-02 20:35 ` Dan Williams
2018-01-02 21:44 ` Dave Chinner
2018-01-02 21:44 ` Dave Chinner
2018-01-02 21:51 ` Dan Williams
2018-01-02 21:51 ` Dan Williams
2018-01-03 15:46 ` Jan Kara
2018-01-03 15:46 ` Jan Kara
2018-01-03 20:37 ` Jeff Moyer
2018-01-03 20:37 ` Jeff Moyer
2017-12-24 0:56 ` [PATCH v4 09/18] mm, dax: enable filesystems to trigger dev_pagemap ->page_free callbacks Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-04 8:20 ` Christoph Hellwig
2018-01-04 8:20 ` Christoph Hellwig
2017-12-24 0:56 ` [PATCH v4 10/18] mm, dev_pagemap: introduce CONFIG_DEV_PAGEMAP_OPS Dan Williams
2017-12-24 0:56 ` Dan Williams
2018-01-04 8:25 ` Christoph Hellwig
2018-01-04 8:25 ` Christoph Hellwig
2017-12-24 0:56 ` [PATCH v4 11/18] fs, dax: introduce DEFINE_FSDAX_AOPS Dan Williams
2017-12-24 0:56 ` Dan Williams
2017-12-27 5:29 ` Matthew Wilcox [this message]
2017-12-27 5:29 ` Matthew Wilcox
2018-01-02 20:21 ` Dan Williams
2018-01-02 20:21 ` Dan Williams
2018-01-03 16:05 ` Jan Kara
2018-01-03 16:05 ` Jan Kara
2018-01-04 8:27 ` Christoph Hellwig
2018-01-04 8:27 ` Christoph Hellwig
2018-01-02 21:41 ` Dave Chinner
2018-01-02 21:41 ` Dave Chinner
2017-12-24 0:57 ` [PATCH v4 12/18] xfs: use DEFINE_FSDAX_AOPS Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-02 21:15 ` Darrick J. Wong
2018-01-02 21:15 ` Darrick J. Wong
2018-01-02 21:40 ` Dan Williams
2018-01-02 21:40 ` Dan Williams
2018-01-03 16:09 ` Jan Kara
2018-01-03 16:09 ` Jan Kara
2018-01-04 8:28 ` Christoph Hellwig
2018-01-04 8:28 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 13/18] ext4: " Dan Williams
2017-12-24 0:57 ` Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-04 8:29 ` Christoph Hellwig
2018-01-04 8:29 ` Christoph Hellwig
2018-01-04 8:29 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 14/18] ext2: " Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-04 8:29 ` Christoph Hellwig
2018-01-04 8:29 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 15/18] mm, fs, dax: use page->mapping to warn if dma collides with truncate Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-04 8:30 ` Christoph Hellwig
2018-01-04 8:30 ` Christoph Hellwig
2018-01-04 9:39 ` Jan Kara
2018-01-04 9:39 ` Jan Kara
2017-12-24 0:57 ` [PATCH v4 16/18] wait_bit: introduce {wait_on,wake_up}_atomic_one Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-04 8:30 ` Christoph Hellwig
2018-01-04 8:30 ` Christoph Hellwig
2017-12-24 0:57 ` [PATCH v4 17/18] mm, fs, dax: dax_flush_dma, handle dma vs block-map-change collisions Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-04 8:31 ` Christoph Hellwig
2018-01-04 8:31 ` Christoph Hellwig
2018-01-04 11:12 ` Jan Kara
2018-01-04 11:12 ` Jan Kara
2018-01-07 21:58 ` Dan Williams
2018-01-07 21:58 ` Dan Williams
2018-01-08 13:50 ` Jan Kara
2018-01-08 13:50 ` Jan Kara
2018-03-08 17:02 ` Dan Williams
2018-03-08 17:02 ` Dan Williams
2018-03-09 12:56 ` Jan Kara
2018-03-09 12:56 ` Jan Kara
2018-03-09 16:15 ` Dan Williams
2018-03-09 16:15 ` Dan Williams
2018-03-09 17:26 ` Dan Williams
2018-03-09 17:26 ` Dan Williams
2017-12-24 0:57 ` [PATCH v4 18/18] xfs, dax: wire up dax_flush_dma support via a new xfs_sync_dma helper Dan Williams
2017-12-24 0:57 ` Dan Williams
2018-01-02 21:07 ` Darrick J. Wong
2018-01-02 21:07 ` Darrick J. Wong
2018-01-02 23:00 ` Dave Chinner
2018-01-02 23:00 ` Dave Chinner
2018-01-03 2:21 ` Dan Williams
2018-01-03 2:21 ` Dan Williams
2018-01-03 7:51 ` Dave Chinner
2018-01-03 7:51 ` Dave Chinner
2018-01-04 8:34 ` Christoph Hellwig
2018-01-04 8:34 ` Christoph Hellwig
2018-01-04 8:33 ` Christoph Hellwig
2018-01-04 8:33 ` Christoph Hellwig
2018-01-04 8:17 ` [PATCH v4 00/18] dax: fix dma vs truncate/hole-punch Christoph Hellwig
2018-01-04 8:17 ` Christoph Hellwig
2018-01-04 8:17 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171227052910.GE24828@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mawilcox@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.