From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>,
linux-spi <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 4/5] spi: spi-gpio: Make optional chipselect handling more explicit
Date: Wed, 3 Jan 2018 16:05:17 +0000 [thread overview]
Message-ID: <20180103160517.GE28713@sirena.org.uk> (raw)
In-Reply-To: <CACRpkdaEyKcWPY543CZz0grepAhVijefh_+FCsPd3g+83hv2Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Wed, Jan 03, 2018 at 10:40:52AM +0100, Linus Walleij wrote:
> So someone wanted to save a slab by using this instead of allocating
> the array dynamically. It's not a very admirable coding style to begin
> with. I doubt the system gains much from this.
Right, David was very focused on saving memory.
> If you agree I can rewrite it to have struct gpio_desc ** and
> dynamically allocate that to the number of descriptors with devm_kzalloc()
> instead, that is more in line with kernel patterns and this memory
> optimization anyways seems a bit overdone anyways.
Yes, that would be clearer - it's something that's good to fix anyway
rather than trying to contort around it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-01-03 16:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-01 13:37 [PATCH 0/5] Rewrite GPIO SPI to use descriptors Linus Walleij
[not found] ` <20180101133749.29567-1-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-01 13:37 ` [PATCH 1/5] gpio: of: Support SPI nonstandard GPIO properties Linus Walleij
[not found] ` <20180101133749.29567-2-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-03 15:04 ` Mark Brown
2018-01-03 15:23 ` Rob Herring
[not found] ` <CAL_JsqLH4pqptAkpw2CHPRe=6dR3k1iBPM8g7yMFUHnYmm7L9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-04 20:24 ` Linus Walleij
[not found] ` <CACRpkdZ9yGm9K4iF=jR8bjzZR6cU7vEV8tNz6i7DfcE=Jhp2yw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-05 10:21 ` Andy Shevchenko
2018-01-01 13:37 ` [PATCH 2/5] spi: spi-gpio: Rewrite to use GPIO descriptors Linus Walleij
[not found] ` <20180101133749.29567-3-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-03 15:55 ` Mark Brown
2018-01-05 7:34 ` Olof Johansson
2018-01-05 10:33 ` Andy Shevchenko
2018-01-01 13:37 ` [PATCH 3/5] spi: spi-gpio: Augment device tree bindings Linus Walleij
[not found] ` <20180101133749.29567-4-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-02-14 16:28 ` Applied "spi: spi-gpio: Augment device tree bindings" to the spi tree Mark Brown
2018-01-01 13:37 ` [PATCH 4/5] spi: spi-gpio: Make optional chipselect handling more explicit Linus Walleij
[not found] ` <20180101133749.29567-5-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-03 8:21 ` Geert Uytterhoeven
[not found] ` <CAMuHMdV5tdm0diunWg2BXxgVsG0FqwTgXXXBD+p9nbOEXcd59Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 8:58 ` Linus Walleij
[not found] ` <CACRpkdZaLKUs+9BP_Tp8bhdCur+CHaTK1RsS=i2na4Edqz1VGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 9:17 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVeTQOxRMJaohGFtw6LUtwQb6H46rsrf1fRFno9KBQXXA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 9:40 ` Linus Walleij
[not found] ` <CACRpkdaEyKcWPY543CZz0grepAhVijefh_+FCsPd3g+83hv2Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 16:05 ` Mark Brown [this message]
2018-01-01 13:37 ` [PATCH 5/5] spi: spi-gpio: Delete references to non-GENERIC_BITBANG Linus Walleij
[not found] ` <20180101133749.29567-6-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-03 16:10 ` Mark Brown
2018-01-02 8:15 ` [PATCH 0/5] Rewrite GPIO SPI to use descriptors Linus Walleij
2018-01-02 18:42 ` Trent Piepho
[not found] ` <1514918569.26695.151.camel-cgc2CodaaHDQT0dZR+AlfA@public.gmane.org>
2018-01-02 23:17 ` Linus Walleij
[not found] ` <CACRpkdYRJ=jR4B2Ko2P1axwGMKob2vHkY2h8cMc9t9Qi7n52sQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-03 16:24 ` Mark Brown
[not found] ` <20180103162449.GG28713-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-01-06 23:18 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180103160517.GE28713@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.