Re: [PATCH 5/5] spi: spi-gpio: Delete references to non-GENERIC_BITBANG

From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/5] spi: spi-gpio: Delete references to non-GENERIC_BITBANG
Date: Wed, 3 Jan 2018 16:10:45 +0000	[thread overview]
Message-ID: <20180103161045.GF28713@sirena.org.uk> (raw)
In-Reply-To: <20180101133749.29567-6-linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On Mon, Jan 01, 2018 at 02:37:49PM +0100, Linus Walleij wrote:
> The non-generic bitbang was a feature where a platform could optimize
> SPI bit-banging by inlining the routines to hammer GPIO lines into
> the GPIO bitbanging driver as direct register writes using a custom
> set of GPIO library calls.

> It does not work with multiplatform concepts, violates everything
> about how GPIO is made generic and is just generally a bad idea,
> even on legacy system. Also there is no single user in the entire
> kernel (for good reasons).

> Delete the remnants of this optimization.

What's the positive reason for removing this?  I'd not anticipate people
doing this upstream but it seems like a totally valid thing to do on
product.  It's just compiling out the gpiolib calls so it never looked
like too big a maintanence overhead.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]