All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: xuejiufei <xuejiufei@gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Shaohua Li <shli@kernel.org>,
	linux-block@vger.kernel.org, cgroups@vger.kernel.org,
	jinli.zjl@alibaba-inc.com, qijiang.qj@alibaba-inc.com
Subject: Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer
Date: Tue, 9 Jan 2018 06:56:59 -0800	[thread overview]
Message-ID: <20180109145659.GG3668920@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <5ff01c31-5277-909f-4c35-9b9be513d8e1@gmail.com>

Hello,

On Tue, Jan 09, 2018 at 12:45:13PM +0800, xuejiufei wrote:
> 1. A bio is charged according to the direction, if we put the reads
> and sync writes together, we need to search the queue to pick a
> certain number of read and write IOs when the limit is not reached.

Ah, you're right.

> 2. I found that the multi-queue scheduler kyber also has three queues:
> one for read, one for sync write and one for others. This patch
> introduces another queue for async writes and others just like kyber.

Yeah, it'd make sense to make that a separate queue then.

Thanks.

-- 
tejun

  reply	other threads:[~2018-01-09 14:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-05  5:16 [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer xuejiufei
2018-01-05  5:16 ` xuejiufei
2018-01-08 12:07 ` Tejun Heo
2018-01-09  4:45   ` xuejiufei
2018-01-09  4:45     ` xuejiufei
2018-01-09 14:56     ` Tejun Heo [this message]
2018-01-10  1:44       ` xuejiufei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109145659.GG3668920@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=axboe@fb.com \
    --cc=cgroups@vger.kernel.org \
    --cc=jinli.zjl@alibaba-inc.com \
    --cc=linux-block@vger.kernel.org \
    --cc=qijiang.qj@alibaba-inc.com \
    --cc=shli@kernel.org \
    --cc=xuejiufei@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.