Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer

From: xuejiufei <xuejiufei@gmail.com>
To: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@fb.com>, Shaohua Li <shli@kernel.org>,
	linux-block@vger.kernel.org, cgroups@vger.kernel.org,
	jinli.zjl@alibaba-inc.com, qijiang.qj@alibaba-inc.com
Subject: Re: [RFC PATCH] blk-throttle: dispatch more sync writes in block throttle layer
Date: Wed, 10 Jan 2018 09:44:43 +0800	[thread overview]
Message-ID: <37158a6a-ff0d-10e7-c39b-9d588b5f50d2@gmail.com> (raw)
In-Reply-To: <20180109145659.GG3668920@devbig577.frc2.facebook.com>

Hi Tejun,

On 2018/1/9 下午10:56, Tejun Heo wrote:
> Hello,
> 
> On Tue, Jan 09, 2018 at 12:45:13PM +0800, xuejiufei wrote:
>> 1. A bio is charged according to the direction, if we put the reads
>> and sync writes together, we need to search the queue to pick a
>> certain number of read and write IOs when the limit is not reached.
> 
> Ah, you're right.
> 
>> 2. I found that the multi-queue scheduler kyber also has three queues:
>> one for read, one for sync write and one for others. This patch
>> introduces another queue for async writes and others just like kyber.
> 
> Yeah, it'd make sense to make that a separate queue then.
> 
Could you please review this patch and give some advice?

Thanks.
Jiufei Xue

> Thanks.
> 