From: jacopo mondi <jacopo@jmondi.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Sakari Ailus <sakari.ailus@iki.fi>, Hans Verkuil <hverkuil@xs4all.nl>, Jacopo Mondi <jacopo+renesas@jmondi.org>, magnus.damm@gmail.com, geert@glider.be, mchehab@kernel.org, festevam@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, pombredanne@nexb.com, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies Date: Sun, 21 Jan 2018 09:31:17 +0000 [thread overview] Message-ID: <20180121093117.GK24926@w540> (raw) In-Reply-To: <2694661.NEH0HeGgLD@avalon> Hello Hans, Laurent, Sakari, On Fri, Jan 19, 2018 at 02:23:21PM +0200, Laurent Pinchart wrote: > Hello, > > On Friday, 19 January 2018 13:19:18 EET Sakari Ailus wrote: > > On Fri, Jan 19, 2018 at 11:47:33AM +0100, Hans Verkuil wrote: > > > On 01/19/18 11:24, Hans Verkuil wrote: > > >> On 01/16/18 22:44, Jacopo Mondi wrote: > > >>> Remove soc_camera framework dependencies from ov772x sensor driver. > > >>> - Handle clock and gpios > > >>> - Register async subdevice > > >>> - Remove soc_camera specific g/s_mbus_config operations > > >>> - Change image format colorspace from JPEG to SRGB as the two use the > > >>> same colorspace information but JPEG makes assumptions on color > > >>> components quantization that do not apply to the sensor > > >>> - Remove sizes crop from get_selection as driver can't scale > > >>> - Add kernel doc to driver interface header file > > >>> - Adjust build system > > >>> > > >>> This commit does not remove the original soc_camera based driver as > > >>> long as other platforms depends on soc_camera-based CEU driver. > > >>> > > >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > >> > > >> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > > > > > Un-acked. > > > > > > I just noticed that this sensor driver has no enum_frame_interval and > > > g/s_parm support. How would a driver ever know the frame rate of the > > > sensor without that? Does it make any difference if I point out that this series hasn't removed any of that code, and the driver was not supporting that already? Or was it handled through soc_camera? > > > > s/_parm/_frame_interval/ ? > > > > We should have wrappers for this or rather to convert g/s_parm users to > > g/s_frame_interval so drivers don't need to implement both. > > There are two ways to set the frame interval, either explicitly through the > s_frame_interval operation, or implicitly through control of the pixel clock, > horizontal blanking and vertical blanking (which in turn can be influenced by > the exposure time). > > Having two ways to perform the same operation seems sub-optimal to me, but I > could understand if they covered different use cases. As far as I know we > don't document the use cases for those methods. What's your opinion on that ? > -If- I have to implement that in this series to have it accepted, please let me know which one of the two is the preferred one :) Thanks j > -- > Regards, > > Laurent Pinchart >
WARNING: multiple messages have this Message-ID (diff)
From: jacopo mondi <jacopo@jmondi.org> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Sakari Ailus <sakari.ailus@iki.fi>, Hans Verkuil <hverkuil@xs4all.nl>, Jacopo Mondi <jacopo+renesas@jmondi.org>, magnus.damm@gmail.com, geert@glider.be, mchehab@kernel.org, festevam@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, pombredanne@nexb.com, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, linux-sh@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies Date: Sun, 21 Jan 2018 10:31:17 +0100 [thread overview] Message-ID: <20180121093117.GK24926@w540> (raw) In-Reply-To: <2694661.NEH0HeGgLD@avalon> Hello Hans, Laurent, Sakari, On Fri, Jan 19, 2018 at 02:23:21PM +0200, Laurent Pinchart wrote: > Hello, > > On Friday, 19 January 2018 13:19:18 EET Sakari Ailus wrote: > > On Fri, Jan 19, 2018 at 11:47:33AM +0100, Hans Verkuil wrote: > > > On 01/19/18 11:24, Hans Verkuil wrote: > > >> On 01/16/18 22:44, Jacopo Mondi wrote: > > >>> Remove soc_camera framework dependencies from ov772x sensor driver. > > >>> - Handle clock and gpios > > >>> - Register async subdevice > > >>> - Remove soc_camera specific g/s_mbus_config operations > > >>> - Change image format colorspace from JPEG to SRGB as the two use the > > >>> same colorspace information but JPEG makes assumptions on color > > >>> components quantization that do not apply to the sensor > > >>> - Remove sizes crop from get_selection as driver can't scale > > >>> - Add kernel doc to driver interface header file > > >>> - Adjust build system > > >>> > > >>> This commit does not remove the original soc_camera based driver as > > >>> long as other platforms depends on soc_camera-based CEU driver. > > >>> > > >>> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org> > > >>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > >> > > >> Acked-by: Hans Verkuil <hans.verkuil@cisco.com> > > > > > > Un-acked. > > > > > > I just noticed that this sensor driver has no enum_frame_interval and > > > g/s_parm support. How would a driver ever know the frame rate of the > > > sensor without that? Does it make any difference if I point out that this series hasn't removed any of that code, and the driver was not supporting that already? Or was it handled through soc_camera? > > > > s/_parm/_frame_interval/ ? > > > > We should have wrappers for this or rather to convert g/s_parm users to > > g/s_frame_interval so drivers don't need to implement both. > > There are two ways to set the frame interval, either explicitly through the > s_frame_interval operation, or implicitly through control of the pixel clock, > horizontal blanking and vertical blanking (which in turn can be influenced by > the exposure time). > > Having two ways to perform the same operation seems sub-optimal to me, but I > could understand if they covered different use cases. As far as I know we > don't document the use cases for those methods. What's your opinion on that ? > -If- I have to implement that in this series to have it accepted, please let me know which one of the two is the preferred one :) Thanks j > -- > Regards, > > Laurent Pinchart >
next prev parent reply other threads:[~2018-01-21 9:31 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-01-16 21:44 [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-16 21:44 ` [PATCH v6 1/9] dt-bindings: media: Add Renesas CEU bindings Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-17 7:59 ` Sakari Ailus 2018-01-17 7:59 ` Sakari Ailus 2018-01-17 8:35 ` jacopo mondi 2018-01-17 8:35 ` jacopo mondi 2018-01-17 8:55 ` Sakari Ailus 2018-01-17 8:55 ` Sakari Ailus 2018-01-16 21:44 ` [PATCH v6 2/9] include: media: Add Renesas CEU driver interface Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-16 21:44 ` [PATCH v6 3/9] v4l: platform: Add Renesas CEU driver Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-19 11:20 ` Hans Verkuil 2018-01-19 11:20 ` Hans Verkuil 2018-01-19 12:20 ` Laurent Pinchart 2018-01-19 12:20 ` Laurent Pinchart 2018-01-19 12:25 ` Hans Verkuil 2018-01-19 12:25 ` Hans Verkuil [not found] ` <4195ec6a-b99d-2fad-3898-9ce9c02fce00-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2018-01-22 0:52 ` Laurent Pinchart 2018-01-22 0:52 ` Laurent Pinchart 2018-01-22 0:52 ` Laurent Pinchart 2018-01-22 9:07 ` Hans Verkuil 2018-01-22 9:07 ` Hans Verkuil 2018-01-21 9:53 ` jacopo mondi 2018-01-21 9:53 ` jacopo mondi 2018-01-21 10:21 ` Hans Verkuil 2018-01-21 10:21 ` Hans Verkuil 2018-01-21 10:23 ` Hans Verkuil 2018-01-21 10:23 ` Hans Verkuil 2018-01-21 17:29 ` jacopo mondi 2018-01-21 17:29 ` jacopo mondi 2018-01-22 9:56 ` Hans Verkuil 2018-01-22 9:56 ` Hans Verkuil 2018-01-19 22:35 ` kbuild test robot 2018-01-19 22:35 ` kbuild test robot 2018-01-19 22:35 ` kbuild test robot 2018-01-20 2:11 ` kbuild test robot 2018-01-20 2:11 ` kbuild test robot 2018-01-20 2:11 ` kbuild test robot 2018-01-16 21:44 ` [PATCH v6 4/9] ARM: dts: r7s72100: Add Capture Engine Unit (CEU) Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-16 21:44 ` [PATCH v6 5/9] v4l: i2c: Copy ov772x soc_camera sensor driver Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-16 21:44 ` [PATCH v6 6/9] media: i2c: ov772x: Remove soc_camera dependencies Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-19 10:24 ` Hans Verkuil 2018-01-19 10:24 ` Hans Verkuil [not found] ` <d67c21e5-2488-977b-39d8-561048409209-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2018-01-19 10:47 ` Hans Verkuil 2018-01-19 10:47 ` Hans Verkuil 2018-01-19 10:47 ` Hans Verkuil 2018-01-19 11:19 ` Sakari Ailus 2018-01-19 11:19 ` Sakari Ailus 2018-01-19 11:44 ` Hans Verkuil 2018-01-19 11:44 ` Hans Verkuil [not found] ` <20180119111917.76wosrokgracbdrz-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org> 2018-01-19 12:23 ` Laurent Pinchart 2018-01-19 12:23 ` Laurent Pinchart 2018-01-19 12:23 ` Laurent Pinchart 2018-01-21 9:31 ` jacopo mondi [this message] 2018-01-21 9:31 ` jacopo mondi 2018-01-21 10:18 ` Hans Verkuil 2018-01-21 10:18 ` Hans Verkuil 2018-01-16 21:44 ` [PATCH v6 7/9] v4l: i2c: Copy tw9910 soc_camera sensor driver Jacopo Mondi 2018-01-16 21:44 ` Jacopo Mondi 2018-01-16 21:45 ` [PATCH v6 8/9] media: i2c: tw9910: Remove soc_camera dependencies Jacopo Mondi 2018-01-16 21:45 ` Jacopo Mondi 2018-01-16 21:45 ` [PATCH v6 9/9] arch: sh: migor: Use new renesas-ceu camera driver Jacopo Mondi 2018-01-16 21:45 ` Jacopo Mondi 2018-01-19 11:26 ` [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver Hans Verkuil 2018-01-19 11:26 ` Hans Verkuil [not found] ` <6fcd22c1-19a5-e0b7-2b00-961e1cd1ebaa-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2018-01-21 17:49 ` jacopo mondi 2018-01-21 17:49 ` jacopo mondi 2018-01-21 17:49 ` jacopo mondi 2018-01-22 10:00 ` Hans Verkuil 2018-01-22 10:00 ` Hans Verkuil 2018-01-22 10:00 ` Hans Verkuil 2018-01-19 22:12 ` Randy Dunlap 2018-01-19 22:12 ` Randy Dunlap 2018-01-21 17:54 ` jacopo mondi 2018-01-21 17:54 ` jacopo mondi 2018-01-21 18:04 ` Randy Dunlap 2018-01-21 18:04 ` Randy Dunlap
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180121093117.GK24926@w540 \ --to=jacopo@jmondi.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=geert@glider.be \ --cc=hverkuil@xs4all.nl \ --cc=jacopo+renesas@jmondi.org \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-sh@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=pombredanne@nexb.com \ --cc=robh+dt@kernel.org \ --cc=sakari.ailus@iki.fi \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.