From: Jon Mason <jdmason@kudzu.us>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
linux-pci@vger.kernel.org, linux-ntb@googlegroups.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] ntb_hw_switchtec: Make function switchtec_ntb_remove() static
Date: Wed, 24 Jan 2018 04:07:08 +0000 [thread overview]
Message-ID: <20180124040707.GB20474@kudzu.us> (raw)
In-Reply-To: <14b5eb05-c152-6a30-d590-881600a8a72f@deltatee.com>
On Tue, Jan 23, 2018 at 09:35:52AM -0700, Logan Gunthorpe wrote:
> Looks good, thanks.
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Applied to ntb-next
Thanks,
Jon
>
> Logan
>
>
> On 22/01/18 07:09 PM, Wei Yongjun wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/ntb/hw/mscc/ntb_hw_switchtec.c:1552:6: warning:
> > symbol 'switchtec_ntb_remove' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > index a1d547b6..f624ae2 100644
> > --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > @@ -1549,8 +1549,8 @@ static int switchtec_ntb_add(struct device *dev,
> > return rc;
> > }
> > -void switchtec_ntb_remove(struct device *dev,
> > - struct class_interface *class_intf)
> > +static void switchtec_ntb_remove(struct device *dev,
> > + struct class_interface *class_intf)
> > {
> > struct switchtec_dev *stdev = to_stdev(dev);
> > struct switchtec_ntb *sndev = stdev->sndev;
> >
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/14b5eb05-c152-6a30-d590-881600a8a72f%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Jon Mason <jdmason@kudzu.us>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
linux-pci@vger.kernel.org, linux-ntb@googlegroups.com,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] ntb_hw_switchtec: Make function switchtec_ntb_remove() static
Date: Tue, 23 Jan 2018 23:07:08 -0500 [thread overview]
Message-ID: <20180124040707.GB20474@kudzu.us> (raw)
In-Reply-To: <14b5eb05-c152-6a30-d590-881600a8a72f@deltatee.com>
On Tue, Jan 23, 2018 at 09:35:52AM -0700, Logan Gunthorpe wrote:
> Looks good, thanks.
>
> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Applied to ntb-next
Thanks,
Jon
>
> Logan
>
>
> On 22/01/18 07:09 PM, Wei Yongjun wrote:
> > Fixes the following sparse warnings:
> >
> > drivers/ntb/hw/mscc/ntb_hw_switchtec.c:1552:6: warning:
> > symbol 'switchtec_ntb_remove' was not declared. Should it be static?
> >
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
> > drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > index a1d547b6..f624ae2 100644
> > --- a/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > +++ b/drivers/ntb/hw/mscc/ntb_hw_switchtec.c
> > @@ -1549,8 +1549,8 @@ static int switchtec_ntb_add(struct device *dev,
> > return rc;
> > }
> > -void switchtec_ntb_remove(struct device *dev,
> > - struct class_interface *class_intf)
> > +static void switchtec_ntb_remove(struct device *dev,
> > + struct class_interface *class_intf)
> > {
> > struct switchtec_dev *stdev = to_stdev(dev);
> > struct switchtec_ntb *sndev = stdev->sndev;
> >
>
> --
> You received this message because you are subscribed to the Google Groups "linux-ntb" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to linux-ntb+unsubscribe@googlegroups.com.
> To post to this group, send email to linux-ntb@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/linux-ntb/14b5eb05-c152-6a30-d590-881600a8a72f%40deltatee.com.
> For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2018-01-24 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 2:09 [PATCH -next] ntb_hw_switchtec: Make function switchtec_ntb_remove() static Wei Yongjun
2018-01-23 2:09 ` Wei Yongjun
2018-01-23 16:35 ` Logan Gunthorpe
2018-01-23 16:35 ` Logan Gunthorpe
2018-01-24 4:07 ` Jon Mason [this message]
2018-01-24 4:07 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124040707.GB20474@kudzu.us \
--to=jdmason@kudzu.us \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.