From: Keith Busch <keith.busch@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nitesh Shetty <nj.shetty@samsung.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, linux-block@vger.kernel.org,
axboe@fb.com, linux-nvme@lists.infradead.org,
joshi.k@samsung.com
Subject: Re: [PATCH] blk: optimization for classic polling
Date: Tue, 20 Feb 2018 09:27:37 -0700 [thread overview]
Message-ID: <20180220162737.GC7076@localhost.localdomain> (raw)
In-Reply-To: <20180220132137.GG25314@hirez.programming.kicks-ass.net>
On Tue, Feb 20, 2018 at 02:21:37PM +0100, Peter Zijlstra wrote:
> Also, set_current_state(TASK_RUNNING) is dodgy (similarly in
> __blk_mq_poll), why do you need that memory barrier?
You're right. The subsequent revision that was committed removed the
barrier. The commit is here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=67b4110f8c8d16e588d7730db8e8b01b32c1bd8b
I hope the code at least looks more reasonable. The changelog isn't much
different, though.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] blk: optimization for classic polling
Date: Tue, 20 Feb 2018 09:27:37 -0700 [thread overview]
Message-ID: <20180220162737.GC7076@localhost.localdomain> (raw)
In-Reply-To: <20180220132137.GG25314@hirez.programming.kicks-ass.net>
On Tue, Feb 20, 2018@02:21:37PM +0100, Peter Zijlstra wrote:
> Also, set_current_state(TASK_RUNNING) is dodgy (similarly in
> __blk_mq_poll), why do you need that memory barrier?
You're right. The subsequent revision that was committed removed the
barrier. The commit is here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit?id=67b4110f8c8d16e588d7730db8e8b01b32c1bd8b
I hope the code at least looks more reasonable. The changelog isn't much
different, though.
next prev parent reply other threads:[~2018-02-20 16:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180208143655epcas1p444bf34705526b7839a5a135f82761aad@epcas1p4.samsung.com>
2018-02-08 14:37 ` [PATCH] blk: optimization for classic polling Nitesh Shetty
2083-05-30 4:21 ` Nitesh Shetty
2018-02-08 15:27 ` Keith Busch
2018-02-08 15:27 ` Keith Busch
2018-02-08 15:27 ` Keith Busch
2018-02-08 16:03 ` Sagi Grimberg
2018-02-08 16:03 ` Sagi Grimberg
2018-02-12 15:50 ` Bart Van Assche
2018-02-12 15:50 ` Bart Van Assche
[not found] ` <CGME20180213154752epcas1p35e3c13d150d2108a06342781ec5e64d7@epcas1p3.samsung.com>
2018-02-13 15:48 ` [PATCH v3] " Nitesh Shetty
2018-02-13 15:48 ` Nitesh Shetty
2018-02-13 16:12 ` Jens Axboe
2018-02-13 16:12 ` Jens Axboe
[not found] ` <CGME20180213082701epcas1p4d92a86f127a0918fb9d62120bd121cb6@epcas1p4.samsung.com>
2018-02-13 18:56 ` [PATCH v2 RESENT] " Nitesh Shetty
2018-02-13 18:56 ` Nitesh Shetty
2018-02-13 14:42 ` Jens Axboe
2018-02-13 14:42 ` Jens Axboe
2018-02-20 13:21 ` [PATCH] " Peter Zijlstra
2018-02-20 13:21 ` Peter Zijlstra
2018-02-20 16:27 ` Keith Busch [this message]
2018-02-20 16:27 ` Keith Busch
2018-02-20 22:37 ` Jens Axboe
2018-02-20 22:37 ` Jens Axboe
2018-02-21 8:32 ` Peter Zijlstra
2018-02-21 8:32 ` Peter Zijlstra
2018-10-10 18:52 ` Florian Fainelli
2018-10-10 18:52 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220162737.GC7076@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@fb.com \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nj.shetty@samsung.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.