From: Jonathan Cameron <jic23@kernel.org> To: Himanshu Jha <himanshujha199640@gmail.com> Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de Subject: Re: [PATCH 02/11] Staging: iio: accel: Add a blank space before returns Date: Wed, 7 Mar 2018 20:32:06 +0000 [thread overview] Message-ID: <20180307203206.1ba1ecf8@archlinux> (raw) In-Reply-To: <1520236170-14668-3-git-send-email-himanshujha199640@gmail.com> On Mon, 5 Mar 2018 13:19:21 +0530 Himanshu Jha <himanshujha199640@gmail.com> wrote: > Adding a blank space before/after some returns improves readability. > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> Applied - patch title adjusted. Thanks, Jonathan > --- > drivers/staging/iio/accel/adis16201.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c > index 0f6a204..0fae8aa 100644 > --- a/drivers/staging/iio/accel/adis16201.c > +++ b/drivers/staging/iio/accel/adis16201.c > @@ -232,6 +232,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev, > *val = val16; > return IIO_VAL_INT; > } > + > return -EINVAL; > } > > @@ -262,6 +263,7 @@ static int adis16201_write_raw(struct iio_dev *indio_dev, > addr = adis16201_addresses[chan->scan_index]; > return adis_write_reg_16(st, addr, val16); > } > + > return -EINVAL; > } > > @@ -336,6 +338,7 @@ static int adis16201_probe(struct spi_device *spi) > ret = adis_init(st, indio_dev, spi, &adis16201_data); > if (ret) > return ret; > + > ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL); > if (ret) > return ret; > @@ -348,6 +351,7 @@ static int adis16201_probe(struct spi_device *spi) > ret = iio_device_register(indio_dev); > if (ret < 0) > goto error_cleanup_buffer_trigger; > + > return 0; > > error_cleanup_buffer_trigger: _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Himanshu Jha <himanshujha199640@gmail.com> Cc: lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, daniel.baluta@gmail.com Subject: Re: [PATCH 02/11] Staging: iio: accel: Add a blank space before returns Date: Wed, 7 Mar 2018 20:32:06 +0000 [thread overview] Message-ID: <20180307203206.1ba1ecf8@archlinux> (raw) In-Reply-To: <1520236170-14668-3-git-send-email-himanshujha199640@gmail.com> On Mon, 5 Mar 2018 13:19:21 +0530 Himanshu Jha <himanshujha199640@gmail.com> wrote: > Adding a blank space before/after some returns improves readability. > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> Applied - patch title adjusted. Thanks, Jonathan > --- > drivers/staging/iio/accel/adis16201.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c > index 0f6a204..0fae8aa 100644 > --- a/drivers/staging/iio/accel/adis16201.c > +++ b/drivers/staging/iio/accel/adis16201.c > @@ -232,6 +232,7 @@ static int adis16201_read_raw(struct iio_dev *indio_dev, > *val = val16; > return IIO_VAL_INT; > } > + > return -EINVAL; > } > > @@ -262,6 +263,7 @@ static int adis16201_write_raw(struct iio_dev *indio_dev, > addr = adis16201_addresses[chan->scan_index]; > return adis_write_reg_16(st, addr, val16); > } > + > return -EINVAL; > } > > @@ -336,6 +338,7 @@ static int adis16201_probe(struct spi_device *spi) > ret = adis_init(st, indio_dev, spi, &adis16201_data); > if (ret) > return ret; > + > ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL); > if (ret) > return ret; > @@ -348,6 +351,7 @@ static int adis16201_probe(struct spi_device *spi) > ret = iio_device_register(indio_dev); > if (ret < 0) > goto error_cleanup_buffer_trigger; > + > return 0; > > error_cleanup_buffer_trigger:
next prev parent reply other threads:[~2018-03-07 20:32 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-05 7:49 [PATCH 00/11] staging: iio: accel: adis16201 driver cleanup Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-05 7:49 ` [PATCH 01/11] Staging: iio: accel: Prefer alphabetical sequence of header files Himanshu Jha 2018-03-07 20:29 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 02/11] Staging: iio: accel: Add a blank space before returns Himanshu Jha 2018-03-07 20:32 ` Jonathan Cameron [this message] 2018-03-07 20:32 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-06 21:26 ` Shreeya Patel 2018-03-06 22:25 ` Himanshu Jha 2018-03-07 20:40 ` Jonathan Cameron 2018-03-07 20:40 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 04/11] Staging: iio: accel: Rename few macro definitions Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-07 20:42 ` Jonathan Cameron 2018-03-07 20:42 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 05/11] Staging: iio: accel: Add _REG suffix to registers Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-07 20:44 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 06/11] Staging: iio: accel: Reverse christmas tree Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-05 7:49 ` [PATCH 07/11] Staging: iio: accel: Adjust arguments to match open parentheses Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-05 10:16 ` Dan Carpenter 2018-03-05 10:16 ` Dan Carpenter 2018-03-05 7:49 ` [PATCH 08/11] Staging: iio: accel: Use switch statement than if-else Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-07 20:48 ` Jonathan Cameron 2018-03-07 20:48 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 09/11] Staging: iio: accel: Use sign_extend32 function Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-05 7:49 ` [PATCH 10/11] Staging: iio: accel: Add comments about units in data read function Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-07 20:50 ` Jonathan Cameron 2018-03-07 20:50 ` Jonathan Cameron 2018-03-08 7:28 ` Himanshu Jha 2018-03-10 15:05 ` Jonathan Cameron 2018-03-10 15:05 ` Jonathan Cameron 2018-03-05 7:49 ` [PATCH 11/11] Staging: iio: accel: Move adis16201 driver out of staging subsystem Himanshu Jha 2018-03-05 7:49 ` Himanshu Jha 2018-03-07 20:58 ` Jonathan Cameron 2018-03-07 20:58 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180307203206.1ba1ecf8@archlinux \ --to=jic23@kernel.org \ --cc=Michael.Hennerich@analog.com \ --cc=daniel.baluta@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=himanshujha199640@gmail.com \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.