From: Lee Jones <lee.jones@linaro.org> To: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support Date: Thu, 8 Mar 2018 09:53:15 +0000 [thread overview] Message-ID: <20180308095315.mpcmx2ob6yhsnrm6@dell> (raw) In-Reply-To: <20180308094652.qg4atjw5c3hayaz3@earth.universe> On Thu, 08 Mar 2018, Sebastian Reichel wrote: > On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote: > > On Fri, 23 Feb 2018, Sebastian Reichel wrote: > > > +static const struct mfd_cell cpcap_mfd_devices[] = { > > [...] > > > > + }, { > > > + .name = "cpcap-led", > > > + .id = 4, > > > + .of_compatible = "motorola,cpcap-led-cp", > > > + }, { > > > + .name = "cpcap-codec", > > > + } > > > +}; > > > > With none of the entries containing platform_data /me wonders why you > > can't still use devm_of_platform_populate()? > > Because devm_of_platform_populate works with compatible properties and > cpcap-codec does not have one after I removed it for Mark. Sorry, I missed that conversation. Why was it removed? > > > static int cpcap_probe(struct spi_device *spi) > > > { > > > const struct of_device_id *match; > > > @@ -260,7 +308,8 @@ static int cpcap_probe(struct spi_device *spi) > > > if (ret) > > > return ret; > > > > > > - return devm_of_platform_populate(&cpcap->spi->dev); > > > + return devm_mfd_add_devices(&spi->dev, 0, cpcap_mfd_devices, > > > + ARRAY_SIZE(cpcap_mfd_devices), NULL, 0, NULL); > > > } > > > > > > static struct spi_driver cpcap_driver = { > > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Sebastian Reichel <sebastian.reichel@collabora.co.uk> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, kernel@collabora.com, Tony Lindgren <tony@atomide.com>, linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Subject: Re: [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support Date: Thu, 8 Mar 2018 09:53:15 +0000 [thread overview] Message-ID: <20180308095315.mpcmx2ob6yhsnrm6@dell> (raw) In-Reply-To: <20180308094652.qg4atjw5c3hayaz3@earth.universe> On Thu, 08 Mar 2018, Sebastian Reichel wrote: > On Wed, Mar 07, 2018 at 04:32:11PM +0000, Lee Jones wrote: > > On Fri, 23 Feb 2018, Sebastian Reichel wrote: > > > +static const struct mfd_cell cpcap_mfd_devices[] = { > > [...] > > > > + }, { > > > + .name = "cpcap-led", > > > + .id = 4, > > > + .of_compatible = "motorola,cpcap-led-cp", > > > + }, { > > > + .name = "cpcap-codec", > > > + } > > > +}; > > > > With none of the entries containing platform_data /me wonders why you > > can't still use devm_of_platform_populate()? > > Because devm_of_platform_populate works with compatible properties and > cpcap-codec does not have one after I removed it for Mark. Sorry, I missed that conversation. Why was it removed? > > > static int cpcap_probe(struct spi_device *spi) > > > { > > > const struct of_device_id *match; > > > @@ -260,7 +308,8 @@ static int cpcap_probe(struct spi_device *spi) > > > if (ret) > > > return ret; > > > > > > - return devm_of_platform_populate(&cpcap->spi->dev); > > > + return devm_mfd_add_devices(&spi->dev, 0, cpcap_mfd_devices, > > > + ARRAY_SIZE(cpcap_mfd_devices), NULL, 0, NULL); > > > } > > > > > > static struct spi_driver cpcap_driver = { > > -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2018-03-08 9:53 UTC|newest] Thread overview: 173+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-23 20:02 [PATCHv5 0/5] Motorola Droid 4 Audio Support Sebastian Reichel 2018-02-23 20:02 ` Sebastian Reichel 2018-02-23 20:02 ` [PATCHv5 1/5] dt-bindings: mfd: motorola-cpcap: document audio-codec Sebastian Reichel 2018-02-23 20:02 ` Sebastian Reichel 2018-02-26 10:08 ` Mark Brown 2018-02-26 10:08 ` Mark Brown 2018-03-02 19:07 ` Rob Herring 2018-03-02 19:07 ` Rob Herring 2018-03-07 16:30 ` Lee Jones 2018-03-07 16:30 ` Lee Jones 2018-02-23 20:02 ` [PATCHv5 2/5] ASoC: codec: cpcap: new codec Sebastian Reichel 2018-02-23 20:02 ` Sebastian Reichel 2018-02-26 1:36 ` [alsa-devel] " kbuild test robot 2018-02-26 1:36 ` kbuild test robot 2018-02-27 11:03 ` Mark Brown 2018-02-28 11:06 ` Applied "ASoC: cpcap: new codec" to the asoc tree Mark Brown 2018-02-28 11:06 ` Mark Brown 2018-02-23 20:02 ` [PATCHv5 3/5] mfd: motorola-cpcap: Add audio-codec support Sebastian Reichel 2018-02-23 20:02 ` Sebastian Reichel 2018-03-07 16:32 ` Lee Jones 2018-03-07 16:32 ` Lee Jones 2018-03-08 9:46 ` Sebastian Reichel 2018-03-08 9:53 ` Lee Jones [this message] 2018-03-08 9:53 ` Lee Jones 2018-03-08 10:27 ` Sebastian Reichel 2018-03-08 10:48 ` Lee Jones 2018-03-08 10:48 ` Lee Jones 2018-03-08 11:25 ` Mark Brown 2018-03-08 11:25 ` Mark Brown 2018-03-09 8:34 ` Lee Jones 2018-03-09 11:19 ` Sebastian Reichel 2018-03-09 11:19 ` Sebastian Reichel 2018-03-09 12:40 ` Mark Brown 2018-03-09 12:40 ` Mark Brown 2018-03-09 15:11 ` Tony Lindgren 2018-03-09 16:48 ` Sebastian Reichel 2018-03-09 16:48 ` Sebastian Reichel 2018-03-08 12:54 ` Sebastian Reichel 2018-03-08 17:07 ` Tony Lindgren 2018-03-09 11:29 ` Sebastian Reichel 2018-03-12 9:08 ` Lee Jones 2018-03-12 9:08 ` Lee Jones 2018-02-23 20:02 ` [PATCHv5 4/5] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel 2018-02-23 20:02 ` Sebastian Reichel 2018-02-23 20:02 ` [PATCHv5 5/5] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel 2018-02-23 20:02 ` Sebastian Reichel 2018-03-22 20:48 ` [PATCHv5,5/5] " Pavel Machek 2018-03-22 20:48 ` [PATCHv5, 5/5] " Pavel Machek 2018-03-22 23:48 ` [PATCHv5,5/5] " Sebastian Reichel 2018-03-23 10:09 ` Pavel Machek 2018-03-23 10:09 ` [PATCHv5, 5/5] " Pavel Machek 2018-03-23 10:30 ` [PATCHv5,5/5] " Sebastian Reichel 2018-03-23 10:30 ` [PATCHv5, 5/5] " Sebastian Reichel 2018-03-23 11:06 ` [PATCHv5,5/5] " Pavel Machek 2018-03-23 11:06 ` [PATCHv5, 5/5] " Pavel Machek 2018-03-23 11:08 ` [PATCHv5,5/5] " Pavel Machek 2018-03-23 11:08 ` [PATCHv5, 5/5] " Pavel Machek 2018-03-23 14:09 ` [PATCHv5,5/5] " Pavel Machek 2018-03-23 14:11 ` Pavel Machek 2018-03-23 14:11 ` [PATCHv5, 5/5] " Pavel Machek 2018-03-26 14:16 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-26 15:58 ` Sebastian Reichel 2018-03-26 20:31 ` Pavel Machek 2018-03-26 23:10 ` Sebastian Reichel 2018-03-27 20:41 ` Pavel Machek 2018-03-27 20:41 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-03-27 20:51 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Tony Lindgren 2018-03-27 12:14 ` Mark Brown 2018-03-27 12:14 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Mark Brown 2018-03-27 22:22 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Sebastian Reichel 2018-03-27 22:22 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Sebastian Reichel 2018-03-28 2:29 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Mark Brown 2018-03-28 2:29 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Mark Brown 2018-03-28 14:02 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Sebastian Reichel 2018-03-28 14:02 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Sebastian Reichel 2018-03-29 1:45 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Tony Lindgren 2018-03-29 13:36 ` Sebastian Reichel 2018-03-29 13:59 ` Tony Lindgren 2018-03-29 15:46 ` Sebastian Reichel 2018-03-29 16:06 ` Tony Lindgren 2018-03-30 10:57 ` Sebastian Reichel 2018-03-30 10:57 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Sebastian Reichel 2018-03-30 22:31 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-29 16:37 ` Pavel Machek 2018-03-29 16:41 ` Tony Lindgren 2018-03-29 18:40 ` Pavel Machek 2018-03-29 18:40 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-03-29 21:56 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Tony Lindgren 2018-03-30 10:37 ` Pavel Machek 2018-03-30 13:07 ` Merlijn Wajer 2018-03-30 15:22 ` Tony Lindgren 2018-03-30 15:25 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Michael Nazzareno Trimarchi 2018-03-30 15:44 ` [alsa-devel] " Tony Lindgren 2018-03-30 15:44 ` Tony Lindgren 2018-03-30 17:46 ` [alsa-devel] " Tony Lindgren 2018-03-30 15:34 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-30 15:34 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-03-30 17:50 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-30 18:01 ` Pavel Machek 2018-03-30 18:01 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-03-30 20:46 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-29 14:09 ` Pavel Machek 2018-03-29 14:21 ` Tony Lindgren 2018-03-29 16:08 ` Pavel Machek 2018-03-29 16:08 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-03-29 16:34 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Tony Lindgren 2018-03-29 16:34 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Tony Lindgren 2018-03-29 18:05 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-29 18:05 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-03-29 21:58 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Tony Lindgren 2018-03-29 21:58 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Tony Lindgren 2018-04-01 23:17 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Tony Lindgren 2018-04-01 23:17 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Tony Lindgren 2018-03-31 14:55 ` call/normal switch was Re: omap4-droid4: voice call support was Pavel Machek 2018-03-31 14:55 ` Pavel Machek 2018-03-31 18:19 ` Tony Lindgren 2018-03-31 19:19 ` Pavel Machek 2018-03-31 19:19 ` Pavel Machek 2018-03-31 19:46 ` Pavel Machek 2018-03-31 19:46 ` Pavel Machek 2018-03-31 19:55 ` Pavel Machek 2018-03-31 19:55 ` Pavel Machek 2018-03-31 23:43 ` Tony Lindgren 2018-04-01 6:48 ` Pavel Machek 2018-04-01 13:18 ` Pavel Machek 2018-04-01 13:18 ` Pavel Machek 2018-04-01 15:36 ` Tony Lindgren 2018-04-01 15:36 ` Tony Lindgren 2018-04-01 17:30 ` Tony Lindgren 2018-04-02 15:50 ` Dan Williams 2018-04-02 15:57 ` Tony Lindgren 2018-04-03 15:04 ` Tony Lindgren 2018-04-03 15:04 ` Tony Lindgren 2018-04-03 15:50 ` Pavel Machek 2018-04-03 15:50 ` Pavel Machek 2018-04-03 19:44 ` Tony Lindgren 2018-04-06 12:04 ` Pavel Machek 2018-04-06 12:04 ` Pavel Machek 2018-04-06 12:23 ` Merlijn Wajer 2018-04-06 12:23 ` Merlijn Wajer 2018-04-06 12:45 ` Pavel Machek 2018-04-06 12:45 ` Pavel Machek 2018-04-06 22:02 ` Pavel Machek 2018-04-07 8:10 ` simultaneous voice/data works (was Re: call/normal switch was Re: omap4-droid4: voice call support was) Pavel Machek 2018-04-07 8:10 ` Pavel Machek 2018-04-07 12:22 ` Pavel Machek 2018-04-07 12:22 ` Pavel Machek 2018-04-08 2:44 ` Dan Williams 2018-04-08 7:41 ` Pavel Machek 2018-04-09 3:15 ` Dan Williams 2018-04-09 14:08 ` Tony Lindgren 2018-04-09 15:53 ` Dan Williams 2018-04-09 20:21 ` Pavel Machek 2018-04-09 20:21 ` Pavel Machek 2018-04-10 10:58 ` Pavel Machek 2018-04-10 10:58 ` Pavel Machek 2018-04-10 13:50 ` Tony Lindgren 2018-04-10 13:50 ` Tony Lindgren 2018-04-11 11:43 ` Pavel Machek 2018-04-11 11:43 ` Pavel Machek 2018-04-03 22:11 ` call/normal switch was Re: omap4-droid4: voice call support was Pavel Machek 2018-04-03 22:11 ` Pavel Machek 2018-03-31 19:46 ` Tony Lindgren 2018-03-31 19:46 ` Tony Lindgren 2018-04-02 15:06 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard Mark Brown 2018-04-02 15:06 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Mark Brown 2018-03-28 9:00 ` omap4-droid4: voice call support was Re: [PATCHv5,5/5] " Pavel Machek 2018-03-28 9:36 ` Pavel Machek 2018-03-28 9:36 ` omap4-droid4: voice call support was Re: [PATCHv5, 5/5] " Pavel Machek 2018-04-03 8:52 ` [PATCHv5,5/5] " Pavel Machek 2018-02-23 22:24 ` [PATCHv5 0/5] Motorola Droid 4 Audio Support Tony Lindgren 2018-02-23 22:24 ` Tony Lindgren 2018-03-02 20:57 ` Tony Lindgren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180308095315.mpcmx2ob6yhsnrm6@dell \ --to=lee.jones@linaro.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=kernel@collabora.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=sebastian.reichel@collabora.co.uk \ --cc=tiwai@suse.com \ --cc=tony@atomide.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.