From: Alex Williamson <alex.williamson@redhat.com>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>,
"Duyck, Alexander H" <alexander.h.duyck@intel.com>,
linux-pci@vger.kernel.org, virtio-dev@lists.oasis-open.org,
kvm@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
"Daly, Dan" <dan.daly@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
netanel@amazon.com, Maximilian Heyne <mheyne@amazon.de>,
"Wang, Liang-min" <liang-min.wang@intel.com>,
"Rustad, Mark D" <mark.d.rustad@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
dwmw@amazon.co.uk
Subject: Re: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV
Date: Mon, 12 Mar 2018 10:28:36 -0600 [thread overview]
Message-ID: <20180312102836.6db05ef8@w520.home> (raw)
In-Reply-To: <CAKgT0UcJz7go-vRd88M6uo1mqbG9BfedkZmR0CXZ92m6KfRPzw@mail.gmail.com>
On Mon, 12 Mar 2018 09:01:54 -0700
Alexander Duyck <alexander.duyck@gmail.com> wrote:
> On Mon, Mar 12, 2018 at 12:59 AM, Christoph Hellwig <hch@lst.de> wrote:
> > On Sun, Mar 11, 2018 at 09:59:09PM -0600, Alex Williamson wrote:
> >> I still struggle to understand why we need this "unmanaged"
> >> complication and how a user of the sysfs API is expected to have any
> >> idea whether a PF is managed or unmanaged and why they should care.
> >> Can't we just have a pci_simple_sriov_configure() helper and ignore
> >> this unmanaged business? Thanks,
> >
> > Just a pci_simple_sriov_configure is exactly what I envisioned originally.
>
> I can drop the "unmanaged" bits if that is what is wanted, but based
> on previous conversations I thought there was some concern about the
> kernel loading VFs when there was some foreign entity managing the VFs
> other than the kernel.
My concern has always been whether the PF driver is trusted and by
dropping the vfio bits, the remaining drivers here are native, trusted,
host drivers, so I don't see that we have any reason to consider the
VFs as anything other than trusted as well. It's VFs where the PF
driver is untrusted, such as a userspace driver, which needs some kind
of quarantine, imo. Thanks,
Alex
WARNING: multiple messages have this Message-ID (diff)
From: alex.williamson@redhat.com (Alex Williamson)
Subject: [pci PATCH v4 1/4] pci-iov: Add support for unmanaged SR-IOV
Date: Mon, 12 Mar 2018 10:28:36 -0600 [thread overview]
Message-ID: <20180312102836.6db05ef8@w520.home> (raw)
In-Reply-To: <CAKgT0UcJz7go-vRd88M6uo1mqbG9BfedkZmR0CXZ92m6KfRPzw@mail.gmail.com>
On Mon, 12 Mar 2018 09:01:54 -0700
Alexander Duyck <alexander.duyck@gmail.com> wrote:
> On Mon, Mar 12, 2018@12:59 AM, Christoph Hellwig <hch@lst.de> wrote:
> > On Sun, Mar 11, 2018 at 09:59:09PM -0600, Alex Williamson wrote:
> >> I still struggle to understand why we need this "unmanaged"
> >> complication and how a user of the sysfs API is expected to have any
> >> idea whether a PF is managed or unmanaged and why they should care.
> >> Can't we just have a pci_simple_sriov_configure() helper and ignore
> >> this unmanaged business? Thanks,
> >
> > Just a pci_simple_sriov_configure is exactly what I envisioned originally.
>
> I can drop the "unmanaged" bits if that is what is wanted, but based
> on previous conversations I thought there was some concern about the
> kernel loading VFs when there was some foreign entity managing the VFs
> other than the kernel.
My concern has always been whether the PF driver is trusted and by
dropping the vfio bits, the remaining drivers here are native, trusted,
host drivers, so I don't see that we have any reason to consider the
VFs as anything other than trusted as well. It's VFs where the PF
driver is untrusted, such as a userspace driver, which needs some kind
of quarantine, imo. Thanks,
Alex
next prev parent reply other threads:[~2018-03-12 16:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 19:00 [pci PATCH v4 0/4] Add support for unmanaged SR-IOV Alexander Duyck
2018-03-08 19:00 ` [virtio-dev] " Alexander Duyck
2018-03-08 19:00 ` Alexander Duyck
2018-03-08 19:02 ` [pci PATCH v4 1/4] pci-iov: " Alexander Duyck
2018-03-08 19:02 ` [virtio-dev] " Alexander Duyck
2018-03-08 19:02 ` Alexander Duyck
2018-03-12 3:59 ` Alex Williamson
2018-03-12 3:59 ` Alex Williamson
2018-03-12 7:59 ` Christoph Hellwig
2018-03-12 7:59 ` Christoph Hellwig
2018-03-12 16:01 ` Alexander Duyck
2018-03-12 16:01 ` [virtio-dev] " Alexander Duyck
2018-03-12 16:01 ` Alexander Duyck
2018-03-12 16:28 ` Alex Williamson [this message]
2018-03-12 16:28 ` Alex Williamson
2018-03-08 19:03 ` [pci PATCH v4 2/4] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Alexander Duyck
2018-03-08 19:03 ` [virtio-dev] " Alexander Duyck
2018-03-08 19:03 ` Alexander Duyck
2018-03-08 19:03 ` [pci PATCH v4 3/4] ena: Migrate over to "unmanaged SR-IOV" support Alexander Duyck
2018-03-08 19:03 ` [virtio-dev] " Alexander Duyck
2018-03-08 19:03 ` Alexander Duyck
2018-03-08 19:04 ` [pci PATCH v4 4/4] nvme: " Alexander Duyck
2018-03-08 19:04 ` [virtio-dev] " Alexander Duyck
2018-03-08 19:04 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312102836.6db05ef8@w520.home \
--to=alex.williamson@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=bhelgaas@google.com \
--cc=dan.daly@intel.com \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=kvm@vger.kernel.org \
--cc=liang-min.wang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.d.rustad@intel.com \
--cc=mheyne@amazon.de \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.