From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Alexander Usyskin <alexander.usyskin@intel.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2 v3] tpm: separate cmd_ready/go_idle from runtime_pm
Date: Fri, 23 Mar 2018 10:12:10 +0200 [thread overview]
Message-ID: <20180323081210.GA28857@linux.intel.com> (raw)
In-Reply-To: <20180305180831.GB6220@linux.intel.com>
On Mon, Mar 05, 2018 at 08:08:31PM +0200, Jarkko Sakkinen wrote:
> On Tue, Feb 20, 2018 at 04:13:30PM +0200, Jarkko Sakkinen wrote:
> > On Mon, 2018-02-19 at 13:52 +0200, Jarkko Sakkinen wrote:
> > > On Wed, Feb 14, 2018 at 03:43:19PM +0200, Tomas Winkler wrote:
> > > > We cannot use go_idle cmd_ready commands via runtime_pm handles
> > > > as with the introduction of localities this is no longer an
> > > > optional
> > > > feature, while runtime pm can be not enabled.
> > > > Though cmd_ready/go_idle provides power saving feature, it's also
> > > > part of
> > > > TPM2 protocol and should be called explicitly.
> > > > This patch exposes cmd_read/go_idle via tpm class ops and removes
> > > > runtime pm support as it is not used by any driver.
> > > >
> > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > > ---
> > > > V2: resent
> > > > V3: resent
> > >
> > > Only the cover letter needs a backlog but the code change looks
> > > good to me.
> > >
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > /Jarkko
>
> Applied.
>
> /Jarkko
This commit breaks my smoke tests on Kabylake [1] so I need to drop it.
The bug fix for locality works without any issues.
[1]
$ python -m unittest -v tpm2_smoke
test_seal_with_auth (tpm2_smoke.SmokeTest) ... ok
test_seal_with_policy (tpm2_smoke.SmokeTest) ... ok
test_seal_with_too_long_auth (tpm2_smoke.SmokeTest) ... ok
test_too_short_cmd (tpm2_smoke.SmokeTest) ... ok
test_unseal_with_wrong_auth (tpm2_smoke.SmokeTest) ... ok
test_unseal_with_wrong_policy (tpm2_smoke.SmokeTest) ... ok
test_flush_context (tpm2_smoke.SpaceTest) ... ERROR
test_get_handles (tpm2_smoke.SpaceTest) ... ERROR
test_invalid_cc (tpm2_smoke.SpaceTest) ... ok
test_make_two_spaces (tpm2_smoke.SpaceTest) ... ERROR
======================================================================
ERROR: test_flush_context (tpm2_smoke.SpaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tpm2_smoke.py", line 185, in test_flush_context
space1.flush_context(root1)
File "tpm2.py", line 517, in flush_context
self.send_cmd(cmd)
File "tpm2.py", line 378, in send_cmd
raise ProtocolError(cc, rc)
ProtocolError: TPM_RC_UNKNOWN: cc=0x00000165, rc=0x00000165
======================================================================
ERROR: test_get_handles (tpm2_smoke.SpaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tpm2_smoke.py", line 195, in test_get_handles
space2.create_root_key()
File "tpm2.py", line 562, in create_root_key
return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
File "tpm2.py", line 378, in send_cmd
raise ProtocolError(cc, rc)
ProtocolError: TPM_RC_UNBALANCED: cc=0x00000131, rc=0x00000131
======================================================================
ERROR: test_make_two_spaces (tpm2_smoke.SpaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tpm2_smoke.py", line 171, in test_make_two_spaces
root3 = space2.create_root_key()
File "tpm2.py", line 562, in create_root_key
return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
File "tpm2.py", line 378, in send_cmd
raise ProtocolError(cc, rc)
ProtocolError: TPM_RC_UNBALANCED: cc=0x00000131, rc=0x00000131
----------------------------------------------------------------------
Ran 10 tests in 44.545s
FAILED (errors=3)
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 2/2 v3] tpm: separate cmd_ready/go_idle from runtime_pm
Date: Fri, 23 Mar 2018 10:12:10 +0200 [thread overview]
Message-ID: <20180323081210.GA28857@linux.intel.com> (raw)
In-Reply-To: <20180305180831.GB6220@linux.intel.com>
On Mon, Mar 05, 2018 at 08:08:31PM +0200, Jarkko Sakkinen wrote:
> On Tue, Feb 20, 2018 at 04:13:30PM +0200, Jarkko Sakkinen wrote:
> > On Mon, 2018-02-19 at 13:52 +0200, Jarkko Sakkinen wrote:
> > > On Wed, Feb 14, 2018 at 03:43:19PM +0200, Tomas Winkler wrote:
> > > > We cannot use go_idle cmd_ready commands via runtime_pm handles
> > > > as with the introduction of localities this is no longer an
> > > > optional
> > > > feature, while runtime pm can be not enabled.
> > > > Though cmd_ready/go_idle provides power saving feature, it's also
> > > > part of
> > > > TPM2 protocol and should be called explicitly.
> > > > This patch exposes cmd_read/go_idle via tpm class ops and removes
> > > > runtime pm support as it is not used by any driver.
> > > >
> > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > > ---
> > > > V2: resent
> > > > V3: resent
> > >
> > > Only the cover letter needs a backlog but the code change looks
> > > good to me.
> > >
> > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> >
> > /Jarkko
>
> Applied.
>
> /Jarkko
This commit breaks my smoke tests on Kabylake [1] so I need to drop it.
The bug fix for locality works without any issues.
[1]
$ python -m unittest -v tpm2_smoke
test_seal_with_auth (tpm2_smoke.SmokeTest) ... ok
test_seal_with_policy (tpm2_smoke.SmokeTest) ... ok
test_seal_with_too_long_auth (tpm2_smoke.SmokeTest) ... ok
test_too_short_cmd (tpm2_smoke.SmokeTest) ... ok
test_unseal_with_wrong_auth (tpm2_smoke.SmokeTest) ... ok
test_unseal_with_wrong_policy (tpm2_smoke.SmokeTest) ... ok
test_flush_context (tpm2_smoke.SpaceTest) ... ERROR
test_get_handles (tpm2_smoke.SpaceTest) ... ERROR
test_invalid_cc (tpm2_smoke.SpaceTest) ... ok
test_make_two_spaces (tpm2_smoke.SpaceTest) ... ERROR
======================================================================
ERROR: test_flush_context (tpm2_smoke.SpaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tpm2_smoke.py", line 185, in test_flush_context
space1.flush_context(root1)
File "tpm2.py", line 517, in flush_context
self.send_cmd(cmd)
File "tpm2.py", line 378, in send_cmd
raise ProtocolError(cc, rc)
ProtocolError: TPM_RC_UNKNOWN: cc=0x00000165, rc=0x00000165
======================================================================
ERROR: test_get_handles (tpm2_smoke.SpaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tpm2_smoke.py", line 195, in test_get_handles
space2.create_root_key()
File "tpm2.py", line 562, in create_root_key
return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
File "tpm2.py", line 378, in send_cmd
raise ProtocolError(cc, rc)
ProtocolError: TPM_RC_UNBALANCED: cc=0x00000131, rc=0x00000131
======================================================================
ERROR: test_make_two_spaces (tpm2_smoke.SpaceTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tpm2_smoke.py", line 171, in test_make_two_spaces
root3 = space2.create_root_key()
File "tpm2.py", line 562, in create_root_key
return struct.unpack('>I', self.send_cmd(cmd)[10:14])[0]
File "tpm2.py", line 378, in send_cmd
raise ProtocolError(cc, rc)
ProtocolError: TPM_RC_UNBALANCED: cc=0x00000131, rc=0x00000131
----------------------------------------------------------------------
Ran 10 tests in 44.545s
FAILED (errors=3)
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-23 8:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 13:43 [PATCH 0/2 v3] tpm: fix locality and power saving handling Tomas Winkler
2018-02-14 13:43 ` Tomas Winkler
2018-02-14 13:43 ` [PATCH 1/2 v3] tpm: cmd_ready command can be issued only after granting locality Tomas Winkler
2018-02-14 13:43 ` Tomas Winkler
2018-02-19 11:27 ` Jarkko Sakkinen
2018-02-19 11:27 ` Jarkko Sakkinen
2018-02-19 11:43 ` Winkler, Tomas
2018-02-19 11:43 ` Winkler, Tomas
2018-02-20 14:57 ` Jarkko Sakkinen
2018-02-20 14:57 ` Jarkko Sakkinen
2018-02-20 20:26 ` Winkler, Tomas
2018-02-20 20:26 ` Winkler, Tomas
2018-02-20 23:03 ` Jarkko Sakkinen
2018-02-20 23:03 ` Jarkko Sakkinen
2018-02-20 14:12 ` Jarkko Sakkinen
2018-02-20 14:12 ` Jarkko Sakkinen
2018-02-14 13:43 ` [PATCH 2/2 v3] tpm: separate cmd_ready/go_idle from runtime_pm Tomas Winkler
2018-02-14 13:43 ` Tomas Winkler
2018-02-19 11:52 ` Jarkko Sakkinen
2018-02-19 11:52 ` Jarkko Sakkinen
2018-02-20 14:13 ` Jarkko Sakkinen
2018-02-20 14:13 ` Jarkko Sakkinen
2018-03-05 18:08 ` Jarkko Sakkinen
2018-03-05 18:08 ` Jarkko Sakkinen
2018-03-23 8:12 ` Jarkko Sakkinen [this message]
2018-03-23 8:12 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180323081210.GA28857@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.