From: Jonathan Cameron <jic23@kernel.org> To: Brian Masney <masneyb@onstation.org> Cc: devel@driverdev.osuosl.org, lars@metafoo.de, linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com, pmeerw@pmeerw.net, knaack.h@gmx.de Subject: Re: [PATCH 10/11] staging: iio: tsl2x7x: put local variables in reverse Christmas tree order Date: Sat, 24 Mar 2018 13:44:10 +0000 [thread overview] Message-ID: <20180324134410.142b622e@archlinux> (raw) In-Reply-To: <20180321102912.5130-11-masneyb@onstation.org> On Wed, 21 Mar 2018 06:29:11 -0400 Brian Masney <masneyb@onstation.org> wrote: > This patch ensures that all of the local variable declarations are in > reverse Christmas tree order where possible to increase code > readability. > > Signed-off-by: Brian Masney <masneyb@onstation.org> Applied. As ever it's a minor improvement but I suppose worth doing whilst we are there! Thanks, Jonathan. > --- > drivers/staging/iio/light/tsl2x7x.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c > index 65b7fbca8c5d..5f78664d2b0e 100644 > --- a/drivers/staging/iio/light/tsl2x7x.c > +++ b/drivers/staging/iio/light/tsl2x7x.c > @@ -336,13 +336,12 @@ static int tsl2x7x_write_control_reg(struct tsl2X7X_chip *chip, u8 data) > */ > static int tsl2x7x_get_lux(struct iio_dev *indio_dev) > { > - u32 lux; /* raw lux calculated from device data */ > - u64 lux64; > - u32 ratio; > - u8 buf[4]; > - struct tsl2x7x_lux *p; > struct tsl2X7X_chip *chip = iio_priv(indio_dev); > + struct tsl2x7x_lux *p; > + u32 lux, ratio; > int i, ret; > + u64 lux64; > + u8 buf[4]; > > mutex_lock(&chip->als_mutex); > > @@ -589,13 +588,9 @@ static int tsl2x7x_als_calibrate(struct iio_dev *indio_dev) > > static int tsl2x7x_chip_on(struct iio_dev *indio_dev) > { > - int i; > - int ret = 0; > - u8 *dev_reg; > - int als_count; > - int als_time; > struct tsl2X7X_chip *chip = iio_priv(indio_dev); > - u8 reg_val = 0; > + int ret, i, als_count, als_time; > + u8 *dev_reg, reg_val; > > /* Non calculated parameters */ > chip->tsl2x7x_config[TSL2X7X_PRX_TIME] = chip->settings.prx_time; > @@ -1121,8 +1116,8 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev, > int *val2, > long mask) > { > - int ret = -EINVAL; > struct tsl2X7X_chip *chip = iio_priv(indio_dev); > + int ret = -EINVAL; > > switch (mask) { > case IIO_CHAN_INFO_PROCESSED: > @@ -1583,9 +1578,9 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > static int tsl2x7x_probe(struct i2c_client *clientp, > const struct i2c_device_id *id) > { > - int ret; > struct iio_dev *indio_dev; > struct tsl2X7X_chip *chip; > + int ret; > > indio_dev = devm_iio_device_alloc(&clientp->dev, sizeof(*chip)); > if (!indio_dev) _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Brian Masney <masneyb@onstation.org> Cc: linux-iio@vger.kernel.org, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, Jon.Brenner@ams.com Subject: Re: [PATCH 10/11] staging: iio: tsl2x7x: put local variables in reverse Christmas tree order Date: Sat, 24 Mar 2018 13:44:10 +0000 [thread overview] Message-ID: <20180324134410.142b622e@archlinux> (raw) In-Reply-To: <20180321102912.5130-11-masneyb@onstation.org> On Wed, 21 Mar 2018 06:29:11 -0400 Brian Masney <masneyb@onstation.org> wrote: > This patch ensures that all of the local variable declarations are in > reverse Christmas tree order where possible to increase code > readability. > > Signed-off-by: Brian Masney <masneyb@onstation.org> Applied. As ever it's a minor improvement but I suppose worth doing whilst we are there! Thanks, Jonathan. > --- > drivers/staging/iio/light/tsl2x7x.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/iio/light/tsl2x7x.c b/drivers/staging/iio/light/tsl2x7x.c > index 65b7fbca8c5d..5f78664d2b0e 100644 > --- a/drivers/staging/iio/light/tsl2x7x.c > +++ b/drivers/staging/iio/light/tsl2x7x.c > @@ -336,13 +336,12 @@ static int tsl2x7x_write_control_reg(struct tsl2X7X_chip *chip, u8 data) > */ > static int tsl2x7x_get_lux(struct iio_dev *indio_dev) > { > - u32 lux; /* raw lux calculated from device data */ > - u64 lux64; > - u32 ratio; > - u8 buf[4]; > - struct tsl2x7x_lux *p; > struct tsl2X7X_chip *chip = iio_priv(indio_dev); > + struct tsl2x7x_lux *p; > + u32 lux, ratio; > int i, ret; > + u64 lux64; > + u8 buf[4]; > > mutex_lock(&chip->als_mutex); > > @@ -589,13 +588,9 @@ static int tsl2x7x_als_calibrate(struct iio_dev *indio_dev) > > static int tsl2x7x_chip_on(struct iio_dev *indio_dev) > { > - int i; > - int ret = 0; > - u8 *dev_reg; > - int als_count; > - int als_time; > struct tsl2X7X_chip *chip = iio_priv(indio_dev); > - u8 reg_val = 0; > + int ret, i, als_count, als_time; > + u8 *dev_reg, reg_val; > > /* Non calculated parameters */ > chip->tsl2x7x_config[TSL2X7X_PRX_TIME] = chip->settings.prx_time; > @@ -1121,8 +1116,8 @@ static int tsl2x7x_read_raw(struct iio_dev *indio_dev, > int *val2, > long mask) > { > - int ret = -EINVAL; > struct tsl2X7X_chip *chip = iio_priv(indio_dev); > + int ret = -EINVAL; > > switch (mask) { > case IIO_CHAN_INFO_PROCESSED: > @@ -1583,9 +1578,9 @@ static const struct tsl2x7x_chip_info tsl2x7x_chip_info_tbl[] = { > static int tsl2x7x_probe(struct i2c_client *clientp, > const struct i2c_device_id *id) > { > - int ret; > struct iio_dev *indio_dev; > struct tsl2X7X_chip *chip; > + int ret; > > indio_dev = devm_iio_device_alloc(&clientp->dev, sizeof(*chip)); > if (!indio_dev)
next prev parent reply other threads:[~2018-03-24 13:44 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-21 10:29 [PATCH 00/11] staging: iio: tsl2x7x: staging cleanups Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-21 10:29 ` [PATCH 01/11] staging: iio: tsl2x7x: remove unnecessary code Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:32 ` Jonathan Cameron 2018-03-24 13:32 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 02/11] staging: iio: tsl2x7x: correct interrupt handler trigger Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:33 ` Jonathan Cameron 2018-03-24 13:33 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 03/11] staging: iio: tsl2x7x: no need to clear interrupt flag when getting lux Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:34 ` Jonathan Cameron 2018-03-24 13:34 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 04/11] staging: iio: tsl2x7x: simplify tsl2x7x_prox_cal() Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:35 ` Jonathan Cameron 2018-03-24 13:35 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 05/11] staging: iio: tsl2x7x: split out als and prox interrupt settings Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:36 ` Jonathan Cameron 2018-03-24 13:36 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 06/11] staging: iio: tsl2x7x: make logging consistent and correct newlines Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:39 ` Jonathan Cameron 2018-03-24 13:39 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 07/11] staging: iio: tsl2x7x: split out als and prox persistence settings Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:40 ` Jonathan Cameron 2018-03-24 13:40 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 08/11] staging: iio: tsl2x7x: remove unused variables from tsl2x7x_get_lux() Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:41 ` Jonathan Cameron 2018-03-24 13:41 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 09/11] staging: iio: tsl2x7x: remove ch0 and ch1 " Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:42 ` Jonathan Cameron 2018-03-24 13:42 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 10/11] staging: iio: tsl2x7x: put local variables in reverse Christmas tree order Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:44 ` Jonathan Cameron [this message] 2018-03-24 13:44 ` Jonathan Cameron 2018-03-21 10:29 ` [PATCH 11/11] staging: iio: tsl2x7x: add copyright Brian Masney 2018-03-21 10:29 ` Brian Masney 2018-03-24 13:46 ` Jonathan Cameron 2018-03-24 13:46 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180324134410.142b622e@archlinux \ --to=jic23@kernel.org \ --cc=Jon.Brenner@ams.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=masneyb@onstation.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.