From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-mmc@vger.kernel.org
Cc: "Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Simon Horman" <horms+renesas@verge.net.au>,
"Nguyen Viet Dung" <dung.nguyen.aj@renesas.com>
Subject: [PATCH 4/5] mmc: renesas_sdhi_internal_dmac: use more generic whitelisting
Date: Tue, 10 Apr 2018 11:38:30 +0200 [thread overview]
Message-ID: <20180410093831.1759-5-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20180410093831.1759-1-wsa+renesas@sang-engineering.com>
Whitelisting every ES version does not scale. So, we whitelist whole
SoCs independent of ES version. If we need specific handling for an ES
version, we put it to the front, so it will be matched first.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Tested-by: Nguyen Viet Dung <dung.nguyen.aj@renesas.com>
---
drivers/mmc/host/renesas_sdhi_internal_dmac.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
index 32b8be4c0b81..06b4e0004ca4 100644
--- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c
+++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c
@@ -272,12 +272,15 @@ static const struct tmio_mmc_dma_ops renesas_sdhi_internal_dmac_dma_ops = {
* implementation as others may use a different implementation.
*/
static const struct soc_device_attribute gen3_soc_whitelist[] = {
+ /* specific ones */
{ .soc_id = "r8a7795", .revision = "ES1.*",
.data = (void *)BIT(SDHI_INTERNAL_DMAC_ONE_RX_ONLY) },
- { .soc_id = "r8a7795", .revision = "ES2.0" },
{ .soc_id = "r8a7796", .revision = "ES1.0",
.data = (void *)BIT(SDHI_INTERNAL_DMAC_ONE_RX_ONLY) },
- { .soc_id = "r8a77995", .revision = "ES1.0" },
+ /* generic ones */
+ { .soc_id = "r8a7795" },
+ { .soc_id = "r8a7796" },
+ { .soc_id = "r8a77995" },
{ /* sentinel */ }
};
--
2.11.0
next prev parent reply other threads:[~2018-04-10 9:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 9:38 [PATCH 0/5] mmc: renesas_sdhi_internal_dmac: DMA handling fixes Wolfram Sang
2018-04-10 9:38 ` [PATCH 1/5] mmc: renesas_sdhi_internal_dmac: limit DMA RX for old SoCs Wolfram Sang
2018-04-10 9:48 ` Geert Uytterhoeven
2018-04-12 11:11 ` Wolfram Sang
2018-04-12 11:25 ` Geert Uytterhoeven
2018-04-12 11:31 ` Wolfram Sang
2018-04-12 11:34 ` Geert Uytterhoeven
2018-04-12 11:40 ` Wolfram Sang
2018-04-11 7:14 ` Simon Horman
2018-04-12 11:21 ` Wolfram Sang
2018-04-13 8:14 ` Simon Horman
2018-04-13 8:35 ` Wolfram Sang
2018-04-13 9:47 ` Simon Horman
2018-04-10 9:38 ` [PATCH 2/5] mmc: renesas_sdhi: use helpers to access struct scatterlist members Wolfram Sang
2018-04-11 7:15 ` Simon Horman
2018-04-10 9:38 ` [PATCH 3/5] mmc: renesas_sdhi: Fix alignment check of sg buffer Wolfram Sang
2018-04-11 7:17 ` Simon Horman
2018-04-10 9:38 ` Wolfram Sang [this message]
2018-04-10 9:38 ` [PATCH 5/5] mmc: renesas_sdhi_internal_dmac: remove superfluous WARN Wolfram Sang
2018-04-11 7:23 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180410093831.1759-5-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=dung.nguyen.aj@renesas.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.