From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Linux MMC List" <linux-mmc@vger.kernel.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Nguyen Viet Dung" <dung.nguyen.aj@renesas.com>
Subject: Re: [PATCH 1/5] mmc: renesas_sdhi_internal_dmac: limit DMA RX for old SoCs
Date: Thu, 12 Apr 2018 13:34:41 +0200 [thread overview]
Message-ID: <CAMuHMdVnYrw+Z_+REEpTOb7_N3UHAgUhjpuwHk+JKew=UMDeZg@mail.gmail.com> (raw)
In-Reply-To: <20180412113134.nzz4ncvl453dkcvr@katana>
Hi Wolfram,
On Thu, Apr 12, 2018 at 1:31 PM, Wolfram Sang <wsa@the-dreams.de> wrote:
>> That should have been caught by the !soc check above, and have already
>> returned with -ENODEV.
>
> Now I get it: You mean non-0 check, not non-NULL check...
soc->data _is_ a pointer. You only cast it to an integer on the next line.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2018-04-12 11:34 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 9:38 [PATCH 0/5] mmc: renesas_sdhi_internal_dmac: DMA handling fixes Wolfram Sang
2018-04-10 9:38 ` [PATCH 1/5] mmc: renesas_sdhi_internal_dmac: limit DMA RX for old SoCs Wolfram Sang
2018-04-10 9:48 ` Geert Uytterhoeven
2018-04-12 11:11 ` Wolfram Sang
2018-04-12 11:25 ` Geert Uytterhoeven
2018-04-12 11:31 ` Wolfram Sang
2018-04-12 11:34 ` Geert Uytterhoeven [this message]
2018-04-12 11:40 ` Wolfram Sang
2018-04-11 7:14 ` Simon Horman
2018-04-12 11:21 ` Wolfram Sang
2018-04-13 8:14 ` Simon Horman
2018-04-13 8:35 ` Wolfram Sang
2018-04-13 9:47 ` Simon Horman
2018-04-10 9:38 ` [PATCH 2/5] mmc: renesas_sdhi: use helpers to access struct scatterlist members Wolfram Sang
2018-04-11 7:15 ` Simon Horman
2018-04-10 9:38 ` [PATCH 3/5] mmc: renesas_sdhi: Fix alignment check of sg buffer Wolfram Sang
2018-04-11 7:17 ` Simon Horman
2018-04-10 9:38 ` [PATCH 4/5] mmc: renesas_sdhi_internal_dmac: use more generic whitelisting Wolfram Sang
2018-04-10 9:38 ` [PATCH 5/5] mmc: renesas_sdhi_internal_dmac: remove superfluous WARN Wolfram Sang
2018-04-11 7:23 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdVnYrw+Z_+REEpTOb7_N3UHAgUhjpuwHk+JKew=UMDeZg@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=dung.nguyen.aj@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.